[libvirt PATCH] qemu: Remove duplicate user/group lookup

Andrea Bolognani posted 1 patch 1 year ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230301180442.605690-1-abologna@redhat.com
src/qemu/qemu_conf.c | 6 ------
1 file changed, 6 deletions(-)
[libvirt PATCH] qemu: Remove duplicate user/group lookup
Posted by Andrea Bolognani 1 year ago
Commit 068efae5b1a9 created a copy of this code instead of
simply moving it.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/qemu/qemu_conf.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index a831783d75..680832742c 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -173,12 +173,6 @@ virQEMUDriverConfig *virQEMUDriverConfigNew(bool privileged,
         cfg->memoryBackingDir = g_strdup_printf("%s/ram", cfg->libDir);
         cfg->swtpmStorageDir = g_strdup_printf("%s/lib/libvirt/swtpm",
                                                LOCALSTATEDIR);
-        if (!virDoesUserExist("tss") ||
-            virGetUserID("tss", &cfg->swtpm_user) < 0)
-            cfg->swtpm_user = 0; /* fall back to root */
-        if (!virDoesGroupExist("tss") ||
-            virGetGroupID("tss", &cfg->swtpm_group) < 0)
-            cfg->swtpm_group = 0; /* fall back to root */
     } else {
         g_autofree char *rundir = NULL;
         g_autofree char *cachedir = NULL;
-- 
2.39.2
Re: [libvirt PATCH] qemu: Remove duplicate user/group lookup
Posted by Peter Krempa 1 year ago
On Wed, Mar 01, 2023 at 19:04:42 +0100, Andrea Bolognani wrote:
> Commit 068efae5b1a9 created a copy of this code instead of
> simply moving it.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/qemu/qemu_conf.c | 6 ------
>  1 file changed, 6 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>