From nobody Tue Feb 10 04:29:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1677073637; cv=none; d=zohomail.com; s=zohoarc; b=A06U/uLG41kiufi8iD/9+pJXppxxeDEyBykltapCFEYN8wBuT1b1I3m7atU8u+aNmfpJ7zeMuZjl29Zf9Szb+RjYg9o41vlMfx40tvgLx+tFTqNYHZX9ICTIL23Op+AI4aedftO++kCfGpm76xFAcLav/eGBxs076RMr5fRiJec= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677073637; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kTY4z3PyUO1Oh04GMeSym3hUQSjakS66dPhlbZKogJI=; b=mubReEQpGNhalQgLRxLG4Kvk4RvfsDwPPPwhZ7j4ilM/gyAF4/KJb+PTwTfl17Hjm3ZQ4lKklfDnKVyF/19bFYK97Qm8OxA8ofJksru96bxfrYDSuZ3rC6O02w/tUMTs7sqRY7d2LFaMA7d9DH/OgpkdIVCPKZCaI2vzAvQVe/M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1677073637681551.2792570806198; Wed, 22 Feb 2023 05:47:17 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-EvWxnTxNOric4BG2wK84oA-1; Wed, 22 Feb 2023 08:47:12 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 832681C02D28; Wed, 22 Feb 2023 13:47:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6DFBF40168BA; Wed, 22 Feb 2023 13:47:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 48F951946588; Wed, 22 Feb 2023 13:47:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1AD471946587 for ; Wed, 22 Feb 2023 13:21:38 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0DADBC15BAE; Wed, 22 Feb 2023 13:21:38 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0422DC16020 for ; Wed, 22 Feb 2023 13:21:37 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DFFD419705B7 for ; Wed, 22 Feb 2023 13:21:37 +0000 (UTC) Received: from passt.top (passt.top [88.198.0.164]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-517-HStXjhsCMimghcvO-C0HFA-1; Wed, 22 Feb 2023 08:21:33 -0500 Received: by passt.top (Postfix, from userid 1000) id 00D955A026D; Wed, 22 Feb 2023 14:21:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677073636; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=kTY4z3PyUO1Oh04GMeSym3hUQSjakS66dPhlbZKogJI=; b=FvkcGSxuzy2fRLXSmtYklRNRVPiQKx7nzCmZINYnc/Se06lAJcYcnEriR8T8OgAi///BUr 7zjYpMu67z0GNn84IgKOCWaRRHNh3/3ycy4ANkD4neCqHy8LRJluXajRx69ryZMzW7BiKA ivKZBnCVjXj3ssV4WjQCquJbJFkNy9I= X-MC-Unique: EvWxnTxNOric4BG2wK84oA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: HStXjhsCMimghcvO-C0HFA-1 From: Stefano Brivio To: libvir-list@redhat.com Subject: [PATCH v2 3/3] qemu_passt: Remove passt socket file on exit Date: Wed, 22 Feb 2023 14:21:31 +0100 Message-Id: <20230222132131.3811642-4-sbrivio@redhat.com> In-Reply-To: <20230222132131.3811642-1-sbrivio@redhat.com> References: <20230222132131.3811642-1-sbrivio@redhat.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Michal=20Pr=C3=ADvozn=C3=ADk?= , Laine Stump Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1677073638892100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Just like it can't remove its own PID files, passt can't unlink its own socket upon exit (unless the initialisation fails), because it has no access to the filesystem at runtime. Remove the socket file in qemuPasstKill(). Fixes: a56f0168d576 ("qemu: hook up passt config to qemu domains") Signed-off-by: Stefano Brivio --- src/qemu/qemu_passt.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c index 61e7047354..d5df3bb3f7 100644 --- a/src/qemu/qemu_passt.c +++ b/src/qemu/qemu_passt.c @@ -108,7 +108,7 @@ qemuPasstAddNetProps(virDomainObj *vm, =20 =20 static void -qemuPasstKill(const char *pidfile) +qemuPasstKill(const char *pidfile, const char *passtSocketName) { virErrorPtr orig_err; pid_t pid =3D 0; @@ -120,6 +120,8 @@ qemuPasstKill(const char *pidfile) virProcessKillPainfully(pid, true); unlink(pidfile); =20 + unlink(passtSocketName); + virErrorRestore(&orig_err); } =20 @@ -129,8 +131,9 @@ qemuPasstStop(virDomainObj *vm, virDomainNetDef *net) { g_autofree char *pidfile =3D qemuPasstCreatePidFilename(vm, net); + g_autofree char *passtSocketName =3D qemuPasstCreateSocketPath(vm, net= ); =20 - qemuPasstKill(pidfile); + qemuPasstKill(pidfile, passtSocketName); } =20 =20 --=20 2.39.1