From nobody Tue Feb 10 04:29:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1677073805; cv=none; d=zohomail.com; s=zohoarc; b=gQ4/rkNpLjhayeIT7ZjyNzOhL76MgCwUL+8FfT/butqAvME6Ce0vtd8COhC7D0Td7rdJq8PfcRBpVQu2OEbwdzpydPcmGTqv6EyBgJ8/vVsTmFKb8StxPioQ1NibTr4GF6jQvVWdefMAoJl86Qr8GSK3ivb0v/7vEZiH4J/OX3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677073805; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UP/LYPXS5lU1GB0NcUlCRKiY22F9uMQFknB6V4tTXfo=; b=JpUt38t/KqW0KaUY5NKvRGerGRmcU5tQ/BHWuYlo3SwPfBw6rxXuyGEvTl6ZQ2Yv5YV6i+EmReZoIE8bF2My9rr9/I9J0zkmO2+3F0sJCoVJyVqPiIksshCgeAIPNohjlJKsoo1nzxVJQxEiqxwkACFUdNcnYluXFRwKrIDD11w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1677073804823324.9561891961919; Wed, 22 Feb 2023 05:50:04 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-205--b0EorrQPNWJd_L4igOtMA-1; Wed, 22 Feb 2023 08:49:41 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 56C1A85CBD0; Wed, 22 Feb 2023 13:49:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA3DA492B00; Wed, 22 Feb 2023 13:49:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CC3091946588; Wed, 22 Feb 2023 13:49:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1DDE51946587 for ; Wed, 22 Feb 2023 13:21:37 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id F20B92166B29; Wed, 22 Feb 2023 13:21:36 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EBC9D2166B26 for ; Wed, 22 Feb 2023 13:21:36 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D1A0185CBE8 for ; Wed, 22 Feb 2023 13:21:36 +0000 (UTC) Received: from passt.top (passt.top [88.198.0.164]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-325-pgfKhaqjPAyyThhky2PumA-1; Wed, 22 Feb 2023 08:21:33 -0500 Received: by passt.top (Postfix, from userid 1000) id F32475A026C; Wed, 22 Feb 2023 14:21:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677073803; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UP/LYPXS5lU1GB0NcUlCRKiY22F9uMQFknB6V4tTXfo=; b=SrZAE0afqRRmGHTnsRxs1jDK0Bi8Ck7T3LROf6yFO6DxS8sgeDkG9xZEu9Dpg69xBF51XU M+JTz6cuOCUfUl3cYAMEr355F9ozMY5vj9E97NCt7Q+HEO38a5cDzfV+lBS8bz5DZQjfzN WSr5D9nSID30vhQqZ49hcBntR475zDY= X-MC-Unique: -b0EorrQPNWJd_L4igOtMA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: pgfKhaqjPAyyThhky2PumA-1 From: Stefano Brivio To: libvir-list@redhat.com Subject: [PATCH v2 2/3] qemu_passt: Set UID and GID to configured values for qemu driver, if any Date: Wed, 22 Feb 2023 14:21:30 +0100 Message-Id: <20230222132131.3811642-3-sbrivio@redhat.com> In-Reply-To: <20230222132131.3811642-1-sbrivio@redhat.com> References: <20230222132131.3811642-1-sbrivio@redhat.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Michal=20Pr=C3=ADvozn=C3=ADk?= , Laine Stump Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1677073805874100001 Content-Type: text/plain; charset="utf-8"; x-default="true" qemuSecurityCommandRun() would have dealt with this (if UID and GID had been passed). With virCommandRun() we need separate, explicit calls. Fixes: a56f0168d576 ("qemu: hook up passt config to qemu domains") Signed-off-by: Stefano Brivio --- src/qemu/qemu_passt.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c index 81f48dd630..61e7047354 100644 --- a/src/qemu/qemu_passt.c +++ b/src/qemu/qemu_passt.c @@ -157,6 +157,7 @@ qemuPasstStart(virDomainObj *vm, { qemuDomainObjPrivate *priv =3D vm->privateData; virQEMUDriver *driver =3D priv->driver; + g_autoptr(virQEMUDriverConfig) cfg =3D virQEMUDriverGetConfig(driver); g_autofree char *passtSocketName =3D qemuPasstCreateSocketPath(vm, net= ); g_autoptr(virCommand) cmd =3D NULL; g_autofree char *pidfile =3D qemuPasstCreatePidFilename(vm, net); @@ -174,6 +175,11 @@ qemuPasstStart(virDomainObj *vm, virCommandClearCaps(cmd); virCommandSetErrorBuffer(cmd, &errbuf); =20 + if (cfg->user !=3D (uid_t) -1) + virCommandSetUID(cmd, cfg->user); + if (cfg->group !=3D (gid_t) -1) + virCommandSetGID(cmd, cfg->group); + virCommandAddArgList(cmd, "--one-off", "--socket", passtSocketName, --=20 2.39.1