From nobody Sat May 4 12:24:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1676634981; cv=none; d=zohomail.com; s=zohoarc; b=AABvdZpr+JCyYe/pKaOybhIvFQWZAQxb8a+A0dh3PYxWmuMOxNwZBmq5fGrNiKpFIKBGK6oWnf+8XR4IncD/xzME00hZVUaEAxWbsgrWK1uG3BKkhwN7PDl/k4UJ/yeQQlHFnO1LaVQLt47+yuaP1SI9ecYKPBQHjt5HsfwjYh0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676634981; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=6GvTUW/ua3gv8f2UuSPgbYocD9xBVMPY0YLbd7XyGMQ=; b=TqNiBM3zfn6H3iz/BiPjU2ttJgvqmu0MPAMFJoWKh0WOjeg3QojWYbc0pACshCesb+4akaZabDinBaR0HVNT6WBzlYJd2Zpo6DPF/7nA+fPSZ9+0PY2PDVKdsfwFFA+bzLhVU1KTQGAsppPPv5YPKKAhwOFO4eMxCjbu3BSJxrA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1676634981401537.04460822179; Fri, 17 Feb 2023 03:56:21 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-343-n_-2XF0DPWOpypqZArf9CQ-1; Fri, 17 Feb 2023 06:56:14 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 44F6F1C05B16; Fri, 17 Feb 2023 11:56:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2DC7A492C14; Fri, 17 Feb 2023 11:56:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1CB011946589; Fri, 17 Feb 2023 11:56:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3BC491946588 for ; Thu, 16 Feb 2023 02:49:15 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 90AF518EC2; Thu, 16 Feb 2023 02:49:15 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8905318EC1 for ; Thu, 16 Feb 2023 02:49:15 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 69887800B24 for ; Thu, 16 Feb 2023 02:49:15 +0000 (UTC) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-639-kO_9zxsMPmu2R1BEMz20Ng-1; Wed, 15 Feb 2023 21:49:13 -0500 Received: by mail-pf1-f179.google.com with SMTP id g9so576865pfo.5 for ; Wed, 15 Feb 2023 18:49:13 -0800 (PST) Received: from localhost.localdomain (193.74.150.34.bc.googleusercontent.com. [34.150.74.193]) by smtp.gmail.com with ESMTPSA id b14-20020aa7870e000000b005a8e97fc71bsm65846pfo.84.2023.02.15.18.49.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Feb 2023 18:49:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676634980; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=6GvTUW/ua3gv8f2UuSPgbYocD9xBVMPY0YLbd7XyGMQ=; b=H4y7i4TOIChc0NOc8bNljQmcRpIK01d+VSdapZ2HIGYQ1wbr+zCWrIgdUInVrhZ/SX4FOb 4Yv335i5YR+lMjSCqckQpaTCiul/retFJ92xydeZY2U3BvKsx+GOWPBonALbqSB2yQTd8j plxf911IeaeEt+m02BU3ck/6Pk+zqdw= X-MC-Unique: n_-2XF0DPWOpypqZArf9CQ-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: kO_9zxsMPmu2R1BEMz20Ng-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6GvTUW/ua3gv8f2UuSPgbYocD9xBVMPY0YLbd7XyGMQ=; b=TzFSFDet/TjU7nHGIz1B3uJJ2iR7PFbTkQKUBYYaZj7cakgIad8rJjEouFU18UcBDI NARKtUuLsJ64+aS9Iw6nTRTLOdgqFMiodwZyVqyQK82vxHyhDN5M2gn1+N0fk5Jvoucm G4FkDDIlNo1TSRIQhHCQ/IA3JWyx4SvfxFHRLIHpGXhC/n7icbQ+kNS94xwOH2qsBvmF VUo5vYznN+ob+rnJ/osNiRO77YGl0GxaiBP2zoR8XnER7uk87qWMCXuL6VQjEzfUXQsd ljYGYwLFpPC4Z/QJEAg0/wRkcl9NQIjncIWoO2Uz0SAMUyQ4X523/4wYnNf4JVE0pDpc YlXQ== X-Gm-Message-State: AO0yUKVkWGs2kPQgvE+f+leCbBzUGii3FIkGsxDfZifNZzoSzZt4CxlQ Pf4u84r0iAfbtNIyAI+AAW37vCP6L9VUqg== X-Google-Smtp-Source: AK7set/60W6QZZyZ7+uzAonfhLi5etUaKERp8ripjXBwUCF+WxLj+R2l+OUEwTYRUOuOv3nP+lyZkA== X-Received: by 2002:a62:140c:0:b0:5a8:c2bb:f0c4 with SMTP id 12-20020a62140c000000b005a8c2bbf0c4mr3385661pfu.13.1676515752172; Wed, 15 Feb 2023 18:49:12 -0800 (PST) From: Zhenguo Yao To: libvir-list@redhat.com Subject: [PATCH] qemu: fix reconnect of unix socket is wrong Date: Thu, 16 Feb 2023 10:48:37 +0800 Message-Id: <20230216024837.79665-1-yaozhenguo1@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mailman-Approved-At: Fri, 17 Feb 2023 11:56:08 +0000 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhenguo Yao , yaozhenguo@jd.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1676634982377100001 Content-Type: text/plain; charset="utf-8"; x-default="true" 'reconnect' parameter doesn't pass to qemu properly when hotplug vhost-user device to vm. Fix this by making 'reconnect' to get correct value. Signed-off-by: Zhenguo Yao Reviewed-by: Jonathon Jongsma --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index d05ca2932f..ba6276ec8e 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -6450,7 +6450,7 @@ qemuMonitorJSONAttachCharDevGetProps(const char *chrI= D, return NULL; =20 if (chr->data.nix.reconnect.enabled =3D=3D VIR_TRISTATE_BO= OL_YES) - reconnect =3D chr->data.tcp.reconnect.timeout; + reconnect =3D chr->data.nix.reconnect.timeout; else if (chr->data.nix.reconnect.enabled =3D=3D VIR_TRISTA= TE_BOOL_NO) reconnect =3D 0; } --=20 2.32.0