From nobody Mon Feb 9 20:30:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1673358912; cv=none; d=zohomail.com; s=zohoarc; b=n4gEe4VCUsDNu1b8o6rajCPAqqkWZkoYBsmR6GfeaQDDq4HX4eU25oRUysRNr7oyjNsmjt3x8hlSB7pC1ugp0HEdRXt5LxIvrDpxsMuOdabSHOevDc5eBWZpN387nmITGMF5ddQSgKn0wMXnruAwZGE+IQtjdQNy/P+/XtWrVgo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673358912; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QTZg7ohzhf5vIkn2M8t+ZauST1BdYT+bIyHoB9OoBQg=; b=aOsIY7Dl5+cF5nMF8d+MXHs/NBWmxp5mUuTFlImMS01wOCUnH1kRLAOByc7/VhVuHmHCJFq+SemSJpWCK6sQ9j4UkygtCjhM3qYq9aMYu44+8qQUSRgsJ+tXYRXQOKpALGzKFY3cqQ19+0sfc0r/Bap8MJD/JHuX7FvwN8UK9tU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1673358912343268.5695993795889; Tue, 10 Jan 2023 05:55:12 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-275-pNt7zjeKM6GqoZMinczXQA-1; Tue, 10 Jan 2023 08:54:32 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1F603100F90F; Tue, 10 Jan 2023 13:54:26 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id A52D1492B00; Tue, 10 Jan 2023 13:54:24 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 765DE19465B1; Tue, 10 Jan 2023 13:54:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id F3FDC1946587 for ; Tue, 10 Jan 2023 13:54:23 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E418140C2006; Tue, 10 Jan 2023 13:54:23 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9F0440C2004; Tue, 10 Jan 2023 13:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673358911; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=QTZg7ohzhf5vIkn2M8t+ZauST1BdYT+bIyHoB9OoBQg=; b=P6Wo0E4+ntFNL1pOXXhy3nJ7svDJ+jjUghdcxFe0UF8gFtQPHxtE80xdFEMeax34SW4KR6 bPGCzX6lI5XIRb7g+cgmSP+reU08aQf/D7SU5LlBCf+biERLOi/e0nhRp+vpwEvm1AKWbB MsIpxCH31xQhQFGrl/5TDiW8RzHt7rY= X-MC-Unique: pNt7zjeKM6GqoZMinczXQA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/9] remote: remove redundant initialization of args variable Date: Tue, 10 Jan 2023 08:54:15 -0500 Message-Id: <20230110135423.2576907-2-berrange@redhat.com> In-Reply-To: <20230110135423.2576907-1-berrange@redhat.com> References: <20230110135423.2576907-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1673358912697100002 Every member of the args variable will be initialized explicitly. A few methods had a redundant call to memset the args which can be removed. Signed-off-by: Daniel P. Berrang=C3=A9 --- src/remote/remote_driver.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 43a714c79a..deeabdb24f 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -6000,7 +6000,6 @@ remoteDomainMigrateBegin3(virDomainPtr domain, =20 remoteDriverLock(priv); =20 - memset(&args, 0, sizeof(args)); memset(&ret, 0, sizeof(ret)); =20 make_nonnull_domain(&args.dom, domain); @@ -6056,7 +6055,6 @@ remoteDomainMigratePrepare3(virConnectPtr dconn, =20 remoteDriverLock(priv); =20 - memset(&args, 0, sizeof(args)); memset(&ret, 0, sizeof(ret)); =20 args.cookie_in.cookie_in_val =3D (char *)cookiein; @@ -6125,7 +6123,6 @@ remoteDomainMigratePrepareTunnel3(virConnectPtr dconn, =20 remoteDriverLock(priv); =20 - memset(&args, 0, sizeof(args)); memset(&ret, 0, sizeof(ret)); =20 if (!(netst =3D virNetClientStreamNew(priv->remoteProgram, @@ -6200,7 +6197,6 @@ remoteDomainMigratePerform3(virDomainPtr dom, =20 remoteDriverLock(priv); =20 - memset(&args, 0, sizeof(args)); memset(&ret, 0, sizeof(ret)); =20 make_nonnull_domain(&args.dom, dom); @@ -6260,7 +6256,6 @@ remoteDomainMigrateFinish3(virConnectPtr dconn, =20 remoteDriverLock(priv); =20 - memset(&args, 0, sizeof(args)); memset(&ret, 0, sizeof(ret)); =20 args.cookie_in.cookie_in_val =3D (char *)cookiein; @@ -6314,8 +6309,6 @@ remoteDomainMigrateConfirm3(virDomainPtr domain, =20 remoteDriverLock(priv); =20 - memset(&args, 0, sizeof(args)); - make_nonnull_domain(&args.dom, domain); args.cookie_in.cookie_in_len =3D cookieinlen; args.cookie_in.cookie_in_val =3D (char *) cookiein; @@ -6908,7 +6901,6 @@ remoteDomainMigrateBegin3Params(virDomainPtr domain, =20 remoteDriverLock(priv); =20 - memset(&args, 0, sizeof(args)); memset(&ret, 0, sizeof(ret)); =20 make_nonnull_domain(&args.dom, domain); @@ -6971,7 +6963,6 @@ remoteDomainMigratePrepare3Params(virConnectPtr dconn, =20 remoteDriverLock(priv); =20 - memset(&args, 0, sizeof(args)); memset(&ret, 0, sizeof(ret)); =20 if (virTypedParamsSerialize(params, nparams, @@ -7047,7 +7038,6 @@ remoteDomainMigratePrepareTunnel3Params(virConnectPtr= dconn, =20 remoteDriverLock(priv); =20 - memset(&args, 0, sizeof(args)); memset(&ret, 0, sizeof(ret)); =20 args.cookie_in.cookie_in_val =3D (char *)cookiein; @@ -7129,7 +7119,6 @@ remoteDomainMigratePerform3Params(virDomainPtr dom, =20 remoteDriverLock(priv); =20 - memset(&args, 0, sizeof(args)); memset(&ret, 0, sizeof(ret)); =20 make_nonnull_domain(&args.dom, dom); @@ -7195,7 +7184,6 @@ remoteDomainMigrateFinish3Params(virConnectPtr dconn, =20 remoteDriverLock(priv); =20 - memset(&args, 0, sizeof(args)); memset(&ret, 0, sizeof(ret)); =20 args.cookie_in.cookie_in_val =3D (char *)cookiein; @@ -7261,8 +7249,6 @@ remoteDomainMigrateConfirm3Params(virDomainPtr domain, =20 remoteDriverLock(priv); =20 - memset(&args, 0, sizeof(args)); - make_nonnull_domain(&args.dom, domain); args.cookie_in.cookie_in_len =3D cookieinlen; args.cookie_in.cookie_in_val =3D (char *) cookiein; @@ -7563,8 +7549,6 @@ remoteConnectGetAllDomainStats(virConnectPtr conn, virDomainStatsRecordPtr elem =3D NULL; virDomainStatsRecordPtr *tmpret =3D NULL; =20 - memset(&args, 0, sizeof(args)); - if (ndoms) { args.doms.doms_val =3D g_new0(remote_nonnull_domain, ndoms); =20 --=20 2.38.1