From nobody Fri Dec 19 20:08:59 2025
Delivered-To: importer@patchew.org
Received-SPF: pass (zohomail.com: domain of redhat.com designates
 170.10.129.124 as permitted sender) client-ip=170.10.129.124;
 envelope-from=libvir-list-bounces@redhat.com;
 helo=us-smtp-delivery-124.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1673237488; cv=none;
	d=zohomail.com; s=zohoarc;
	b=E52Ql6MjLxXiUZ4vku1ASfMDH0NIppF+mKiKYz6GU6Rqks2Fm4BmBDvzBDilDZI9F5FudifFQB7/RIo0Q2HBN9brhtffe07HjGNCnKyl9kozWxcCdJz/bLSGq74LwboC4n5MVmjAm3MleMlmfNvLjEKTAllr8x7PbiYS45sjIaM=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc;
	t=1673237488;
 h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=kK3cBGX5ws5Y38pt63lw79fm9Ho3n2sWMSiotci/IBg=;
	b=hkE4TAEQ+s2ot4408DGL485i28+8MuJGRxW2+GgDjsnFQ54pFJCfb5xJBGwwWNZ2Ix+ofk+tr2fgW5/YiIsjG/WrHYKBgZq/M8cJtKpW/lP3OVs/q5tvkjeKwdBha9DJMXSdTuh6AK8X/MGO3VUKTLTt98fG4oaieCsQlgL+b94=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass;
	spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from=<laine@redhat.com> (p=none dis=none)
Return-Path: <libvir-list-bounces@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com
	with SMTPS id 1673237488393799.7169319686078;
 Sun, 8 Jan 2023 20:11:28 -0800 (PST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-317-tLO5XSgzMHGmqYDhCLcYHQ-1; Sun, 08 Jan 2023 23:11:23 -0500
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com
 [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8ED29100F90E;
	Mon,  9 Jan 2023 04:11:16 +0000 (UTC)
Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com
 (unknown [10.30.29.100])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 769CA492B08;
	Mon,  9 Jan 2023 04:11:16 +0000 (UTC)
Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com
 (localhost [IPv6:::1])
	by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with
 ESMTP id 2C3FC1947B8F;
	Mon,  9 Jan 2023 04:11:15 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
 [10.11.54.3])
 by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with
 ESMTP id 35ADC1946586 for <libvir-list@listman.corp.redhat.com>;
 Mon,  9 Jan 2023 04:11:14 +0000 (UTC)
Received: by smtp.corp.redhat.com (Postfix)
 id 2B2EF1121318; Mon,  9 Jan 2023 04:11:14 +0000 (UTC)
Received: from vhost3.router.laine.org (unknown [10.2.16.67])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 0839D1121314;
 Mon,  9 Jan 2023 04:11:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1673237487;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=kK3cBGX5ws5Y38pt63lw79fm9Ho3n2sWMSiotci/IBg=;
	b=Grjkd7VSmQszWP/ljbcNeTWj5nRJFzbgR8CT5z7jqv7YtMGWH/l43fx7UG0kwRgqQsAgXK
	eZeFO53LYddBODOYIkJOk+oAGTcacLeIH6tO/5VaIa0D/l2P06sthQfEjpG0OJnFr3rEP4
	2i7zQUYHSlGI2iwxSeMNuvT38FT753s=
X-MC-Unique: tLO5XSgzMHGmqYDhCLcYHQ-1
X-Original-To: libvir-list@listman.corp.redhat.com
From: Laine Stump <laine@redhat.com>
To: libvir-list@redhat.com
Subject: [libvirt PATCH 4/9] conf: add passt XML additions to schema
Date: Sun,  8 Jan 2023 23:11:07 -0500
Message-Id: <20230109041112.368790-5-laine@redhat.com>
In-Reply-To: <20230109041112.368790-1-laine@redhat.com>
References: <20230109041112.368790-1-laine@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Development discussions about the libvirt library & tools
 <libvir-list.redhat.com>
List-Unsubscribe: <https://listman.redhat.com/mailman/options/libvir-list>,
 <mailto:libvir-list-request@redhat.com?subject=unsubscribe>
List-Archive: <http://listman.redhat.com/archives/libvir-list/>
List-Post: <mailto:libvir-list@redhat.com>
List-Help: <mailto:libvir-list-request@redhat.com?subject=help>
List-Subscribe: <https://listman.redhat.com/mailman/listinfo/libvir-list>,
 <mailto:libvir-list-request@redhat.com?subject=subscribe>
Cc: sbrivio@redhat.com, passt-dev@passt.top
Errors-To: libvir-list-bounces@redhat.com
Sender: "libvir-list" <libvir-list-bounces@redhat.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
X-ZM-MESSAGEID: 1673237489336100011
Content-Type: text/plain; charset="utf-8"; x-default="true"

Initial support for network devices using passt (https://passt.top)
for the backend connection will require:

* new attributes of the <backend> subelement:
  * "type" that can have the value "passt" (to differentiate from
    slirp, because both slirp and passt will use <interface
    type=3D'user'>)
  * "logFile" (a path to a file that passt should use for its logging)
  * "upstream" (a netdev name, e.g. "eth0").

* a new subelement <portForward> (described in more detail later)

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: J=C3=A1n Tomko <jtomko@redhat.com>
---
 src/conf/schemas/domaincommon.rng         | 65 +++++++++++++++++++++++
 tests/qemuxml2argvdata/net-user-passt.xml | 57 ++++++++++++++++++++
 2 files changed, 122 insertions(+)
 create mode 100644 tests/qemuxml2argvdata/net-user-passt.xml

diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom=
mon.rng
index 8bc627d114..0e66b84576 100644
--- a/src/conf/schemas/domaincommon.rng
+++ b/src/conf/schemas/domaincommon.rng
@@ -3581,6 +3581,7 @@
         </element>
       </optional>
       <ref name=3D"interface-ip-info"/>
+      <ref name=3D"interface-port-forwards"/>
       <optional>
         <element name=3D"script">
           <attribute name=3D"path">
@@ -3617,6 +3618,13 @@
       </optional>
       <optional>
         <element name=3D"backend">
+          <optional>
+            <attribute name=3D"type">
+              <choice>
+                <value>passt</value>
+              </choice>
+            </attribute>
+          </optional>
           <optional>
             <attribute name=3D"tap">
               <ref name=3D"absFilePath"/>
@@ -3627,6 +3635,16 @@
               <ref name=3D"absFilePath"/>
             </attribute>
           </optional>
+          <optional>
+            <attribute name=3D"logFile">
+              <ref name=3D"absFilePath"/>
+            </attribute>
+          </optional>
+          <optional>
+            <attribute name=3D"upstream">
+              <ref name=3D"deviceName"/>
+            </attribute>
+          </optional>
         </element>
       </optional>
       <optional>
@@ -3843,6 +3861,53 @@
     </interleave>
   </define>
=20
+  <define name=3D"interface-port-forwards">
+    <zeroOrMore>
+      <element name=3D"portForward">
+        <attribute name=3D"proto">
+          <choice>
+            <value>tcp</value>
+            <value>udp</value>
+          </choice>
+        </attribute>
+        <optional>
+          <attribute name=3D"address">
+            <ref name=3D"ipAddr"/>
+          </attribute>
+        </optional>
+        <optional>
+          <attribute name=3D"dev">
+            <ref name=3D"deviceName"/>
+          </attribute>
+        </optional>
+        <interleave>
+          <zeroOrMore>
+            <element name=3D"range">
+              <attribute name=3D"start">
+                <ref name=3D"PortNumber"/>
+              </attribute>
+              <optional>
+                <attribute name=3D"end">
+                  <ref name=3D"PortNumber"/>
+                </attribute>
+              </optional>
+              <optional>
+                <attribute name=3D"to">
+                  <ref name=3D"PortNumber"/>
+                </attribute>
+              </optional>
+              <optional>
+                <attribute name=3D"exclude">
+                  <ref name=3D"virYesNo"/>
+                </attribute>
+              </optional>
+            </element>
+          </zeroOrMore>
+        </interleave>
+      </element>
+    </zeroOrMore>
+  </define>
+
   <define name=3D"teaming">
     <element name=3D"teaming">
       <choice>
diff --git a/tests/qemuxml2argvdata/net-user-passt.xml b/tests/qemuxml2argv=
data/net-user-passt.xml
new file mode 100644
index 0000000000..b82eebd089
--- /dev/null
+++ b/tests/qemuxml2argvdata/net-user-passt.xml
@@ -0,0 +1,57 @@
+<domain type=3D'qemu'>
+  <name>QEMUGuest1</name>
+  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+  <memory unit=3D'KiB'>219136</memory>
+  <currentMemory unit=3D'KiB'>219136</currentMemory>
+  <vcpu placement=3D'static'>1</vcpu>
+  <os>
+    <type arch=3D'x86_64' machine=3D'pc'>hvm</type>
+    <boot dev=3D'hd'/>
+  </os>
+  <clock offset=3D'utc'/>
+  <on_poweroff>destroy</on_poweroff>
+  <on_reboot>restart</on_reboot>
+  <on_crash>destroy</on_crash>
+  <devices>
+    <emulator>/usr/bin/qemu-system-x86_64</emulator>
+    <disk type=3D'block' device=3D'disk'>
+      <driver name=3D'qemu' type=3D'raw'/>
+      <source dev=3D'/dev/HostVG/QEMUGuest1'/>
+      <target dev=3D'hda' bus=3D'ide'/>
+      <address type=3D'drive' controller=3D'0' bus=3D'0' target=3D'0' unit=
=3D'0'/>
+    </disk>
+    <controller type=3D'usb' index=3D'0' model=3D'none'/>
+    <controller type=3D'ide' index=3D'0'>
+      <address type=3D'pci' domain=3D'0x0000' bus=3D'0x00' slot=3D'0x01' f=
unction=3D'0x1'/>
+    </controller>
+    <controller type=3D'pci' index=3D'0' model=3D'pci-root'/>
+    <interface type=3D'user'>
+      <mac address=3D'00:11:22:33:44:55'/>
+      <ip address=3D'172.17.2.0' family=3D'ipv4' prefix=3D'24'/>
+      <ip address=3D'2001:db8:ac10:fd01::feed' family=3D'ipv6'/>
+      <portForward proto=3D'tcp' address=3D'2001:db8:ac10:fd01::1:10'>
+        <range start=3D'22' to=3D'2022'/>
+        <range start=3D'1000' end=3D'1050'/>
+        <range start=3D'1020' exclude=3D'yes'/>
+        <range start=3D'1030' end=3D'1040' exclude=3D'yes'/>
+      </portForward>
+      <portForward proto=3D'udp' address=3D'1.2.3.4' dev=3D'eth0'>
+        <range start=3D'5000' end=3D'5020' to=3D'6000'/>
+        <range start=3D'5010' end=3D'5015' exclude=3D'yes'/>
+      </portForward>
+      <portForward proto=3D'tcp'>
+        <range start=3D'80'/>
+      </portForward>
+      <portForward proto=3D'tcp'>
+        <range start=3D'443' to=3D'344'/>
+      </portForward>
+      <model type=3D'rtl8139'/>
+      <backend type=3D'passt' logFile=3D'/var/log/loglaw.blog' upstream=3D=
'eth42'/>
+      <address type=3D'pci' domain=3D'0x0000' bus=3D'0x00' slot=3D'0x02' f=
unction=3D'0x0'/>
+    </interface>
+    <input type=3D'mouse' bus=3D'ps2'/>
+    <input type=3D'keyboard' bus=3D'ps2'/>
+    <audio id=3D'1' type=3D'none'/>
+    <memballoon model=3D'none'/>
+  </devices>
+</domain>
--=20
2.38.1