From nobody Fri Dec 19 21:47:57 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1673237531; cv=none; d=zohomail.com; s=zohoarc; b=j7vks5IKAaUfrj6SV3b8m76WY14dQIZLNW1gr9qMr6ZX5Q2If7byO0gkG9k2p8XMXh5u4uYTJFmFzwhYNHje05NAETded9ffY8XZ1SXzvk0E47dSOZWAg8UFlq7R9qqqzqqA/Usfr/3UYQLRlVohx05HjFB23lfJJUN+HGC9r/M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673237531; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BFnM2MI4RL1C+DJyCV13iK64EFdxwJGadqen5gHoMWg=; b=BJttVl1XSGcArEYHbJ0nj174nsoyMUCFd7Fme01eF09+yM8aUDevr4eIb+ztsD3LYDHRuGcp+5UrJh1rT2wSMWP40uTSjKyYeuZE73lGYB5Wgq9hizqxMmZMOM/Q7zctYjJbks02YAkJqzgCj6TY1f5hf3m27ttJPm0nt4aZfXw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1673237531194887.2794583122421; Sun, 8 Jan 2023 20:12:11 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-177-kcki80ktPraqmy51WTLt2A-1; Sun, 08 Jan 2023 23:11:24 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EFE82856502; Mon, 9 Jan 2023 04:11:18 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id DCCB7C16026; Mon, 9 Jan 2023 04:11:18 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CCFE6194973E; Mon, 9 Jan 2023 04:11:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 48F741947B95 for ; Mon, 9 Jan 2023 04:11:15 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3E1411121319; Mon, 9 Jan 2023 04:11:15 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.2.16.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1BB3A1121314; Mon, 9 Jan 2023 04:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673237530; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BFnM2MI4RL1C+DJyCV13iK64EFdxwJGadqen5gHoMWg=; b=ibOf+Lme7OI6kYVNFKNsOOxHLNaShpH9QgU6PM7hx51Sb6ZpMjVz+g3+ybdLRIDlzZs2lb +55JBnVc/G6zXhfEx3XBZ04GlSNiloDT+319x1ZqNc/nT2LxmPj1Y9f0yK/EUJSchHyFW7 B0xHnQTzbLYjGE6jDxYaRfih7I4H308= X-MC-Unique: kcki80ktPraqmy51WTLt2A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Laine Stump To: libvir-list@redhat.com Subject: [libvirt PATCH 9/9] specfile: require passt for the build if fedora >= 36 or rhel >= 9 Date: Sun, 8 Jan 2023 23:11:12 -0500 Message-Id: <20230109041112.368790-10-laine@redhat.com> In-Reply-To: <20230109041112.368790-1-laine@redhat.com> References: <20230109041112.368790-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sbrivio@redhat.com, passt-dev@passt.top Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1673237531504100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The only reason we need it at build time is to find its location in $PATH so it can be hardcoded into the libvirt binary (and avoid the possibility of someone adding in a malicious binary somewhere earlier in the path, I guess). Only 'recommend' passt during installation though, since it is not needed unless someone is actually using it. There is no need to add in a build-time "WITH_PASST" option (IMO), since it adds very little to the size of the code - "PASST" (the path to the binary) will just be set to "passt", so if someone does manage to build and install passt on an older version of Fedora or RHEL, it will still work (as long as it's installed somewhere in the path). Signed-off-by: Laine Stump Reviewed-by: J=C3=A1n Tomko --- libvirt.spec.in | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 6b8acf252e..d9529fc76c 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -347,6 +347,9 @@ BuildRequires: libssh2-devel >=3D 1.3.0 %if %{with_netcf} BuildRequires: netcf-devel >=3D 0.2.2 %endif +%if (0%{?fedora} >=3D 36) || (0%{?rhel} >=3D 9) +BuildRequires: passt +%endif %if %{with_esx} BuildRequires: libcurl-devel %endif @@ -717,6 +720,9 @@ Requires: lzop Requires: xz Requires: systemd-container Requires: swtpm-tools + %if (0%{?fedora} >=3D 36) || (0%{?rhel} >=3D 9) +Recommends: passt + %endif =20 %description daemon-driver-qemu The qemu driver plugin for the libvirtd daemon, providing @@ -1968,6 +1974,7 @@ exit 0 %config(noreplace) %{_sysconfdir}/logrotate.d/libvirtd.qemu %ghost %dir %{_rundir}/libvirt/qemu/ %ghost %dir %{_rundir}/libvirt/qemu/dbus/ +%ghost %dir %{_rundir}/libvirt/qemu/passt/ %ghost %dir %{_rundir}/libvirt/qemu/slirp/ %ghost %dir %{_rundir}/libvirt/qemu/swtpm/ %dir %attr(0751, %{qemu_user}, %{qemu_group}) %{_localstatedir}/lib/libvir= t/qemu/ --=20 2.38.1