From nobody Sun Feb 8 17:21:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1670510147; cv=none; d=zohomail.com; s=zohoarc; b=RZY9teE08A8qBElBc7u32MMlQKv4dwIkmzELNmA4/KWXx1vUrAXfIokNVrFbEUxBLlwHuEjGzEQDHeQbWybdYWopPjMkbg8cM3jXnaykcpGbSxfg1tKSC4Ctm7YJXF6sjit25bV8uAA6Io755jZQvEtHHcZIjKElV6WgNTk0IiM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670510147; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tPyoTYOUmwMdvv3IyAUXWaIRLerxyzfop542HmPRNCQ=; b=K3BIN/FK2IYvGYHOaCiNzlmQStT2flSgUSiz1l7JdNtAu8hAFekpwNAdOGEhqVNjDfZBhlYOYXUtvdew0gJe+A8yGhkPtFXq7EXfi/zy3LbUU0eL/Kwc+tsSlR1qGFLRzPkyoFYRFhN41QLtyQ258VyIKGy4wNOiVwe1Usih2YM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1670510147728143.57358762840806; Thu, 8 Dec 2022 06:35:47 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-260-4J8nel8EOKq6df2sD2Mm6Q-1; Thu, 08 Dec 2022 09:35:41 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 187E4804184; Thu, 8 Dec 2022 14:35:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0522E40C6EC3; Thu, 8 Dec 2022 14:35:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id DE1841946A44; Thu, 8 Dec 2022 14:35:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A19021946A44 for ; Thu, 8 Dec 2022 14:35:34 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 8A2222024CC1; Thu, 8 Dec 2022 14:35:34 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id E247B200AD47; Thu, 8 Dec 2022 14:35:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670510146; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=tPyoTYOUmwMdvv3IyAUXWaIRLerxyzfop542HmPRNCQ=; b=af3aZnz4wV/ysB+D8ynAn+VlxjK/b7u+1gLZIvuwe+BskJsK1gsue9HmeaeN1wLnI1PFzo N0vD6LObRsK3XrHT/DNwpaZ8eRyuLVYuTDOtDdozYdvii1t1hT6f/WiaCPJPC8MxkHO/4f K4dc1Grt0cXjRstZgNKuXaFXbDNMVJI= X-MC-Unique: 4J8nel8EOKq6df2sD2Mm6Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 04/21] meson: drop check for unshare() Date: Thu, 8 Dec 2022 14:35:08 +0000 Message-Id: <20221208143525.1731853-5-berrange@redhat.com> In-Reply-To: <20221208143525.1731853-1-berrange@redhat.com> References: <20221208143525.1731853-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1670510148595100001 The unshare() syscall was introduced to Linux in commit 2da436e00f9a5fdd0fb6b31e4b2b2ba82e8f5ab8 Author: JANAK DESAI Date: Tue Feb 7 12:59:03 2006 -0800 [PATCH] unshare system call -v5: system call registration for i386 This is old enough that all our supported platforms can be assumed to have this feature. Furthermore, the virprocess.c file was already using unshare() with nothing more than a #ifdef __linux__ check. Signed-off-by: Daniel P. Berrang=C3=A9 --- meson.build | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/meson.build b/meson.build index 212c3cfafb..0a09e510c7 100644 --- a/meson.build +++ b/meson.build @@ -1526,20 +1526,7 @@ elif get_option('driver_libxl').enabled() endif =20 if not get_option('driver_lxc').disabled() and host_machine.system() =3D= =3D 'linux' and conf.has('WITH_LIBVIRTD') - lxc_support_code =3D ''' -#include -#include -#include - -void main(void) { - unshare(1); -} - ''' - if cc.compiles(lxc_support_code, name: 'lxc support', args: '-D_GNU_SOUR= CE') - conf.set('WITH_LXC', 1) - elif get_option('driver_lxc').enabled() - error('Required kernel features for LXC were not found') - endif + conf.set('WITH_LXC', 1) elif get_option('driver_lxc').enabled() error('linux and remote_driver are required for LXC') endif --=20 2.38.1