From nobody Sun Feb 8 17:21:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1670510234; cv=none; d=zohomail.com; s=zohoarc; b=IxnNAkt+KjbEOKQF769gFwJVt5Kmu+uOF7M4sm9qrZVqs1N3q93JSD2f/qZab0iv1V4pUken3ugpofvyH4ENidR92kikUuHlFzVr1G4yBmXm4GHIIgxk+4OQe/P4SprHQ00UEdzCeXtKqjEWi6cVDWcoe1sC9GyN24h6F9lTZfU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670510234; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Uom/8wB1skRLtDDOHePrzSM4qw3qMAMTyyIf8G7wklI=; b=VIDHtwMROdqaeCkP3b5FUHJryEB7PEkq55ByFKmcoQlFJIPZXL5JigvxYQ2mccIcqQrzrdWXxHJe1rGtQhyQ+WiODoyz1fv3DkBr4VbF4JM7+/1q7lduR90mf6CMCw9ATnYFRZ3gaQn5zpgMcnDYwlHDefo7GQ7J+7E8GjB5ArQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1670510234557635.9316985071299; Thu, 8 Dec 2022 06:37:14 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-167-4rDhFl-mPmKQ1PAd4O40Mg-1; Thu, 08 Dec 2022 09:36:31 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D18B21C09B7A; Thu, 8 Dec 2022 14:35:59 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id B6CCB40C2064; Thu, 8 Dec 2022 14:35:59 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5DABC1947051; Thu, 8 Dec 2022 14:35:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 464E219459FC for ; Thu, 8 Dec 2022 14:35:51 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 4AF9E20290A6; Thu, 8 Dec 2022 14:35:45 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id B449620290A2; Thu, 8 Dec 2022 14:35:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670510233; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Uom/8wB1skRLtDDOHePrzSM4qw3qMAMTyyIf8G7wklI=; b=E9gidJiKbK+6y6ZhqLtDUSPRs2wa3md2uB1eEYd5kGMd7owBzS9WBHHuf7yOCYdzVe8KHo q67530BvrtN1DWPhT4F1oFEDj2a9MtenJwrVvUWV72P6A2a0CSoF33laSpsdC0KbTrSIWX txpmp63VdS73hBnwNoQgyHqnHhJ3aJE= X-MC-Unique: 4rDhFl-mPmKQ1PAd4O40Mg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 16/21] meson: simplify check for virnetdevbridge.c headers Date: Thu, 8 Dec 2022 14:35:20 +0000 Message-Id: <20221208143525.1731853-17-berrange@redhat.com> In-Reply-To: <20221208143525.1731853-1-berrange@redhat.com> References: <20221208143525.1731853-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1670510236665100001 The headers required by virnetdevbridge.c have all exited since before Linux moved to git. It is sufficient to check for just one of them in order to give an error message about needing kernel headers installed. Signed-off-by: Daniel P. Berrang=C3=A9 --- meson.build | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/meson.build b/meson.build index f28af30936..79f9d47520 100644 --- a/meson.build +++ b/meson.build @@ -628,19 +628,11 @@ foreach name : headers endif endforeach =20 -# check for kernel headers required by src/util/virnetdevbridge.c +# check for kernel header required by src/util/virnetdevbridge.c if host_machine.system() =3D=3D 'linux' - required_headers =3D [ - 'linux/param.h', - 'linux/sockios.h', - 'linux/if_bridge.h', - 'linux/if_tun.h', - ] - foreach name : required_headers - if not cc.has_header(name) - error('You must install kernel-headers in order to compile libvirt w= ith QEMU or LXC support') - endif - endforeach + if not cc.has_header('linux/sockios.h') + error('You must install kernel-headers in order to compile libvirt wit= h QEMU or LXC support') + endif endif =20 =20 --=20 2.38.1