From nobody Mon Feb 9 02:11:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1670510227; cv=none; d=zohomail.com; s=zohoarc; b=huEPZeCnpIQhq4N6UEGhdUyMPW9yulkETg40PjmVae/rAJc97eiK0TC0DFrRHhegWeORXAI1qZ1lqJd4Bu50ohaCh7XUrAjNgKIxr189Z3qBzuuuH/VA6gmKCEDnVasdZ6gJNhtGnzCQm82lVQsFtYxzrCC9rMcHVCGWVTcGffo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670510227; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jvMjDw+vV+cu7MzEHYUgKgz410RO7g9eBjmxUy5YAf4=; b=jXB3O4IRr2ZEC7tGU4sjF3doxBv67/9BZLnnsiLZEAQMdJn3oC6YpuFiokgeO7005ExbdkUVP/Rab7miLelWgq5w1i8ukKo0gSNv3P8d15HouF6mbpjx5rt2dcs6F4uJtclNtWTbQn1a68xOSFmvFYJqSq3Uc1tWSSIkvbMEVi4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 167051022639326.89144083753922; Thu, 8 Dec 2022 06:37:06 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-Fur-1LUaOS-g_ETSadfJTQ-1; Thu, 08 Dec 2022 09:36:27 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 427D4857D1C; Thu, 8 Dec 2022 14:35:57 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E22E1401C39; Thu, 8 Dec 2022 14:35:57 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6886F1947BBE; Thu, 8 Dec 2022 14:35:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2775219459FC for ; Thu, 8 Dec 2022 14:35:51 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9CA9D2024CC8; Thu, 8 Dec 2022 14:35:43 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 121012024CC0; Thu, 8 Dec 2022 14:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670510223; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jvMjDw+vV+cu7MzEHYUgKgz410RO7g9eBjmxUy5YAf4=; b=SeKEz7ljK/ti6UUD7C5TibLX/I68vqbXRZJz4PkNSCukZbIxuCHl8jF+6oeP86Ad9aGFLo gfyQc6zzA1sST2FV08kSQc8aal5tCt7U2EzDhYBrxa/5/Lupj38LPjJMZd0qnABA6AEGax uOSMW/d9YG2secDdh6LcPv3UcryEbew= X-MC-Unique: Fur-1LUaOS-g_ETSadfJTQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 14/21] meson: remove obsolete check for ETHTOOL_GCOALESCE Date: Thu, 8 Dec 2022 14:35:18 +0000 Message-Id: <20221208143525.1731853-15-berrange@redhat.com> In-Reply-To: <20221208143525.1731853-1-berrange@redhat.com> References: <20221208143525.1731853-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1670510228639100003 The ETHTOOL_GCOALESCE constant has existed since before Linux moved to git. This is old enough that all our supported platforms can be assumed to have this feature. Signed-off-by: Daniel P. Berrang=C3=A9 --- meson.build | 3 --- src/util/virnetdev.c | 15 --------------- 2 files changed, 18 deletions(-) diff --git a/meson.build b/meson.build index a3a512a565..7fb17bf983 100644 --- a/meson.build +++ b/meson.build @@ -650,9 +650,6 @@ symbols =3D [ # Check whether endian provides handy macros. [ 'endian.h', 'htole64' ], =20 - [ 'linux/ethtool.h', 'ETHTOOL_SCOALESCE' ], - [ 'linux/ethtool.h', 'ETHTOOL_GCOALESCE' ], - # GET_VLAN_VID_CMD is required for virNetDevGetVLanID [ 'linux/if_vlan.h', 'GET_VLAN_VID_CMD' ], =20 diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index c2bccf4e49..a73d624453 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -3306,7 +3306,6 @@ virNetDevGetEthtoolGFeatures(const char *ifname, } =20 =20 -# if WITH_DECL_ETHTOOL_SCOALESCE && WITH_DECL_ETHTOOL_GCOALESCE /** * virNetDevSetCoalesce: * @ifname: interface name to modify @@ -3402,20 +3401,6 @@ int virNetDevSetCoalesce(const char *ifname, =20 return 0; } -# else -int virNetDevSetCoalesce(const char *ifname, - virNetDevCoalesce *coalesce, - bool update) -{ - if (!coalesce && !update) - return 0; - - virReportSystemError(ENOSYS, - _("Cannot set coalesce info on interface '%s'"), - ifname); - return -1; -} -# endif =20 =20 /** --=20 2.38.1