From nobody Sun Feb 8 23:03:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1670510195; cv=none; d=zohomail.com; s=zohoarc; b=DYCofeKTvU61UP1U8ZcitrByI9oyxQU1qyHETK9T/Koc+IUy1jAxYEn4hSYll/vS9NxrWkH23UX31A5OuQXipA5Le2ANmiTuZTXr0eQLmfkkoVY8Y2T0GyznDFYmIHrA6p64Le01LJp7voBTgWWHJQ5S5GkX+LnpMc41twCVNso= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670510195; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Xzg43BG2hkIiIJ9DpcDMywFvEcmhfcbIMsX9cn09QXU=; b=Q71Q6cmhQAxoupusBIcRrTWDhB/rhffCOQgDHPQD9lZSqGfwA53nkv2Ad5K4/nKllzj0vJPcGTBoQNyB5ob+MW9a/Lg1CEU5wnRq6/o4p2f3J5YdyDO0c4r5kf6Pl5LiZpdvCGfit26M4OE7By5QFeEGijwf8lOgjv9A+I6Skg0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1670510195745861.6303356109944; Thu, 8 Dec 2022 06:36:35 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-218-Iy5p9dt3MiS1Wj_5UyRDvg-1; Thu, 08 Dec 2022 09:36:27 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 057CA1006E32; Thu, 8 Dec 2022 14:35:58 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E1C981121339; Thu, 8 Dec 2022 14:35:57 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CBEC9194707A; Thu, 8 Dec 2022 14:35:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E4E6E1947051 for ; Thu, 8 Dec 2022 14:35:50 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EDA9E2024CC5; Thu, 8 Dec 2022 14:35:41 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 62C932024CC0; Thu, 8 Dec 2022 14:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670510194; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Xzg43BG2hkIiIJ9DpcDMywFvEcmhfcbIMsX9cn09QXU=; b=BbmB2/+Nzuw/kk1DTcwNZiqucVrWHH67bhu7AKsnv1pEhXS5JcO4cHDLBQYok/B6rSGcto J38Tb4MYNyxNxsGYnq2k0Wf3iQlXuEz9E8aCG7Y8a+yCsFeEtSfct7us7puLCklZNQkABh kCG0enHYyyywFfGnqSK7dO63QNriA/c= X-MC-Unique: Iy5p9dt3MiS1Wj_5UyRDvg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 12/21] meson: remove obsolete check for ETH_FLAG_RXHASH Date: Thu, 8 Dec 2022 14:35:16 +0000 Message-Id: <20221208143525.1731853-13-berrange@redhat.com> In-Reply-To: <20221208143525.1731853-1-berrange@redhat.com> References: <20221208143525.1731853-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1670510206460100001 The ETH_FLAG_RXHASH constant was introduced to Linux in commit b00fabb4020d17bda4bea59507e09fadf573088d Author: stephen hemminger Date: Mon Mar 29 14:47:27 2010 +0000 netdev: ethtool RXHASH flag This is old enough that all our supported platforms can be assumed to have this feature. Signed-off-by: Daniel P. Berrang=C3=A9 --- meson.build | 1 - src/util/virnetdev.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/meson.build b/meson.build index d9af1ac36a..ff6908d3c4 100644 --- a/meson.build +++ b/meson.build @@ -650,7 +650,6 @@ symbols =3D [ # Check whether endian provides handy macros. [ 'endian.h', 'htole64' ], =20 - [ 'linux/ethtool.h', 'ETH_FLAG_RXHASH' ], [ 'linux/ethtool.h', 'ETHTOOL_GFEATURES' ], [ 'linux/ethtool.h', 'ETHTOOL_SCOALESCE' ], [ 'linux/ethtool.h', 'ETHTOOL_GCOALESCE' ], diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 5ef4687191..52b8d53ed8 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -3093,9 +3093,7 @@ virNetDevGetEthtoolFeatures(const char *ifname, {ETH_FLAG_RXVLAN, VIR_NET_DEV_FEAT_RXVLAN}, {ETH_FLAG_TXVLAN, VIR_NET_DEV_FEAT_TXVLAN}, {ETH_FLAG_NTUPLE, VIR_NET_DEV_FEAT_NTUPLE}, -# if WITH_DECL_ETH_FLAG_RXHASH {ETH_FLAG_RXHASH, VIR_NET_DEV_FEAT_RXHASH}, -# endif }; =20 for (i =3D 0; i < G_N_ELEMENTS(ethtool_cmds); i++) { --=20 2.38.1