From nobody Sun Feb 8 14:12:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1669890025; cv=none; d=zohomail.com; s=zohoarc; b=PZ5C77nZyhHmBEuM7guFYW2XiXrZwGVLpeM9Wol2yp0EOaHtnIrZNQjn46n4w5KF10zhrie0ECfxfSs9fm0Dt7uwFcCIoaNQGV305ZMoRjrkuGDADVF2YkRZi7Tcr4AVXstnj3c5G9eT+savnaNS4wLL2lvSIeEVNk2kRLXDJrs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669890025; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BxWdceZVkvMSao5c21nPBOAg8xKBEqGtd/xWk9Y1Z8k=; b=fecv18LTHqk+kc4H6hU4jFdUKVPuqiWDRX5+DKXuiIjTpa5vng3rxDPYFGhrca/QUl744rESRN7FUNmU5//tpZnj7HOoNOfcDGzDf/ZBwMzrVUqYg/+WwsPXZ1MmdsEM2TLtmms4Jh/sFdZZnqmiIP33liLfdpHDdD2/IDIjSLI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1669890025410851.874196588302; Thu, 1 Dec 2022 02:20:25 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-388-aRC0tze4N7SFWtIxDwbljQ-1; Thu, 01 Dec 2022 05:20:17 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8309B886063; Thu, 1 Dec 2022 10:20:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6ED841121314; Thu, 1 Dec 2022 10:20:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2286419465B2; Thu, 1 Dec 2022 10:20:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 31CB719465A8 for ; Thu, 1 Dec 2022 10:20:01 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 415622166B2C; Thu, 1 Dec 2022 10:20:01 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id E6F572166BA5; Thu, 1 Dec 2022 10:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669890024; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BxWdceZVkvMSao5c21nPBOAg8xKBEqGtd/xWk9Y1Z8k=; b=bNHYA8moF2i32UB722As37Bhy42WE8t3E8knYeeBWHxWhEW19cVycy/7PvudGa6kl3cD1b XUs3BnAIicm7JAl61drPE7hecNKTKbrjTaBxVpD+MVYCB8KTg4Rd8CzNYP6Us4pNjD5tD/ JWaSZS9RCl7LgcL67FqiJm/LcihB5hs= X-MC-Unique: aRC0tze4N7SFWtIxDwbljQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/3] block: mention 'password-secret' option for -iscsi Date: Thu, 1 Dec 2022 05:19:57 -0500 Message-Id: <20221201101959.419545-2-berrange@redhat.com> In-Reply-To: <20221201101959.419545-1-berrange@redhat.com> References: <20221201101959.419545-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, libvir-list@redhat.com, Peter Lieven , Hanna Reitz , Gerd Hoffmann , Ronnie Sahlberg , Paolo Bonzini Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1669890025738100001 The 'password-secret' option was added commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrang=C3=A9 Date: Thu Jan 21 14:19:21 2016 +0000 iscsi: add support for getting CHAP password via QCryptoSecret API but was not mentioned in the command line docs Signed-off-by: Daniel P. Berrang=C3=A9 --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 7f99d15b23..055df73306 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1889,7 +1889,7 @@ SRST ERST =20 DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi, - "-iscsi [user=3Duser][,password=3Dpassword]\n" + "-iscsi [user=3Duser][,password=3Dpassword],password-secret=3Dsecret-i= d]\n" " [,header-digest=3DCRC32C|CR32C-NONE|NONE-CRC32C|NONE\n" " [,initiator-name=3Dinitiator-iqn][,id=3Dtarget-iqn]\n" " [,timeout=3Dtimeout]\n" --=20 2.38.1