[PATCH 0/8] network: firewalld: native support for NAT/routed

Eric Garver posted 8 patches 3 weeks, 3 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20221110163152.2868177-1-eric@garver.life
libvirt.spec.in                    |   2 +
src/libvirt_private.syms           |   2 +
src/network/bridge_driver_linux.c  | 193 ++++++++++++++++++++---------
src/network/libvirt-nat-out.policy |  13 ++
src/network/libvirt-nat.zone       |  10 ++
src/network/libvirt-to-host.policy |   1 +
src/network/meson.build            |  10 ++
src/util/virfirewalld.c            |  79 +++++++++++-
src/util/virfirewalld.h            |   6 +
9 files changed, 258 insertions(+), 58 deletions(-)
create mode 100644 src/network/libvirt-nat-out.policy
create mode 100644 src/network/libvirt-nat.zone
[PATCH 0/8] network: firewalld: native support for NAT/routed
Posted by Eric Garver 3 weeks, 3 days ago
This series further improves the firewalld backend by converting to a
fully native implementation for NAT and routed networks. That is, there
are no iptables rules added by libvirt when the running firewalld is
0.9.0 or later.

The major advantage is that firewalld users can use firewall-cmd to
filter the VM traffic and apply their own policies.

When firewalld < 0.9.0 is present only the "libvirt" zone will be used.
The new "libvirt-nat" and "libvirt-routed" zones are not used. This
maintains compatibility for older distributions (e.g. Ubuntu 20.04).

Patch 1 is a bug fix for my previous series to avoid a bogus error log.

Patches 2-3 converts the routed network to native firewalld.

Patches 4-8 converts the NAT network to native firewalld. It also
introduces the "libvirt-nat" zone.

Eric Garver (8):
  util: virFirewallDGetPolicies: gracefully handle older firewalld
  network: firewalld: add networkAddHybridFirewallDRules()
  network: firewalld: use native routed networks
  util: add virFirewallDSourceSetZone()
  util: add virFirewallDApplyPolicyRichRules()
  network: firewalld: add zone for NAT networks
  network: firewalld: add policies for NAT networks
  network: firewalld: use native NAT networks

 libvirt.spec.in                    |   2 +
 src/libvirt_private.syms           |   2 +
 src/network/bridge_driver_linux.c  | 193 ++++++++++++++++++++---------
 src/network/libvirt-nat-out.policy |  13 ++
 src/network/libvirt-nat.zone       |  10 ++
 src/network/libvirt-to-host.policy |   1 +
 src/network/meson.build            |  10 ++
 src/util/virfirewalld.c            |  79 +++++++++++-
 src/util/virfirewalld.h            |   6 +
 9 files changed, 258 insertions(+), 58 deletions(-)
 create mode 100644 src/network/libvirt-nat-out.policy
 create mode 100644 src/network/libvirt-nat.zone

-- 
2.37.3
Re: [PATCH 0/8] network: firewalld: native support for NAT/routed
Posted by Daniel P. Berrangé 2 weeks, 5 days ago
On Thu, Nov 10, 2022 at 11:31:44AM -0500, Eric Garver wrote:
> This series further improves the firewalld backend by converting to a
> fully native implementation for NAT and routed networks. That is, there
> are no iptables rules added by libvirt when the running firewalld is
> 0.9.0 or later.
> 
> The major advantage is that firewalld users can use firewall-cmd to
> filter the VM traffic and apply their own policies.
> 
> When firewalld < 0.9.0 is present only the "libvirt" zone will be used.
> The new "libvirt-nat" and "libvirt-routed" zones are not used. This
> maintains compatibility for older distributions (e.g. Ubuntu 20.04).

Testing this I'm noticing problematic behaviour even with the
existing iptables impl.

Specifically, if you have 2 different virtual networks, VMs on
the distinct virtual networks are not supposed to be able to
talk to each other. And yet, even with the existing iptables
impl this is not blocked, and I'm wondering if this is a
consequence of the 'iptables' impl being switched to nft. 

With this pure firewalld impl, I'm not sure how we can stop this
cross-network traffic, given that all the virtual network sget
put in the same zone.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH 0/8] network: firewalld: native support for NAT/routed
Posted by Laine Stump 2 weeks, 5 days ago
On 11/15/22 12:55 PM, Daniel P. Berrangé wrote:
> On Thu, Nov 10, 2022 at 11:31:44AM -0500, Eric Garver wrote:
>> This series further improves the firewalld backend by converting to a
>> fully native implementation for NAT and routed networks. That is, there
>> are no iptables rules added by libvirt when the running firewalld is
>> 0.9.0 or later.
>>
>> The major advantage is that firewalld users can use firewall-cmd to
>> filter the VM traffic and apply their own policies.
>>
>> When firewalld < 0.9.0 is present only the "libvirt" zone will be used.
>> The new "libvirt-nat" and "libvirt-routed" zones are not used. This
>> maintains compatibility for older distributions (e.g. Ubuntu 20.04).
> 
> Testing this I'm noticing problematic behaviour even with the
> existing iptables impl.
> 
> Specifically, if you have 2 different virtual networks, VMs on
> the distinct virtual networks are not supposed to be able to
> talk to each other. And yet, even with the existing iptables
> impl this is not blocked, and I'm wondering if this is a
> consequence of the 'iptables' impl being switched to nft.

Between two routed networks it should allow traffic, but not between two 
NATed networks, or from routed to NAT. Unless I crossed a wire in my 
testing setup, I had tested this before pushing Eric's last patches 
(which fixed incoming traffic to routed networks).

I'll check it again.

> 
> With this pure firewalld impl, I'm not sure how we can stop this
> cross-network traffic, given that all the virtual network sget
> put in the same zone.

Interesting point. Yeah, can't have that.

Re: [PATCH 0/8] network: firewalld: native support for NAT/routed
Posted by Eric Garver 2 weeks, 4 days ago
On Tue, Nov 15, 2022 at 01:33:28PM -0500, Laine Stump wrote:
> On 11/15/22 12:55 PM, Daniel P. Berrangé wrote:
> > On Thu, Nov 10, 2022 at 11:31:44AM -0500, Eric Garver wrote:
> > > This series further improves the firewalld backend by converting to a
> > > fully native implementation for NAT and routed networks. That is, there
> > > are no iptables rules added by libvirt when the running firewalld is
> > > 0.9.0 or later.
> > > 
> > > The major advantage is that firewalld users can use firewall-cmd to
> > > filter the VM traffic and apply their own policies.
> > > 
> > > When firewalld < 0.9.0 is present only the "libvirt" zone will be used.
> > > The new "libvirt-nat" and "libvirt-routed" zones are not used. This
> > > maintains compatibility for older distributions (e.g. Ubuntu 20.04).
> > 
> > Testing this I'm noticing problematic behaviour even with the
> > existing iptables impl.
> > 
> > Specifically, if you have 2 different virtual networks, VMs on
> > the distinct virtual networks are not supposed to be able to
> > talk to each other. And yet, even with the existing iptables
> > impl this is not blocked, and I'm wondering if this is a
> > consequence of the 'iptables' impl being switched to nft.
> 
> Between two routed networks it should allow traffic, but not between two
> NATed networks, or from routed to NAT. Unless I crossed a wire in my testing
> setup, I had tested this before pushing Eric's last patches (which fixed
> incoming traffic to routed networks).
> 
> I'll check it again.

If it's not currently being blocked then it can be, e.g. adding a policy
to reject "libvirt-nat" --> "libvirt-routed".

> > With this pure firewalld impl, I'm not sure how we can stop this
> > cross-network traffic, given that all the virtual network sget
> > put in the same zone.
> 
> Interesting point. Yeah, can't have that.
Re: [PATCH 0/8] network: firewalld: native support for NAT/routed
Posted by Michal Prívozník 2 weeks, 5 days ago
On 11/10/22 17:31, Eric Garver wrote:
> This series further improves the firewalld backend by converting to a
> fully native implementation for NAT and routed networks. That is, there
> are no iptables rules added by libvirt when the running firewalld is
> 0.9.0 or later.
> 
> The major advantage is that firewalld users can use firewall-cmd to
> filter the VM traffic and apply their own policies.
> 
> When firewalld < 0.9.0 is present only the "libvirt" zone will be used.
> The new "libvirt-nat" and "libvirt-routed" zones are not used. This
> maintains compatibility for older distributions (e.g. Ubuntu 20.04).
> 
> Patch 1 is a bug fix for my previous series to avoid a bogus error log.
> 
> Patches 2-3 converts the routed network to native firewalld.
> 
> Patches 4-8 converts the NAT network to native firewalld. It also
> introduces the "libvirt-nat" zone.
> 
> Eric Garver (8):
>   util: virFirewallDGetPolicies: gracefully handle older firewalld
>   network: firewalld: add networkAddHybridFirewallDRules()
>   network: firewalld: use native routed networks
>   util: add virFirewallDSourceSetZone()
>   util: add virFirewallDApplyPolicyRichRules()
>   network: firewalld: add zone for NAT networks
>   network: firewalld: add policies for NAT networks
>   network: firewalld: use native NAT networks
> 
>  libvirt.spec.in                    |   2 +
>  src/libvirt_private.syms           |   2 +
>  src/network/bridge_driver_linux.c  | 193 ++++++++++++++++++++---------
>  src/network/libvirt-nat-out.policy |  13 ++
>  src/network/libvirt-nat.zone       |  10 ++
>  src/network/libvirt-to-host.policy |   1 +
>  src/network/meson.build            |  10 ++
>  src/util/virfirewalld.c            |  79 +++++++++++-
>  src/util/virfirewalld.h            |   6 +
>  9 files changed, 258 insertions(+), 58 deletions(-)
>  create mode 100644 src/network/libvirt-nat-out.policy
>  create mode 100644 src/network/libvirt-nat.zone
> 

Patches look good to me. You have my:

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

but I'll wait a bit for Laine, if he wants to express his opinion.

Michal
Re: [PATCH 0/8] network: firewalld: native support for NAT/routed
Posted by Laine Stump 2 weeks, 5 days ago
On 11/15/22 5:21 AM, Michal Prívozník wrote:
> On 11/10/22 17:31, Eric Garver wrote:
>> This series further improves the firewalld backend by converting to a
>> fully native implementation for NAT and routed networks. That is, there
>> are no iptables rules added by libvirt when the running firewalld is
>> 0.9.0 or later.
>>
>> The major advantage is that firewalld users can use firewall-cmd to
>> filter the VM traffic and apply their own policies.
>>
>> When firewalld < 0.9.0 is present only the "libvirt" zone will be used.
>> The new "libvirt-nat" and "libvirt-routed" zones are not used. This
>> maintains compatibility for older distributions (e.g. Ubuntu 20.04).
>>
>> Patch 1 is a bug fix for my previous series to avoid a bogus error log.
>>
>> Patches 2-3 converts the routed network to native firewalld.
>>
>> Patches 4-8 converts the NAT network to native firewalld. It also
>> introduces the "libvirt-nat" zone.
>>
>> Eric Garver (8):
>>    util: virFirewallDGetPolicies: gracefully handle older firewalld
>>    network: firewalld: add networkAddHybridFirewallDRules()
>>    network: firewalld: use native routed networks
>>    util: add virFirewallDSourceSetZone()
>>    util: add virFirewallDApplyPolicyRichRules()
>>    network: firewalld: add zone for NAT networks
>>    network: firewalld: add policies for NAT networks
>>    network: firewalld: use native NAT networks
>>
>>   libvirt.spec.in                    |   2 +
>>   src/libvirt_private.syms           |   2 +
>>   src/network/bridge_driver_linux.c  | 193 ++++++++++++++++++++---------
>>   src/network/libvirt-nat-out.policy |  13 ++
>>   src/network/libvirt-nat.zone       |  10 ++
>>   src/network/libvirt-to-host.policy |   1 +
>>   src/network/meson.build            |  10 ++
>>   src/util/virfirewalld.c            |  79 +++++++++++-
>>   src/util/virfirewalld.h            |   6 +
>>   9 files changed, 258 insertions(+), 58 deletions(-)
>>   create mode 100644 src/network/libvirt-nat-out.policy
>>   create mode 100644 src/network/libvirt-nat.zone
>>
> 
> Patches look good to me. You have my:
> 
> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
> 
> but I'll wait a bit for Laine, if he wants to express his opinion.

This series has been on my list of things I need to get to since it 
arrived, but I've been purposefully not responding in order to avoid 
distracting my brain from something else I'm working on that is more 
urgent (supporting passt as a guest interface connection mode).

I have pending stuff (in-process on and off for many months now) that 
adds a separate (configurable) backend for raw nftables that this 
firewalld-backend mode needs to mesh with. In particular, I don't think 
it's safe to automatically switch to using a pure firewalld backend any 
time firewalld is running, because behavior isn't exactly the same as 
the standard iptables backend (the first example that comes to mind is 
those horrible dhcp checksum munging rules that are added by libvirt's 
iptables backend).

Probably most of the patches in this series will be untouched by mine, 
or should be prerequisites to mine, but some will need to be re-jiggered 
to use my conf-file option and to deal with my other reorganizations. 
I'll look at it in more detail as soon as I have a first version of 
passt patches posted, which I'm hoping will happen sometime this week.

So please don't push these patches (yet).

Re: [PATCH 0/8] network: firewalld: native support for NAT/routed
Posted by Eric Garver 2 weeks, 4 days ago
On Tue, Nov 15, 2022 at 11:03:21AM -0500, Laine Stump wrote:
> On 11/15/22 5:21 AM, Michal Prívozník wrote:
> > On 11/10/22 17:31, Eric Garver wrote:
> > > This series further improves the firewalld backend by converting to a
> > > fully native implementation for NAT and routed networks. That is, there
> > > are no iptables rules added by libvirt when the running firewalld is
> > > 0.9.0 or later.
> > > 
> > > The major advantage is that firewalld users can use firewall-cmd to
> > > filter the VM traffic and apply their own policies.
> > > 
> > > When firewalld < 0.9.0 is present only the "libvirt" zone will be used.
> > > The new "libvirt-nat" and "libvirt-routed" zones are not used. This
> > > maintains compatibility for older distributions (e.g. Ubuntu 20.04).
> > > 
> > > Patch 1 is a bug fix for my previous series to avoid a bogus error log.
> > > 
> > > Patches 2-3 converts the routed network to native firewalld.
> > > 
> > > Patches 4-8 converts the NAT network to native firewalld. It also
> > > introduces the "libvirt-nat" zone.
> > > 
> > > Eric Garver (8):
> > >    util: virFirewallDGetPolicies: gracefully handle older firewalld
> > >    network: firewalld: add networkAddHybridFirewallDRules()
> > >    network: firewalld: use native routed networks
> > >    util: add virFirewallDSourceSetZone()
> > >    util: add virFirewallDApplyPolicyRichRules()
> > >    network: firewalld: add zone for NAT networks
> > >    network: firewalld: add policies for NAT networks
> > >    network: firewalld: use native NAT networks
> > > 
> > >   libvirt.spec.in                    |   2 +
> > >   src/libvirt_private.syms           |   2 +
> > >   src/network/bridge_driver_linux.c  | 193 ++++++++++++++++++++---------
> > >   src/network/libvirt-nat-out.policy |  13 ++
> > >   src/network/libvirt-nat.zone       |  10 ++
> > >   src/network/libvirt-to-host.policy |   1 +
> > >   src/network/meson.build            |  10 ++
> > >   src/util/virfirewalld.c            |  79 +++++++++++-
> > >   src/util/virfirewalld.h            |   6 +
> > >   9 files changed, 258 insertions(+), 58 deletions(-)
> > >   create mode 100644 src/network/libvirt-nat-out.policy
> > >   create mode 100644 src/network/libvirt-nat.zone
> > > 
> > 
> > Patches look good to me. You have my:
> > 
> > Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
> > 
> > but I'll wait a bit for Laine, if he wants to express his opinion.
> 
> This series has been on my list of things I need to get to since it arrived,
> but I've been purposefully not responding in order to avoid distracting my
> brain from something else I'm working on that is more urgent (supporting
> passt as a guest interface connection mode).
> 
> I have pending stuff (in-process on and off for many months now) that adds a
> separate (configurable) backend for raw nftables that this firewalld-backend
> mode needs to mesh with. In particular, I don't think it's safe to
> automatically switch to using a pure firewalld backend any time firewalld is
> running, because behavior isn't exactly the same as the standard iptables
> backend (the first example that comes to mind is those horrible dhcp
> checksum munging rules that are added by libvirt's iptables backend).
> 
> Probably most of the patches in this series will be untouched by mine, or
> should be prerequisites to mine, but some will need to be re-jiggered to use
> my conf-file option and to deal with my other reorganizations. I'll look at
> it in more detail as soon as I have a first version of passt patches posted,
> which I'm hoping will happen sometime this week.
> 
> So please don't push these patches (yet).

Please take the first patch now. I can resend individually if you'd
like.

The rest we can sort out and re-spin after your series.

Thanks.
E.
Re: [PATCH 0/8] network: firewalld: native support for NAT/routed
Posted by Michal Prívozník 2 weeks, 4 days ago
On 11/15/22 23:16, Eric Garver wrote:
> On Tue, Nov 15, 2022 at 11:03:21AM -0500, Laine Stump wrote:
>> On 11/15/22 5:21 AM, Michal Prívozník wrote:
>>> On 11/10/22 17:31, Eric Garver wrote:
>>>> This series further improves the firewalld backend by converting to a
>>>> fully native implementation for NAT and routed networks. That is, there
>>>> are no iptables rules added by libvirt when the running firewalld is
>>>> 0.9.0 or later.
>>>>
>>>> The major advantage is that firewalld users can use firewall-cmd to
>>>> filter the VM traffic and apply their own policies.
>>>>
>>>> When firewalld < 0.9.0 is present only the "libvirt" zone will be used.
>>>> The new "libvirt-nat" and "libvirt-routed" zones are not used. This
>>>> maintains compatibility for older distributions (e.g. Ubuntu 20.04).
>>>>
>>>> Patch 1 is a bug fix for my previous series to avoid a bogus error log.
>>>>
>>>> Patches 2-3 converts the routed network to native firewalld.
>>>>
>>>> Patches 4-8 converts the NAT network to native firewalld. It also
>>>> introduces the "libvirt-nat" zone.
>>>>
>>>> Eric Garver (8):
>>>>    util: virFirewallDGetPolicies: gracefully handle older firewalld
>>>>    network: firewalld: add networkAddHybridFirewallDRules()
>>>>    network: firewalld: use native routed networks
>>>>    util: add virFirewallDSourceSetZone()
>>>>    util: add virFirewallDApplyPolicyRichRules()
>>>>    network: firewalld: add zone for NAT networks
>>>>    network: firewalld: add policies for NAT networks
>>>>    network: firewalld: use native NAT networks
>>>>
>>>>   libvirt.spec.in                    |   2 +
>>>>   src/libvirt_private.syms           |   2 +
>>>>   src/network/bridge_driver_linux.c  | 193 ++++++++++++++++++++---------
>>>>   src/network/libvirt-nat-out.policy |  13 ++
>>>>   src/network/libvirt-nat.zone       |  10 ++
>>>>   src/network/libvirt-to-host.policy |   1 +
>>>>   src/network/meson.build            |  10 ++
>>>>   src/util/virfirewalld.c            |  79 +++++++++++-
>>>>   src/util/virfirewalld.h            |   6 +
>>>>   9 files changed, 258 insertions(+), 58 deletions(-)
>>>>   create mode 100644 src/network/libvirt-nat-out.policy
>>>>   create mode 100644 src/network/libvirt-nat.zone
>>>>
>>>
>>> Patches look good to me. You have my:
>>>
>>> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
>>>
>>> but I'll wait a bit for Laine, if he wants to express his opinion.
>>
>> This series has been on my list of things I need to get to since it arrived,
>> but I've been purposefully not responding in order to avoid distracting my
>> brain from something else I'm working on that is more urgent (supporting
>> passt as a guest interface connection mode).
>>
>> I have pending stuff (in-process on and off for many months now) that adds a
>> separate (configurable) backend for raw nftables that this firewalld-backend
>> mode needs to mesh with. In particular, I don't think it's safe to
>> automatically switch to using a pure firewalld backend any time firewalld is
>> running, because behavior isn't exactly the same as the standard iptables
>> backend (the first example that comes to mind is those horrible dhcp
>> checksum munging rules that are added by libvirt's iptables backend).
>>
>> Probably most of the patches in this series will be untouched by mine, or
>> should be prerequisites to mine, but some will need to be re-jiggered to use
>> my conf-file option and to deal with my other reorganizations. I'll look at
>> it in more detail as soon as I have a first version of passt patches posted,
>> which I'm hoping will happen sometime this week.
>>
>> So please don't push these patches (yet).
> 
> Please take the first patch now. I can resend individually if you'd
> like.
> 
> The rest we can sort out and re-spin after your series.

Yeah, the first patch is independent of the rest so unless there's any
objection from Laine or Dan I'll push it later today.

Michal

Re: [PATCH 0/8] network: firewalld: native support for NAT/routed
Posted by Daniel P. Berrangé 2 weeks, 4 days ago
On Wed, Nov 16, 2022 at 09:40:41AM +0100, Michal Prívozník wrote:
> On 11/15/22 23:16, Eric Garver wrote:
> > On Tue, Nov 15, 2022 at 11:03:21AM -0500, Laine Stump wrote:
> >> On 11/15/22 5:21 AM, Michal Prívozník wrote:
> >>> On 11/10/22 17:31, Eric Garver wrote:
> >>>> This series further improves the firewalld backend by converting to a
> >>>> fully native implementation for NAT and routed networks. That is, there
> >>>> are no iptables rules added by libvirt when the running firewalld is
> >>>> 0.9.0 or later.
> >>>>
> >>>> The major advantage is that firewalld users can use firewall-cmd to
> >>>> filter the VM traffic and apply their own policies.
> >>>>
> >>>> When firewalld < 0.9.0 is present only the "libvirt" zone will be used.
> >>>> The new "libvirt-nat" and "libvirt-routed" zones are not used. This
> >>>> maintains compatibility for older distributions (e.g. Ubuntu 20.04).
> >>>>
> >>>> Patch 1 is a bug fix for my previous series to avoid a bogus error log.
> >>>>
> >>>> Patches 2-3 converts the routed network to native firewalld.
> >>>>
> >>>> Patches 4-8 converts the NAT network to native firewalld. It also
> >>>> introduces the "libvirt-nat" zone.
> >>>>
> >>>> Eric Garver (8):
> >>>>    util: virFirewallDGetPolicies: gracefully handle older firewalld
> >>>>    network: firewalld: add networkAddHybridFirewallDRules()
> >>>>    network: firewalld: use native routed networks
> >>>>    util: add virFirewallDSourceSetZone()
> >>>>    util: add virFirewallDApplyPolicyRichRules()
> >>>>    network: firewalld: add zone for NAT networks
> >>>>    network: firewalld: add policies for NAT networks
> >>>>    network: firewalld: use native NAT networks
> >>>>
> >>>>   libvirt.spec.in                    |   2 +
> >>>>   src/libvirt_private.syms           |   2 +
> >>>>   src/network/bridge_driver_linux.c  | 193 ++++++++++++++++++++---------
> >>>>   src/network/libvirt-nat-out.policy |  13 ++
> >>>>   src/network/libvirt-nat.zone       |  10 ++
> >>>>   src/network/libvirt-to-host.policy |   1 +
> >>>>   src/network/meson.build            |  10 ++
> >>>>   src/util/virfirewalld.c            |  79 +++++++++++-
> >>>>   src/util/virfirewalld.h            |   6 +
> >>>>   9 files changed, 258 insertions(+), 58 deletions(-)
> >>>>   create mode 100644 src/network/libvirt-nat-out.policy
> >>>>   create mode 100644 src/network/libvirt-nat.zone
> >>>>
> >>>
> >>> Patches look good to me. You have my:
> >>>
> >>> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
> >>>
> >>> but I'll wait a bit for Laine, if he wants to express his opinion.
> >>
> >> This series has been on my list of things I need to get to since it arrived,
> >> but I've been purposefully not responding in order to avoid distracting my
> >> brain from something else I'm working on that is more urgent (supporting
> >> passt as a guest interface connection mode).
> >>
> >> I have pending stuff (in-process on and off for many months now) that adds a
> >> separate (configurable) backend for raw nftables that this firewalld-backend
> >> mode needs to mesh with. In particular, I don't think it's safe to
> >> automatically switch to using a pure firewalld backend any time firewalld is
> >> running, because behavior isn't exactly the same as the standard iptables
> >> backend (the first example that comes to mind is those horrible dhcp
> >> checksum munging rules that are added by libvirt's iptables backend).
> >>
> >> Probably most of the patches in this series will be untouched by mine, or
> >> should be prerequisites to mine, but some will need to be re-jiggered to use
> >> my conf-file option and to deal with my other reorganizations. I'll look at
> >> it in more detail as soon as I have a first version of passt patches posted,
> >> which I'm hoping will happen sometime this week.
> >>
> >> So please don't push these patches (yet).
> > 
> > Please take the first patch now. I can resend individually if you'd
> > like.
> > 
> > The rest we can sort out and re-spin after your series.
> 
> Yeah, the first patch is independent of the rest so unless there's any
> objection from Laine or Dan I'll push it later today.

Yes, it looks fine.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH 0/8] network: firewalld: native support for NAT/routed
Posted by Laine Stump 2 weeks, 4 days ago
On 11/16/22 4:11 AM, Daniel P. Berrangé wrote:
> On Wed, Nov 16, 2022 at 09:40:41AM +0100, Michal Prívozník wrote:
>> On 11/15/22 23:16, Eric Garver wrote:
>>> On Tue, Nov 15, 2022 at 11:03:21AM -0500, Laine Stump wrote:
>>>> On 11/15/22 5:21 AM, Michal Prívozník wrote:
>>>>> On 11/10/22 17:31, Eric Garver wrote:
>>>>>> This series further improves the firewalld backend by converting to a
>>>>>> fully native implementation for NAT and routed networks. That is, there
>>>>>> are no iptables rules added by libvirt when the running firewalld is
>>>>>> 0.9.0 or later.
>>>>>>
>>>>>> The major advantage is that firewalld users can use firewall-cmd to
>>>>>> filter the VM traffic and apply their own policies.
>>>>>>
>>>>>> When firewalld < 0.9.0 is present only the "libvirt" zone will be used.
>>>>>> The new "libvirt-nat" and "libvirt-routed" zones are not used. This
>>>>>> maintains compatibility for older distributions (e.g. Ubuntu 20.04).
>>>>>>
>>>>>> Patch 1 is a bug fix for my previous series to avoid a bogus error log.
>>>>>>
>>>>>> Patches 2-3 converts the routed network to native firewalld.
>>>>>>
>>>>>> Patches 4-8 converts the NAT network to native firewalld. It also
>>>>>> introduces the "libvirt-nat" zone.
>>>>>>
>>>>>> Eric Garver (8):
>>>>>>     util: virFirewallDGetPolicies: gracefully handle older firewalld
>>>>>>     network: firewalld: add networkAddHybridFirewallDRules()
>>>>>>     network: firewalld: use native routed networks
>>>>>>     util: add virFirewallDSourceSetZone()
>>>>>>     util: add virFirewallDApplyPolicyRichRules()
>>>>>>     network: firewalld: add zone for NAT networks
>>>>>>     network: firewalld: add policies for NAT networks
>>>>>>     network: firewalld: use native NAT networks
>>>>>>
>>>>>>    libvirt.spec.in                    |   2 +
>>>>>>    src/libvirt_private.syms           |   2 +
>>>>>>    src/network/bridge_driver_linux.c  | 193 ++++++++++++++++++++---------
>>>>>>    src/network/libvirt-nat-out.policy |  13 ++
>>>>>>    src/network/libvirt-nat.zone       |  10 ++
>>>>>>    src/network/libvirt-to-host.policy |   1 +
>>>>>>    src/network/meson.build            |  10 ++
>>>>>>    src/util/virfirewalld.c            |  79 +++++++++++-
>>>>>>    src/util/virfirewalld.h            |   6 +
>>>>>>    9 files changed, 258 insertions(+), 58 deletions(-)
>>>>>>    create mode 100644 src/network/libvirt-nat-out.policy
>>>>>>    create mode 100644 src/network/libvirt-nat.zone
>>>>>>
>>>>>
>>>>> Patches look good to me. You have my:
>>>>>
>>>>> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
>>>>>
>>>>> but I'll wait a bit for Laine, if he wants to express his opinion.
>>>>
>>>> This series has been on my list of things I need to get to since it arrived,
>>>> but I've been purposefully not responding in order to avoid distracting my
>>>> brain from something else I'm working on that is more urgent (supporting
>>>> passt as a guest interface connection mode).
>>>>
>>>> I have pending stuff (in-process on and off for many months now) that adds a
>>>> separate (configurable) backend for raw nftables that this firewalld-backend
>>>> mode needs to mesh with. In particular, I don't think it's safe to
>>>> automatically switch to using a pure firewalld backend any time firewalld is
>>>> running, because behavior isn't exactly the same as the standard iptables
>>>> backend (the first example that comes to mind is those horrible dhcp
>>>> checksum munging rules that are added by libvirt's iptables backend).
>>>>
>>>> Probably most of the patches in this series will be untouched by mine, or
>>>> should be prerequisites to mine, but some will need to be re-jiggered to use
>>>> my conf-file option and to deal with my other reorganizations. I'll look at
>>>> it in more detail as soon as I have a first version of passt patches posted,
>>>> which I'm hoping will happen sometime this week.
>>>>
>>>> So please don't push these patches (yet).
>>>
>>> Please take the first patch now. I can resend individually if you'd
>>> like.
>>>
>>> The rest we can sort out and re-spin after your series.
>>
>> Yeah, the first patch is independent of the rest so unless there's any
>> objection from Laine or Dan I'll push it later today.
> 
> Yes, it looks fine.

Yep, okay with me too.