From nobody Fri May 3 04:04:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1666653010; cv=none; d=zohomail.com; s=zohoarc; b=lUydOklTNxZMWIXCQeuR7YJ5izbu6z+ZX/ZDMfo0lKRQrWB8OerC09p16YPNN3QdwHXcAjMYeFAoZ1Ce6Vkb4FttplE2cabyidpdqm7Si3pcjTjivLeLf8PdJL12mrpXe+HJaZp/YtFzKd6H4gDUKiOotgHKsqgoJ2+p0Jeho7I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666653010; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=CkJ/bNVcBPBtZsW0afSvRI2yrt80eM6lvKWRB/sT450=; b=MXx+t9cpS5sG0Fud+ed8N82cCawyzeY8HGGhEVyXAEAwZ9FUVsSe2ZC1cmCe4Kghdu4Bq1Rc2KNqho204C+s91dJDeNvJN2e4TkeY8NnNyJbMG8ufgkzGxZhy4uduAY33ZNacsZLH6DSMcwO07H+8UymiFuiVVAQ++fY3oOu3Y0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 16666530107811015.6771351556376; Mon, 24 Oct 2022 16:10:10 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-564-pdzPX3U2O12bHVLM6Mg-AA-1; Mon, 24 Oct 2022 19:10:03 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 832C91C05141; Mon, 24 Oct 2022 23:10:01 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC458492B0F; Mon, 24 Oct 2022 23:09:58 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 922F519465A4; Mon, 24 Oct 2022 23:09:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5B3A91946597 for ; Mon, 24 Oct 2022 23:09:57 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3F27F200B400; Mon, 24 Oct 2022 23:09:57 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 381382027064 for ; Mon, 24 Oct 2022 23:09:57 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 183AC185A78F for ; Mon, 24 Oct 2022 23:09:57 +0000 (UTC) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-424-uCZ5rYsxNfKMy3sEZp5hsw-1; Mon, 24 Oct 2022 19:09:55 -0400 Received: by mail-oi1-f181.google.com with SMTP id n83so12386000oif.11 for ; Mon, 24 Oct 2022 16:09:54 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:3b83:9897::5c3d]) by smtp.googlemail.com with ESMTPSA id a88-20020a9d2661000000b00661a05f2a97sm322254otb.61.2022.10.24.16.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 16:09:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666653008; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=CkJ/bNVcBPBtZsW0afSvRI2yrt80eM6lvKWRB/sT450=; b=ASNGAg9HQlpSFYYVoW2QsfnG/n1dIxX3CW4XXvVZ+LdrQdSwlL7GpNIAzYqsuiuh8prRbM sZSi7IzxNjp9FA2X8/6EBJIo2DIoHqNZylQbRq+YBhwTQCcHYJpIUUINfq6Db7Kd6mfpYb DUcOCyfX+yTOiDYBcJH4Lo05C82EpVw= X-MC-Unique: pdzPX3U2O12bHVLM6Mg-AA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: uCZ5rYsxNfKMy3sEZp5hsw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CkJ/bNVcBPBtZsW0afSvRI2yrt80eM6lvKWRB/sT450=; b=XSiiT/pM50UJRqnEIMuElz5JVnEB3I7FEfbZf/pBOwPaxDjm7Eg2BxoNIz6EEF13Wr R+OjAL6oDHJ3Kj8UPgap7vrT5+o3ageoLWCu8i9YFbP0rUS1X8XXwrPq+28liuvMqY4m BMMPWErCGIoQDahDck6O6hyqK10WpHmtKBMQpTKVtP+YlJqnFBo02O1BVZ7S/RvwL6wl klbQQXLkbKuJ8OCno5qUgDhBZQYnMr560fQHh8IyxrYOk0OPWVyi/cwOc4F6SFpdkRy0 X7MLpf63YJJvX6ZgiPAmtuZDqexTKyKHwhZgHYlX6366pAH1w+8vqXK+bDIt0rKZxT0j 64UQ== X-Gm-Message-State: ACrzQf2UG8aO7i4Rjak6CPZnRuLNAAEMoqrVytQDdQsso+bvgOig3bhj 4krfBCFpMiEHlkU1KEJ2gbW4tEAzwbU= X-Google-Smtp-Source: AMsMyM544nciixTZCDrzBDgoG0PM0BT5RSKFH5uVctmpQtEZcDaUsc8iHnnvJg0h9rRuBYee7TGbBg== X-Received: by 2002:a05:6808:1295:b0:355:367e:d2ac with SMTP id a21-20020a056808129500b00355367ed2acmr20794366oiw.223.1666652993974; Mon, 24 Oct 2022 16:09:53 -0700 (PDT) From: jcfaracco@gmail.com To: libvir-list@redhat.com Subject: [PATCH] node_device: fix missing return from function nodedevRegister Date: Mon, 24 Oct 2022 20:07:27 -0300 Message-Id: <20221024230727.91405-1-jcfaracco@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julio Faracco Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1666653011378100001 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Julio Faracco The function nodedevRegister() (or all register functions) requires an integer as a return. That function is not returning a value when UDEV is not set. This commit just adds a generic return for that specific case. Signed-off-by: Julio Faracco --- src/node_device/node_device_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_de= vice_driver.c index 8e93b0dd6f..4d51851cfd 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -1584,6 +1584,8 @@ nodedevRegister(void) { #ifdef WITH_UDEV return udevNodeRegister(); +#else + return 0; #endif } =20 --=20 2.37.3