From nobody Mon Feb 9 19:52:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=huawei.com ARC-Seal: i=1; a=rsa-sha256; t=1664377963; cv=none; d=zohomail.com; s=zohoarc; b=hJYUNMCkI6w2MFjvcUE8P8Ql5EPXFzP7E4Udfe2ktqQiODPL7mYKEhQfT9aR8BHR/LOdG7NYCZyRDIw2kDdIRWzwqeW9ZATbQXpvuExe6T248NtSpaiTcUNZP0onV/xr6BmqQ/e6VOSxEkMpLz799nxwn01LQ8OgOhBh9iVj1t4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664377963; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=n/b3vwuBn8bRAGx5xz2EK4X3GPAaqB4RV3hCxwfjn00=; b=g3jvtzjaJ6V5UaHtlmJhM9+EG6vpMPJpyF9hvwifBpkyEsfeBhS5IQAE/7Nn64/ZdwG8+GuNLg90ik7GXgoIQrxcmrp1PnB0PpmTujDxt6XRnHgA6XY3ykGc6vwsk/C8vxJ3uBu191muZ0J5pKVKEYPcWbcs9LGJIzNFMNee/I8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1664377963222406.48352181226153; Wed, 28 Sep 2022 08:12:43 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-675--l2dRarxO1mn73NeKtdxkQ-1; Wed, 28 Sep 2022 11:12:39 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E526A185A7AE; Wed, 28 Sep 2022 15:12:35 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id B88391121315; Wed, 28 Sep 2022 15:12:34 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9D5D919465B5; Wed, 28 Sep 2022 15:12:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8268919465B1 for ; Wed, 28 Sep 2022 14:14:09 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7139E200D8C2; Wed, 28 Sep 2022 14:14:09 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A6CF2027063 for ; Wed, 28 Sep 2022 14:14:09 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 736C9830F2F for ; Wed, 28 Sep 2022 14:05:51 +0000 (UTC) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-418-I1Q6eT5cMY6RzGbBIC-ruA-1; Wed, 28 Sep 2022 10:05:49 -0400 Received: from dggpeml500022.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Mcyr71hbQzHqPd for ; Wed, 28 Sep 2022 22:03:03 +0800 (CST) Received: from localhost.localdomain (10.175.124.27) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 28 Sep 2022 22:05:20 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664377962; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=n/b3vwuBn8bRAGx5xz2EK4X3GPAaqB4RV3hCxwfjn00=; b=TqhHYPvErwuG+n/l7HOM0x5wW+IlSWWfNUqc7Eh+HY31fuH/pbGZAbKa+7hSrd3iTchQr+ Lsx7Ui69aAC3WvtXR1lwDmlpD7Gqk6211R1/g1UqEhBcsx3D7e0q/tMZI27R0EJijZHl2E KBlzFV9j8BrXpBuh05+eVThJbUf/6m0= X-MC-Unique: -l2dRarxO1mn73NeKtdxkQ-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: I1Q6eT5cMY6RzGbBIC-ruA-1 From: Jiang Jiacheng To: Subject: [PATCH 3/3] qemu: back up the path in qemuMonitorOpen Date: Wed, 28 Sep 2022 21:53:30 +0800 Message-ID: <20220928135330.2868549-4-jiangjiacheng@huawei.com> In-Reply-To: <20220928135330.2868549-1-jiangjiacheng@huawei.com> References: <20220928135330.2868549-1-jiangjiacheng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500022.china.huawei.com (7.185.36.66) X-CFilter-Loop: Reflected X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yubihong@huawei.com, zhengchuan@huawei.com, linyilu@huawei.com, jiangjiacheng@huawei.com, xiexiangyou@huawei.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664377964309100001 Content-Type: text/plain; charset="utf-8" In the case of concurrent VM operations, it is possible to have a null poin= ter reference in qemuMonitorOpen. In the case of concurrent VM shutdown, the priv->monconf will be changed in qemuProcessStop. qemuMonitorOpen releases = the lock before calling qemuMonitorOpenUnix and then references priv->monconf. = The path variable in monconf will cause a null pointer, so it's better to back = up the path content in monconf before releasing the lock. Signed-off-by: Jiang Jiacheng --- src/qemu/qemu_monitor.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index c2808c75a3..792b895570 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -679,6 +679,7 @@ qemuMonitorOpen(virDomainObj *vm, { VIR_AUTOCLOSE fd =3D -1; qemuMonitor *ret =3D NULL; + g_aurofree char *path =3D NULL; =20 if (config->type !=3D VIR_DOMAIN_CHR_TYPE_UNIX) { virReportError(VIR_ERR_INTERNAL_ERROR, @@ -687,8 +688,10 @@ qemuMonitorOpen(virDomainObj *vm, return NULL; } =20 + path =3D g_strdup(config->data.nix.path); + virObjectUnlock(vm); - fd =3D qemuMonitorOpenUnix(config->data.nix.path); + fd =3D qemuMonitorOpenUnix(path); virObjectLock(vm); =20 if (fd < 0) --=20 2.33.0