From nobody Tue Feb 10 12:40:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=huawei.com ARC-Seal: i=1; a=rsa-sha256; t=1664377967; cv=none; d=zohomail.com; s=zohoarc; b=USJWg/rjHhOVLlQ7oqX4DHMHlZP0+gpAsDro6hkPRGj7Eneqnyr0Tu0VHVaAHsN8TqZCZOQdEgo0RsGMH/q2PAL5wreklG8KsktDiqCMo870oK4DL8+b9nuwgHBpvXl7c9YVKnkk88u6w3g81jLH6Ci0YLo0melIJfoBRVgC+HI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664377967; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=asQAOajubbMqIqfG9ZRjF1/v17/Q5Gtn0ApU9ktsIxo=; b=bzLiHwX+iXDw3Qo9be8Bc/gggJDfPPk5UJwIPSfH871G3+YEGcBvVh29YTiWD9wZQIetmVAf2J8len5Y4aAGCuRNcwRgWP+2YoRfvdl2HbE3+x0jde048MATm8DQyP4sMZuch9yOD4urS993cQ+ESGaYQuW/L6+C/D7bDN3DLaI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1664377967671286.8530608563068; Wed, 28 Sep 2022 08:12:47 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-261-YXEMi6y_P9uPe0yRSBErtA-1; Wed, 28 Sep 2022 11:12:40 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 12CB2805B98; Wed, 28 Sep 2022 15:12:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 001F82166B2C; Wed, 28 Sep 2022 15:12:35 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 547321946A4E; Wed, 28 Sep 2022 15:12:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 46F7419465B1 for ; Wed, 28 Sep 2022 14:15:32 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 1B75D40EFB02; Wed, 28 Sep 2022 14:15:32 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast07.extmail.prod.ext.rdu2.redhat.com [10.11.55.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1399240C206B for ; Wed, 28 Sep 2022 14:15:31 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92EB03C0D198 for ; Wed, 28 Sep 2022 14:05:50 +0000 (UTC) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-442-NU5P-H8FPxO-r8uSsjBH2g-1; Wed, 28 Sep 2022 10:05:48 -0400 Received: from dggpeml500022.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Mcynp6ggFzlXPw for ; Wed, 28 Sep 2022 22:01:02 +0800 (CST) Received: from localhost.localdomain (10.175.124.27) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 28 Sep 2022 22:05:19 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664377966; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=asQAOajubbMqIqfG9ZRjF1/v17/Q5Gtn0ApU9ktsIxo=; b=ZXEYKTGN10brRQFd0kRyVbKz529lWGeF0XRChoNTAfVZHZ1MuLtkSdtUe9vdyJpkZpZekD S2BejMYmRAS75BQ+oqJ1vdqx6fneKCTz4OMxVEMxb1H5mATh3AwaabvhmyEVQ8jBnqGDw3 L0NTS6yAOQuGzdFHo3lpqU+ytH5UkZk= X-MC-Unique: YXEMi6y_P9uPe0yRSBErtA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: NU5P-H8FPxO-r8uSsjBH2g-1 From: Jiang Jiacheng To: Subject: [PATCH 1/3] qemu: Init address before qemuProcessShutdownOrReboot during reconnect process Date: Wed, 28 Sep 2022 21:53:28 +0800 Message-ID: <20220928135330.2868549-2-jiangjiacheng@huawei.com> In-Reply-To: <20220928135330.2868549-1-jiangjiacheng@huawei.com> References: <20220928135330.2868549-1-jiangjiacheng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500022.china.huawei.com (7.185.36.66) X-CFilter-Loop: Reflected X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yubihong@huawei.com, zhengchuan@huawei.com, linyilu@huawei.com, jiangjiacheng@huawei.com, xiexiangyou@huawei.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1664377968063100001 Content-Type: text/plain; charset="utf-8" When libvirt is restarted, the qemuProcessShutdownReboot command is executed to restore the VM that is being restarted. In this case, a coredump may occur when we hotplug a pci device since the PCI address hasn't be inited yet. Moving the initialization of address to the front of qemuProcessShutdownOrReboot to ensure that we have the address inited. Signed-off-by: Jiang Jiacheng Reviewed-by: Michal Privoznik --- src/qemu/qemu_process.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 32f03ff79a..6c93f28a9e 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8784,6 +8784,11 @@ qemuProcessReconnect(void *opaque) goto error; } =20 + if ((qemuDomainAssignAddresses(obj->def, priv->qemuCaps, + driver, obj, false)) < 0) { + goto error; + } + /* In case the domain shutdown or fake reboot while we were not runnin= g, * we need to finish the shutdown or fake reboot process. And we need = to * do it after we have virQEMUCaps filled in. @@ -8802,11 +8807,6 @@ qemuProcessReconnect(void *opaque) if (qemuProcessBuildDestroyMemoryPaths(driver, obj, NULL, true) < 0) goto error; =20 - if ((qemuDomainAssignAddresses(obj->def, priv->qemuCaps, - driver, obj, false)) < 0) { - goto error; - } - /* if domain requests security driver we haven't loaded, report error,= but * do not kill the domain */ --=20 2.33.0