From nobody Fri May 17 23:47:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1663899869; cv=none; d=zohomail.com; s=zohoarc; b=nOjRR7AoDrOTcsYKuXQdUJuy+2H6YSyE2pCpqKhCnEdLhOy0k2VhXgq/go8Ag/bLZ5BxUHkMhHp3qDlJiQumtma852VLE0fKmFEwevtmMuUB9vRWAsOxdnh/qSiFsff0WVMi5ZVTWl9uTNlyXZwiW4thWyLHLv4t4+IMfNzYkJU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663899869; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7+nSb2hgOvSM8o/hMsbhcUeTjyh7toe/kq4hLAhe8WA=; b=DgblYvqjmhq9Eo0t0tEZhLPswCUfjI0b8EwNYrxP0buFrTEPSAk2LId5+BEGYY3W+A3gIWxu5YdZvvLkVP5V6kvW57ECa2DJ91PmKeBwZRdNh5Pc4MWKpHKwFZDU9BQ3iIFubSJgHLPdhQ81aChOXp1hY90eI55ssn4wx5zjTvk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1663899868806535.4959670208996; Thu, 22 Sep 2022 19:24:28 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-256-2hsELZT7NOOFjCY6wQ2rhg-1; Thu, 22 Sep 2022 22:24:23 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DDD103C0D86D; Fri, 23 Sep 2022 02:24:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F4F52166B34; Fri, 23 Sep 2022 02:24:19 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3AA4D19465B6; Fri, 23 Sep 2022 02:24:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9D28619465A4 for ; Fri, 23 Sep 2022 02:24:18 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 5A315492B13; Fri, 23 Sep 2022 02:24:18 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast10.extmail.prod.ext.rdu2.redhat.com [10.11.55.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 52B23492B12 for ; Fri, 23 Sep 2022 02:24:18 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ED2E01C04B58 for ; Fri, 23 Sep 2022 02:24:17 +0000 (UTC) Received: from smtp.cecloud.com (smtp.cecloud.com [106.39.185.58]) by relay.mimecast.com with ESMTP id us-mta-3-jeOdxJ9bNQSjkZeYS9ZSjw-1; Thu, 22 Sep 2022 22:24:14 -0400 Received: from localhost (localhost [127.0.0.1]) by smtp.cecloud.com (Postfix) with ESMTP id D426517E0205 for ; Fri, 23 Sep 2022 10:24:11 +0800 (CST) Received: from localhost.localdomain (unknown [111.48.58.10]) by smtp.cecloud.com (postfix) whith ESMTP id P2473742T281457150587248S1663899845868018_; Fri, 23 Sep 2022 10:24:11 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663899866; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=7+nSb2hgOvSM8o/hMsbhcUeTjyh7toe/kq4hLAhe8WA=; b=Vd0lbUpuWYLnKYuWYKmTSl+NLyhGW2nDlQkxrLQp6b8rSMZuGCTOe5K3zdNuEXvyWLpr/G nxP0GsK8/czJ3kTdxCJSzr9iZ31jR7OrfQMlu/Xxkk9n0yqQ+4S8kFDgcwO2gDBKulxSVV +Q6dW5O3CcujWSaWsgJztHCFRU10W0s= X-MC-Unique: 2hsELZT7NOOFjCY6wQ2rhg-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: jeOdxJ9bNQSjkZeYS9ZSjw-1 X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ANTISPAM-LEVEL: 2 X-ABS-CHECKED: 0 X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: luzhipeng@cestc.cn X-SENDER: luzhipeng@cestc.cn X-LOGIN-NAME: luzhipeng@cestc.cn X-FST-TO: libvir-list@redhat.com X-RCPT-COUNT: 2 X-SENDER-IP: 111.48.58.10 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 From: luzhipeng To: libvir-list@redhat.com Subject: [PATCH v2] qemu: fix memory leak about virDomainEventTunableNew Date: Fri, 23 Sep 2022 10:23:38 +0800 Message-Id: <20220923022338.2000-1-luzhipeng@cestc.cn> In-Reply-To: <'20220922130038.1616-1-luzhipeng@cestc.cn'> References: <'20220922130038.1616-1-luzhipeng@cestc.cn'> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Mimecast-Spam-Signature: yes X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lu zhipeng Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1663899870097100001 Content-Type: text/plain; charset="utf-8"; x-default="true" From: lu zhipeng For prevent memory leak and easier to use, So change virDomainEventTunableNew to get virTypedParameterPtr *params and set it =3D NULL. Signed-off-by: lu zhipeng --- v1: https://patchew.org/Libvirt/20220922130038.1616-1-luzhipeng@cestc.cn/ src/conf/domain_event.c | 12 ++++++------ src/conf/domain_event.h | 4 ++-- src/qemu/qemu_driver.c | 22 ++++++++++------------ src/remote/remote_driver.c | 2 +- 4 files changed, 19 insertions(+), 21 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index ff8ea2c389..97d58c2521 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -1495,7 +1495,7 @@ static virObjectEvent * virDomainEventTunableNew(int id, const char *name, unsigned char *uuid, - virTypedParameterPtr params, + virTypedParameterPtr *params, int nparams) { virDomainEventTunable *ev; @@ -1508,19 +1508,19 @@ virDomainEventTunableNew(int id, id, name, uuid))) goto error; =20 - ev->params =3D params; + ev->params =3D *params; ev->nparams =3D nparams; - + *params =3D NULL; return (virObjectEvent *)ev; =20 error: - virTypedParamsFree(params, nparams); + virTypedParamsFree(*params, nparams); return NULL; } =20 virObjectEvent * virDomainEventTunableNewFromObj(virDomainObj *obj, - virTypedParameterPtr params, + virTypedParameterPtr *params, A int nparams) { return virDomainEventTunableNew(obj->def->id, @@ -1532,7 +1532,7 @@ virDomainEventTunableNewFromObj(virDomainObj *obj, =20 virObjectEvent * virDomainEventTunableNewFromDom(virDomainPtr dom, - virTypedParameterPtr params, + virTypedParameterPtr *params, int nparams) { return virDomainEventTunableNew(dom->id, diff --git a/src/conf/domain_event.h b/src/conf/domain_event.h index 4a9f6b988b..f4016dc1e9 100644 --- a/src/conf/domain_event.h +++ b/src/conf/domain_event.h @@ -195,11 +195,11 @@ virDomainEventDeviceRemovalFailedNewFromDom(virDomain= Ptr dom, =20 virObjectEvent * virDomainEventTunableNewFromObj(virDomainObj *obj, - virTypedParameterPtr params, + virTypedParameterPtr *params, int nparams); virObjectEvent * virDomainEventTunableNewFromDom(virDomainPtr dom, - virTypedParameterPtr params, + virTypedParameterPtr *params, int nparams); =20 virObjectEvent * diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 94b70872d4..3db4592945 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4472,12 +4472,12 @@ qemuDomainPinVcpuLive(virDomainObj *vm, &eventMaxparams, paramField, str) < 0) goto cleanup; =20 - event =3D virDomainEventTunableNewFromObj(vm, eventParams, eventNparam= s); A - + event =3D virDomainEventTunableNewFromObj(vm, &eventParams, eventNpara= ms); ret =3D 0; =20 cleanup: virObjectEventStateQueue(driver->domainEventState, event); + virTypedParamsFree(eventParams, eventNparams); return ret; } =20 @@ -4681,7 +4681,7 @@ qemuDomainPinEmulator(virDomainPtr dom, str) < 0) goto endjob; =20 - event =3D virDomainEventTunableNewFromDom(dom, eventParams, eventN= params); + event =3D virDomainEventTunableNewFromDom(dom, &eventParams, event= Nparams); } =20 if (persistentDef) { B A @@ -4700,6 +4700,7 @@ qemuDomainPinEmulator(virDomainPtr dom, cleanup: virObjectEventStateQueue(driver->domainEventState, event); virDomainObjEndAPI(&vm); + virTypedParamsFree(eventParams, eventNparams); return ret; } =20 @@ -5078,7 +5079,7 @@ qemuDomainPinIOThread(virDomainPtr dom, &eventMaxparams, paramField, str) < 0) goto endjob; =20 - event =3D virDomainEventTunableNewFromDom(dom, eventParams, eventN= params); + event =3D virDomainEventTunableNewFromDom(dom, &eventParams, event= Nparams); } =20 if (persistentDef) { @@ -5106,6 +5107,7 @@ qemuDomainPinIOThread(virDomainPtr dom, cleanup: virObjectEventStateQueue(driver->domainEventState, event); virDomainObjEndAPI(&vm); + virTypedParamsFree(eventParams, eventNparams); return ret; } =20 @@ -9633,8 +9635,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr do= m, qemuDomainSaveStatus(vm); =20 if (eventNparams) { - event =3D virDomainEventTunableNewFromDom(dom, eventParams, eventN= params); - eventNparams =3D 0; + event =3D virDomainEventTunableNewFromDom(dom, &eventParams, event= Nparams); virObjectEventStateQueue(driver->domainEventState, event); } =20 @@ -9654,8 +9655,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr do= m, =20 cleanup: virDomainObjEndAPI(&vm); - if (eventNparams) - virTypedParamsFree(eventParams, eventNparams); + virTypedParamsFree(eventParams, eventNparams); return ret; } #undef SCHED_RANGE_CHECK @@ -16159,8 +16159,7 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, qemuDomainSaveStatus(vm); =20 if (eventNparams) { - event =3D virDomainEventTunableNewFromDom(dom, eventParams, ev= entNparams); - eventNparams =3D 0; + event =3D virDomainEventTunableNewFromDom(dom, &eventParams, e= ventNparams); virObjectEventStateQueue(driver->domainEventState, event); } } @@ -16202,8 +16201,7 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, VIR_FREE(info.group_name); VIR_FREE(conf_info.group_name); virDomainObjEndAPI(&vm); - if (eventNparams) - virTypedParamsFree(eventParams, eventNparams); + virTypedParamsFree(eventParams, eventNparams); return ret; } =20 diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index a4efe101a3..b0dba9057b 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -5078,7 +5078,7 @@ remoteDomainBuildEventCallbackTunable(virNetClientPro= gram *prog G_GNUC_UNUSED, return; } =20 - event =3D virDomainEventTunableNewFromDom(dom, params, nparams); + event =3D virDomainEventTunableNewFromDom(dom, ¶ms, nparams); =20 virObjectUnref(dom); =20 --=20 2.31.1