From nobody Tue Feb 10 09:57:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=weirdnatto.in ARC-Seal: i=1; a=rsa-sha256; t=1663813211; cv=none; d=zohomail.com; s=zohoarc; b=ncSQXRG+vlESCzcR8nL3p/Dtg5GhGN9cKiI/6P9Z1XXLaY3h/IvRAuqV/sAKXuzZcOzucvpQ2avPo0s/vS8zBP4Jn4eUZZ+klqQ9Lj5z2Iy0q2iBfEKU4wk/Q+JT0kDw+hAebkQU40SrnOWWpLRL9w0M/nIoRiOForSUg9Kofp8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663813211; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UxC6d/mgyKDkIoLaVzzygutXAow0At6Av6Efd+4ppaE=; b=ejPYg388/+ZoVu0cFqm4VvyMtD4p1rwhMDEhJVjZt6aTpWm3czu6mAIeXQSPUnx/KPeiJFOStc3FEDlQoJHh3qrrIWXX0D4sWhDIkMOb9Cox4MEPLkhmFLCc1P1wwX8TNlpcVsYkOvg7ErpB8nJC0ZbLqmixTfJDzJ2MeeOIIs4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1663813211119717.4945390370091; Wed, 21 Sep 2022 19:20:11 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-447-ePfwaxT_M5G5dd6bO4cL-A-1; Wed, 21 Sep 2022 22:20:06 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 475AF3804080; Thu, 22 Sep 2022 02:20:03 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 334E640C2064; Thu, 22 Sep 2022 02:20:03 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1FE4419465A4; Thu, 22 Sep 2022 02:20:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 55E3219465A4 for ; Thu, 22 Sep 2022 02:20:02 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3940C1400AFC; Thu, 22 Sep 2022 02:20:02 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3246C140EBF6 for ; Thu, 22 Sep 2022 02:20:02 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 17CB7801231 for ; Thu, 22 Sep 2022 02:20:02 +0000 (UTC) Received: from mail.weirdnatto.in (140.238.225.67 [140.238.225.67]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-150-mHsghstUP7a--TsmoNF0GQ-1; Wed, 21 Sep 2022 22:19:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663813210; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UxC6d/mgyKDkIoLaVzzygutXAow0At6Av6Efd+4ppaE=; b=PU7+eg3Apv3En+G8NQqlv0QQVQZAwYEuDXVYuDlbZqaH0dpCGf3xd8fOKQURHhdgWuhmj2 3NMSI0dEzT+KOnvhE2Hn+vttqkImKHLkka4ehZf1aciSoRqMHlz4K7OotzrgDl3cba5mqv n/UE5kcrX3cA/RSF9xwkD39PdS/Y2V8= X-MC-Unique: ePfwaxT_M5G5dd6bO4cL-A-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: mHsghstUP7a--TsmoNF0GQ-1 From: Amneesh Singh To: libvir-list@redhat.com Subject: [RFC PATCH 2/5] add a global feature for supporting virHistogram Date: Thu, 22 Sep 2022 07:49:00 +0530 Message-Id: <20220922021903.376973-3-natto@weirdnatto.in> In-Reply-To: <20220922021903.376973-1-natto@weirdnatto.in> References: <20220922021903.376973-1-natto@weirdnatto.in> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mkletzan@redhat.com, pbonzini@redhat.com, Amneesh Singh Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1663813211549100004 Content-Type: text/plain; charset="utf-8"; x-default="true" Signed-off-by: Amneesh Singh --- src/ch/ch_driver.c | 1 + src/driver.c | 1 + src/esx/esx_driver.c | 1 + src/libvirt_internal.h | 5 +++++ src/libxl/libxl_driver.c | 1 + src/lxc/lxc_driver.c | 1 + src/network/bridge_driver.c | 1 + src/openvz/openvz_driver.c | 1 + src/qemu/qemu_driver.c | 1 + src/remote/remote_daemon_dispatch.c | 1 + src/test/test_driver.c | 1 + src/vz/vz_driver.c | 1 + 12 files changed, 16 insertions(+) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index db2a66d131..80afc4a870 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -927,6 +927,7 @@ chConnectSupportsFeature(virConnectPtr conn, case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_TYPED_PARAM_HISTOGRAM: case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: case VIR_DRV_FEATURE_FD_PASSING: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, diff --git a/src/driver.c b/src/driver.c index cea74bdf95..99ff963d2e 100644 --- a/src/driver.c +++ b/src/driver.c @@ -357,6 +357,7 @@ virDriverFeatureIsGlobal(virDrvFeature feat, * At this point everything supports them and thus also drivers need to * always advertise this feature */ case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_TYPED_PARAM_HISTOGRAM: /* Feature flag exposes that the accidental switching of order of argu= ments * in the public API trampoline virNetworkUpdate is known. Updated cli= ents * thus use the correct ordering with an updated server. All drivers m= ust diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 9dc5489411..b8bac39c5b 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -1028,6 +1028,7 @@ esxConnectSupportsFeature(virConnectPtr conn, int fea= ture) case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_TYPED_PARAM_HISTOGRAM: case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: case VIR_DRV_FEATURE_FD_PASSING: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, diff --git a/src/libvirt_internal.h b/src/libvirt_internal.h index 1ae3e2b2e0..b8b4525e6d 100644 --- a/src/libvirt_internal.h +++ b/src/libvirt_internal.h @@ -132,6 +132,11 @@ typedef enum { * Whether the virNetworkUpdate() API implementation passes arguments = to * the driver's callback in correct order. */ VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER =3D 16, + + /* + * Support for VIR_TYPED_PARAM_HISTOGRAM + */ + VIR_DRV_FEATURE_TYPED_PARAM_HISTOGRAM =3D 17, } virDrvFeature; =20 =20 diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 1b8b40e9e0..f3d47c83a5 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -5698,6 +5698,7 @@ libxlConnectSupportsFeature(virConnectPtr conn, int f= eature) case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_TYPED_PARAM_HISTOGRAM: case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: case VIR_DRV_FEATURE_FD_PASSING: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index d66c26221c..76cd612447 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -1622,6 +1622,7 @@ lxcConnectSupportsFeature(virConnectPtr conn, int fea= ture) case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_TYPED_PARAM_HISTOGRAM: case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: case VIR_DRV_FEATURE_FD_PASSING: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 7c6430b4e3..fe5ee1f781 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -825,6 +825,7 @@ networkConnectSupportsFeature(virConnectPtr conn, int f= eature) case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_TYPED_PARAM_HISTOGRAM: case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: case VIR_DRV_FEATURE_FD_PASSING: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 5c18f5238b..2a7fbd3bde 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -1914,6 +1914,7 @@ openvzConnectSupportsFeature(virConnectPtr conn G_GNU= C_UNUSED, int feature) case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_TYPED_PARAM_HISTOGRAM: case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: case VIR_DRV_FEATURE_FD_PASSING: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 8370b8593b..52e1f88568 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1187,6 +1187,7 @@ qemuConnectSupportsFeature(virConnectPtr conn, int fe= ature) case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_TYPED_PARAM_HISTOGRAM: case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: case VIR_DRV_FEATURE_FD_PASSING: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon= _dispatch.c index 7efe58b36b..a5837dce26 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -4969,6 +4969,7 @@ static int remoteDispatchConnectSupportsFeature(virNe= tServer *server G_GNUC_UNUS case VIR_DRV_FEATURE_MIGRATION_V3: case VIR_DRV_FEATURE_MIGRATE_CHANGE_PROTECTION: case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_TYPED_PARAM_HISTOGRAM: case VIR_DRV_FEATURE_XML_MIGRATABLE: case VIR_DRV_FEATURE_MIGRATION_OFFLINE: case VIR_DRV_FEATURE_MIGRATION_PARAMS: diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 686ff051a8..795c8e0798 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1666,6 +1666,7 @@ testConnectSupportsFeature(virConnectPtr conn G_GNUC_= UNUSED, =20 switch ((virDrvFeature) feature) { case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_TYPED_PARAM_HISTOGRAM: case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: return 1; case VIR_DRV_FEATURE_MIGRATION_V2: diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 4f5e340d53..bcc4073520 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -3021,6 +3021,7 @@ vzConnectSupportsFeature(virConnectPtr conn G_GNUC_UN= USED, int feature) case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_TYPED_PARAM_HISTOGRAM: case VIR_DRV_FEATURE_XML_MIGRATABLE: default: return 0; --=20 2.37.1