From nobody Sat Feb 7 10:08:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1663605623; cv=none; d=zohomail.com; s=zohoarc; b=HDRzlXlM30eri7TDsrNzrTJlHEfCxUUp92wIDLcBmeuFlAs95Wjp1Cvhrdd1jg7IW75HFQzNm5uKlYPOSa1l21THAE12cHqA8Eglv2TLTSawhQbsVs4CnC8ibgjyTs0D/rLKQB6R989csbju2TWwrV2snJ0mL7KBJGWZcT3Q2Kw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663605623; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9Ezy7H0CyIZqT44cQ63VOPGxN6ZW1fq9pcgblTjaPd8=; b=K/SKXoelw861p5hCwSVxU63pqDNqV6Bifpwf2JrZ0ZI+4hqZ18ms0zcZu7eh081LqgiOQZEOg+XrXKcNdK5j0JGcAiRgZqnYeWtJGBwohEXPkAF1q6CoXY67BYKmByUwMzvrYHZiaw7Vldiuvqvl5Pl5cIHSOQcaxTGSNl7BHQU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1663605623528222.71141021689027; Mon, 19 Sep 2022 09:40:23 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-564-OUQLk-PHPXyS5kNFV6keLA-1; Mon, 19 Sep 2022 12:40:14 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D2B20882821; Mon, 19 Sep 2022 16:40:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id BD779492B04; Mon, 19 Sep 2022 16:40:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8CCA819465A3; Mon, 19 Sep 2022 16:40:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9D3B019465A2 for ; Mon, 19 Sep 2022 16:40:10 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 8EB95C15BB1; Mon, 19 Sep 2022 16:40:10 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast10.extmail.prod.ext.rdu2.redhat.com [10.11.55.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 87457C15BA4 for ; Mon, 19 Sep 2022 16:40:10 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 68E161C1BD21 for ; Mon, 19 Sep 2022 16:40:10 +0000 (UTC) Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-630-a4uHFj1HPxSSmHA9aQ_CxQ-1; Mon, 19 Sep 2022 12:40:08 -0400 Received: by mail-oi1-f174.google.com with SMTP id u131so186927oie.5 for ; Mon, 19 Sep 2022 09:40:08 -0700 (PDT) Received: from balboa.COMFAST ([191.193.2.69]) by smtp.gmail.com with ESMTPSA id z20-20020a056871015400b0012784cb563dsm8544889oab.22.2022.09.19.09.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 09:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663605621; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9Ezy7H0CyIZqT44cQ63VOPGxN6ZW1fq9pcgblTjaPd8=; b=X3u63MyXOs2+YXgKz1fqL2YjbzbOYr3gabirggzKNeJtr++XU+TTVKLI06rOlHhICCwB++ P4EmM37kQJIBD+t7HOCewx8Bd1NRJARvW7w+0blw7fmofZZctEHcX0oN8rasjA+DLweVLY LAtWkWbFJIQNJpPReVjsYjiRgeB0Kh0= X-MC-Unique: OUQLk-PHPXyS5kNFV6keLA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: a4uHFj1HPxSSmHA9aQ_CxQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=9Ezy7H0CyIZqT44cQ63VOPGxN6ZW1fq9pcgblTjaPd8=; b=qaxtViU0XiRwADoMAKaS7JsNbS6U5JiyrfBar6GC+DD7GxoHIrmwIAnWKuF2Savppo T+WCFeuJhXXBKdoDuhDkXNpAU6VfdhJCf+Sl8AT4wbJnoeWqkAbHLlPj89VE7hitQSFg t/s4MB2MI/lx16yhDAd/0MoTrHQppPdPbrYwMRFyqLZlb85H741B2m7kY7zC3T0Kn8Dy xX46C0E9JlHxriw6lXkRSy0VUzeezxi2Ded2de9308KzfwGQ8Rp9WWBpcmxPjZnzRrNF kTELawgSsiSPuewU5jBElODlEKsdHChiBAIDcRMDDi+GL8wjLTh/3WPrZxR5sG6+whfd LYOg== X-Gm-Message-State: ACgBeo1hcZSe0H3JOUzleyAUVzLiumQ7MsIDAt2o81bI69fT+XJZIQqT XhH1nBLOcUwe2YkBQbw/tNEdkeTJJL0= X-Google-Smtp-Source: AA6agR5kdqYaYA6sEZkq/B9lG3jk3WO2veoZNF4nj15xjGQN/kDy4OyE6TMygIozNsJ4M8RhYmuYxw== X-Received: by 2002:a05:6808:bcd:b0:344:d4b5:9a16 with SMTP id o13-20020a0568080bcd00b00344d4b59a16mr12483237oik.113.1663605607609; Mon, 19 Sep 2022 09:40:07 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH 3/3] tests: refactor pseries features parse failure tests Date: Mon, 19 Sep 2022 13:39:49 -0300 Message-Id: <20220919163949.19768-4-danielhb413@gmail.com> In-Reply-To: <20220919163949.19768-1-danielhb413@gmail.com> References: <20220919163949.19768-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: danielhb413@gmail.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1663605625004100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The qemuxml2argvtest pseries-feature parse failure tests uses a symlink to the pseries-features.xml test domain and control which feature it is supposed to fail by excluding it from the capabilities list. The advantage of this approach is that the same XML can be used in multiple tests. One downside is that any new pseries capability must be declared in all existent tests, otherwise all other tests can break if this new capability happens to be validated early in qemu_validate.c. Any new parse_error test must declare all other existent capabilities. Another downside is the fact that we're testing fairly improbable scenarios: all pseries capabilities being tested here were introduced by the same QEMU version, 4.2.0, at least as far as libvirt is aware of. This means that it's no possible to have a scenario where, for example, ccf-assist is not present but cfpc is. And last, but not the least, it's getting in the way of our effort to convert all pseries tests to not use explicit capabilities. Changing all these tests to use DO_TEST_PARSE_ERROR_NOCAPS() will allow us to test exactly what we want to test, which is the parse error given for each feature if the binary does not have support for it. The XML being used for each test can be simplified to just declare a single feature. In the end we'll end up with more XML lines, but less complexity inside qemuxml2argvtest.c. Signed-off-by: Daniel Henrique Barboza --- .../qemuxml2argvdata/pseries-features-ccf.xml | 15 +++- .../pseries-features-cfpc.xml | 15 +++- .../pseries-features-hpt-pagesize.xml | 17 ++++- .../qemuxml2argvdata/pseries-features-htm.xml | 15 +++- .../qemuxml2argvdata/pseries-features-ibs.xml | 15 +++- .../pseries-features-nested-hv.xml | 15 +++- .../pseries-features-sbbc.xml | 15 +++- tests/qemuxml2argvtest.c | 69 ++----------------- 8 files changed, 107 insertions(+), 69 deletions(-) mode change 120000 =3D> 100644 tests/qemuxml2argvdata/pseries-features-ccf= .xml mode change 120000 =3D> 100644 tests/qemuxml2argvdata/pseries-features-cfp= c.xml mode change 120000 =3D> 100644 tests/qemuxml2argvdata/pseries-features-hpt= -pagesize.xml mode change 120000 =3D> 100644 tests/qemuxml2argvdata/pseries-features-htm= .xml mode change 120000 =3D> 100644 tests/qemuxml2argvdata/pseries-features-ibs= .xml mode change 120000 =3D> 100644 tests/qemuxml2argvdata/pseries-features-nes= ted-hv.xml mode change 120000 =3D> 100644 tests/qemuxml2argvdata/pseries-features-sbb= c.xml diff --git a/tests/qemuxml2argvdata/pseries-features-ccf.xml b/tests/qemuxm= l2argvdata/pseries-features-ccf.xml deleted file mode 120000 index e7b69bba78..0000000000 --- a/tests/qemuxml2argvdata/pseries-features-ccf.xml +++ /dev/null @@ -1 +0,0 @@ -pseries-features.xml \ No newline at end of file diff --git a/tests/qemuxml2argvdata/pseries-features-ccf.xml b/tests/qemuxm= l2argvdata/pseries-features-ccf.xml new file mode 100644 index 0000000000..037d9feaab --- /dev/null +++ b/tests/qemuxml2argvdata/pseries-features-ccf.xml @@ -0,0 +1,14 @@ + + guest + 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 + 524288 + + hvm + + + + + + /usr/bin/qemu-system-ppc64 + + diff --git a/tests/qemuxml2argvdata/pseries-features-cfpc.xml b/tests/qemux= ml2argvdata/pseries-features-cfpc.xml deleted file mode 120000 index e7b69bba78..0000000000 --- a/tests/qemuxml2argvdata/pseries-features-cfpc.xml +++ /dev/null @@ -1 +0,0 @@ -pseries-features.xml \ No newline at end of file diff --git a/tests/qemuxml2argvdata/pseries-features-cfpc.xml b/tests/qemux= ml2argvdata/pseries-features-cfpc.xml new file mode 100644 index 0000000000..9229e87aab --- /dev/null +++ b/tests/qemuxml2argvdata/pseries-features-cfpc.xml @@ -0,0 +1,14 @@ + + guest + 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 + 524288 + + hvm + + + + + + /usr/bin/qemu-system-ppc64 + + diff --git a/tests/qemuxml2argvdata/pseries-features-hpt-pagesize.xml b/tes= ts/qemuxml2argvdata/pseries-features-hpt-pagesize.xml deleted file mode 120000 index e7b69bba78..0000000000 --- a/tests/qemuxml2argvdata/pseries-features-hpt-pagesize.xml +++ /dev/null @@ -1 +0,0 @@ -pseries-features.xml \ No newline at end of file diff --git a/tests/qemuxml2argvdata/pseries-features-hpt-pagesize.xml b/tes= ts/qemuxml2argvdata/pseries-features-hpt-pagesize.xml new file mode 100644 index 0000000000..ba919f6b0d --- /dev/null +++ b/tests/qemuxml2argvdata/pseries-features-hpt-pagesize.xml @@ -0,0 +1,16 @@ + + guest + 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 + 524288 + + hvm + + + + 1 + + + + /usr/bin/qemu-system-ppc64 + + diff --git a/tests/qemuxml2argvdata/pseries-features-htm.xml b/tests/qemuxm= l2argvdata/pseries-features-htm.xml deleted file mode 120000 index e7b69bba78..0000000000 --- a/tests/qemuxml2argvdata/pseries-features-htm.xml +++ /dev/null @@ -1 +0,0 @@ -pseries-features.xml \ No newline at end of file diff --git a/tests/qemuxml2argvdata/pseries-features-htm.xml b/tests/qemuxm= l2argvdata/pseries-features-htm.xml new file mode 100644 index 0000000000..59ac294161 --- /dev/null +++ b/tests/qemuxml2argvdata/pseries-features-htm.xml @@ -0,0 +1,14 @@ + + guest + 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 + 524288 + + hvm + + + + + + /usr/bin/qemu-system-ppc64 + + diff --git a/tests/qemuxml2argvdata/pseries-features-ibs.xml b/tests/qemuxm= l2argvdata/pseries-features-ibs.xml deleted file mode 120000 index e7b69bba78..0000000000 --- a/tests/qemuxml2argvdata/pseries-features-ibs.xml +++ /dev/null @@ -1 +0,0 @@ -pseries-features.xml \ No newline at end of file diff --git a/tests/qemuxml2argvdata/pseries-features-ibs.xml b/tests/qemuxm= l2argvdata/pseries-features-ibs.xml new file mode 100644 index 0000000000..c3317b47ba --- /dev/null +++ b/tests/qemuxml2argvdata/pseries-features-ibs.xml @@ -0,0 +1,14 @@ + + guest + 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 + 524288 + + hvm + + + + + + /usr/bin/qemu-system-ppc64 + + diff --git a/tests/qemuxml2argvdata/pseries-features-nested-hv.xml b/tests/= qemuxml2argvdata/pseries-features-nested-hv.xml deleted file mode 120000 index e7b69bba78..0000000000 --- a/tests/qemuxml2argvdata/pseries-features-nested-hv.xml +++ /dev/null @@ -1 +0,0 @@ -pseries-features.xml \ No newline at end of file diff --git a/tests/qemuxml2argvdata/pseries-features-nested-hv.xml b/tests/= qemuxml2argvdata/pseries-features-nested-hv.xml new file mode 100644 index 0000000000..8d74ab41ab --- /dev/null +++ b/tests/qemuxml2argvdata/pseries-features-nested-hv.xml @@ -0,0 +1,14 @@ + + guest + 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 + 524288 + + hvm + + + + + + /usr/bin/qemu-system-ppc64 + + diff --git a/tests/qemuxml2argvdata/pseries-features-sbbc.xml b/tests/qemux= ml2argvdata/pseries-features-sbbc.xml deleted file mode 120000 index e7b69bba78..0000000000 --- a/tests/qemuxml2argvdata/pseries-features-sbbc.xml +++ /dev/null @@ -1 +0,0 @@ -pseries-features.xml \ No newline at end of file diff --git a/tests/qemuxml2argvdata/pseries-features-sbbc.xml b/tests/qemux= ml2argvdata/pseries-features-sbbc.xml new file mode 100644 index 0000000000..e7f8d46176 --- /dev/null +++ b/tests/qemuxml2argvdata/pseries-features-sbbc.xml @@ -0,0 +1,14 @@ + + guest + 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 + 524288 + + hvm + + + + + + /usr/bin/qemu-system-ppc64 + + diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 67b9ffb3e7..f11edda699 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -2170,74 +2170,19 @@ mymain(void) DO_TEST_CAPS_LATEST_PPC64("pseries-features"); =20 /* parse error: no QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZE */ - DO_TEST_PARSE_ERROR("pseries-features-hpt-pagesize", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HTM, - QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV, - QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST, - QEMU_CAPS_MACHINE_PSERIES_CAP_CFPC, - QEMU_CAPS_MACHINE_PSERIES_CAP_SBBC, - QEMU_CAPS_MACHINE_PSERIES_CAP_IBS); - + DO_TEST_PARSE_ERROR_NOCAPS("pseries-features-hpt-pagesize"); /* parse error: no QEMU_CAPS_MACHINE_PSERIES_CAP_HTM */ - DO_TEST_PARSE_ERROR("pseries-features-htm", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZE, - QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV, - QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST, - QEMU_CAPS_MACHINE_PSERIES_CAP_CFPC, - QEMU_CAPS_MACHINE_PSERIES_CAP_SBBC, - QEMU_CAPS_MACHINE_PSERIES_CAP_IBS); - + DO_TEST_PARSE_ERROR_NOCAPS("pseries-features-htm"); /* parse error: no QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV */ - DO_TEST_PARSE_ERROR("pseries-features-nested-hv", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HTM, - QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST, - QEMU_CAPS_MACHINE_PSERIES_CAP_CFPC, - QEMU_CAPS_MACHINE_PSERIES_CAP_SBBC, - QEMU_CAPS_MACHINE_PSERIES_CAP_IBS); - + DO_TEST_PARSE_ERROR_NOCAPS("pseries-features-nested-hv"); /* parse error: no QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST */ - DO_TEST_PARSE_ERROR("pseries-features-ccf", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HTM, - QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV, - QEMU_CAPS_MACHINE_PSERIES_CAP_CFPC, - QEMU_CAPS_MACHINE_PSERIES_CAP_SBBC, - QEMU_CAPS_MACHINE_PSERIES_CAP_IBS); - + DO_TEST_PARSE_ERROR_NOCAPS("pseries-features-ccf"); /* parse error: no QEMU_CAPS_MACHINE_PSERIES_CFPC */ - DO_TEST_PARSE_ERROR("pseries-features-cfpc", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HTM, - QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV, - QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST, - QEMU_CAPS_MACHINE_PSERIES_CAP_SBBC, - QEMU_CAPS_MACHINE_PSERIES_CAP_IBS); - + DO_TEST_PARSE_ERROR_NOCAPS("pseries-features-cfpc"); /* parse error: no QEMU_CAPS_MACHINE_PSERIES_SBBC */ - DO_TEST_PARSE_ERROR("pseries-features-sbbc", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HTM, - QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV, - QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST, - QEMU_CAPS_MACHINE_PSERIES_CAP_CFPC, - QEMU_CAPS_MACHINE_PSERIES_CAP_IBS); - + DO_TEST_PARSE_ERROR_NOCAPS("pseries-features-sbbc"); /* parse error: no QEMU_CAPS_MACHINE_PSERIES_IBS */ - DO_TEST_PARSE_ERROR("pseries-features-ibs", - QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZE, - QEMU_CAPS_MACHINE_PSERIES_CAP_HTM, - QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV, - QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST, - QEMU_CAPS_MACHINE_PSERIES_CAP_CFPC, - QEMU_CAPS_MACHINE_PSERIES_CAP_SBBC); + DO_TEST_PARSE_ERROR_NOCAPS("pseries-features-ibs"); =20 DO_TEST_PARSE_ERROR_NOCAPS("pseries-features-invalid-machine"); =20 --=20 2.37.3