From nobody Mon Feb 9 20:10:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1661175143; cv=none; d=zohomail.com; s=zohoarc; b=D47zeVm+KPjGLrN+VK2wfGMIt4p07+PDyxAER1R+RYhYkX3764NwHBUE+A2/UPWrpFP01aNmnL2k4w4o3rvHJ1tFDtyvL2GwYcuqa7W0C1D6ULeJ6ooQMYG8XIJR0n6eEbSA0wUFNXnfIAIf8Vd05ngkbYncELaP3C9MpaIbDAU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661175143; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JW3s0jfdZDqG/zvS/nwrDfNwbL3RdCn8Upe9e5CTAWo=; b=OP0JoJ+vj9ORE8296zZl2NrD61ApBD6Hm63QnQGUWEhZzGGBGtsezVr4kf3zysWhBBWswr6tj40vJz/xC86fzLhRwJCCUK3x2B/ZfsOXGVFxRuMTmmVYLbg7f+33b+recljN0fIV+ztxSLVdJSahElnhuth5sfa4S6iNpBfAwps= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1661175143597327.747578761952; Mon, 22 Aug 2022 06:32:23 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-620-Fv92QIYyN8uKS_lpH_TYFQ-1; Mon, 22 Aug 2022 09:32:20 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C49491C0897E; Mon, 22 Aug 2022 13:32:16 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0173945DD; Mon, 22 Aug 2022 13:32:16 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 82BFE1947047; Mon, 22 Aug 2022 13:32:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E354D1946A4B for ; Mon, 22 Aug 2022 13:31:52 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id CD7D640CFD0B; Mon, 22 Aug 2022 13:31:52 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.2.16.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id B8BB440CFD0A for ; Mon, 22 Aug 2022 13:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661175142; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JW3s0jfdZDqG/zvS/nwrDfNwbL3RdCn8Upe9e5CTAWo=; b=D7xK96hADcFuVeI2DZLlom2tOEnON8VulmoTJ3ClFxRlpFOo/1Yp0EvQXzlNkJ6ssg0Gli c8u1eGkEwg58BZsxTqRhSZkEId37g8IojSDbRma9esfV2WBbomwEk9tZ6sWwKH5sy1AT9U cpRylJFGhR66fmHK+LflfnmzdUwGCkQ= X-MC-Unique: Fv92QIYyN8uKS_lpH_TYFQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Laine Stump To: libvir-list@redhat.com Subject: [libvirt PATCH 14/16] util: remove unused function virFirewallApplyRuleFirewallD() Date: Mon, 22 Aug 2022 09:31:48 -0400 Message-Id: <20220822133150.1098794-15-laine@redhat.com> In-Reply-To: <20220822133150.1098794-1-laine@redhat.com> References: <20220822133150.1098794-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1661175145271100001 Content-Type: text/plain; charset="utf-8"; x-default="true" This was a wrapper to call a function in virfirewalld.c that sends an iptables passthrough rule to firewalld. It hasn't been used in a year or two, and won't ever be used in the future since passthrough rules are only supported for iptables, and we've determined that we shouldn't use iptables passthrough rules. Signed-off-by: Laine Stump --- src/util/virfirewall.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c index 3183e0aec7..0a9ba9ad5c 100644 --- a/src/util/virfirewall.c +++ b/src/util/virfirewall.c @@ -523,16 +523,6 @@ virFirewallApplyRuleDirect(virFirewallRule *rule, } =20 =20 -static int G_GNUC_UNUSED -virFirewallApplyRuleFirewallD(virFirewallRule *rule, - bool ignoreErrors, - char **output) -{ - /* wrapper necessary because virFirewallRule is a private struct */ - return virFirewallDApplyRule(rule->layer, rule->args, rule->argsLen, i= gnoreErrors, output); -} - - static int virFirewallApplyRule(virFirewall *firewall, virFirewallRule *rule, --=20 2.37.1