From nobody Mon Feb 9 13:57:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1660724420; cv=none; d=zohomail.com; s=zohoarc; b=PlQ+IDPK/s+vZbfKseU9qIcZhbauD+1ULyM6prY0tk/il3VE0lpisFEmh7Gmv/B+p2r1zdeILUTiC9negSigVxmblvkMa6f9rsqZn8IgOmkYccXc1FO9PD1kO/LPMfYE+lMopigBmUd7dFBiYvuO4g8oFmLwRgmzD9IBS2sp+ic= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660724420; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZZfmZRHtrj9dx17dpepBhaZQvGrIKJK4UaFZgZfegK8=; b=H//tSV+x9rdzK2dtV7lLzQjCHEXdtmSdNUulScsl7l0MWjxkp9lqJdTSJw/j1GWp3hZBz8HObcJ6CRRsPbzK+mg6YnFCam7LQ6Pj59dYSg7v4HaCa60CvQcwRRBgRdLfrz+9AcETkot/hHRUptjekxTWHDIBEVKwpTTI5LLADSA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1660724420641506.4463871618317; Wed, 17 Aug 2022 01:20:20 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-318-zRc9EfFMN7a0DHSFT5eKrg-1; Wed, 17 Aug 2022 04:20:12 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 47CEE1C05145; Wed, 17 Aug 2022 08:20:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 35776492C3B; Wed, 17 Aug 2022 08:20:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 071FE193F517; Wed, 17 Aug 2022 08:20:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 23F90193F6F6 for ; Wed, 17 Aug 2022 08:20:08 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 16BAC94585; Wed, 17 Aug 2022 08:20:08 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 126C8945D9 for ; Wed, 17 Aug 2022 08:20:08 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ED493811E76 for ; Wed, 17 Aug 2022 08:20:07 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130045.outbound.protection.outlook.com [40.107.13.45]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-34-1MPsx_PJON-L_Iz6u-WL4Q-1; Wed, 17 Aug 2022 04:19:58 -0400 Received: from AM9PR04MB8602.eurprd04.prod.outlook.com (2603:10a6:20b:439::12) by DB8PR04MB7148.eurprd04.prod.outlook.com (2603:10a6:10:12d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Wed, 17 Aug 2022 08:19:56 +0000 Received: from AM9PR04MB8602.eurprd04.prod.outlook.com ([fe80::b479:ba12:cf3d:b340]) by AM9PR04MB8602.eurprd04.prod.outlook.com ([fe80::b479:ba12:cf3d:b340%5]) with mapi id 15.20.5525.019; Wed, 17 Aug 2022 08:19:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660724418; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ZZfmZRHtrj9dx17dpepBhaZQvGrIKJK4UaFZgZfegK8=; b=NFPZIV5CnP+Uh9LUj8ZiBJWlwnNJLmWoiTsuDSGT9alAQgNQM6hvIO5pzgsPveDSOSmzAl 3LU0pFk3pAv6NcYzhKEcv3EHe4Q9C4/hu+kcQyZs2tkWxgzGVo/V4J5Tb7Ldn2Z27yMxcN oy5s9BDm3Ph9jw8tx7Kzy8pze8NxO8g= X-MC-Unique: zRc9EfFMN7a0DHSFT5eKrg-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: 1MPsx_PJON-L_Iz6u-WL4Q-1 From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/2] qemu: Remove host-passthrough validation check for host-phys-bits=on Date: Wed, 17 Aug 2022 16:19:43 +0800 Message-ID: <20220817081943.1528-3-lma@suse.com> In-Reply-To: <20220817081943.1528-1-lma@suse.com> References: <20220817081943.1528-1-lma@suse.com> X-ClientProxiedBy: AS9PR07CA0026.eurprd07.prod.outlook.com (2603:10a6:20b:46c::31) To AM9PR04MB8602.eurprd04.prod.outlook.com (2603:10a6:20b:439::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 90153fba-29cb-4018-c836-08da802944b4 X-MS-TrafficTypeDiagnostic: DB8PR04MB7148:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: towClNdOyO+AGUKJ/rm1qISC8vkg9jVGh2SE6fN8wR0VK1QE96iRR0anPaZCSalXwvnY2vwdzN7zLcw5SG7ZCA+wzwt8z5tBPJQF1RYYqhlU4kKAgXMm2SZ+M7TNMVNzqbOJp+6FCaFEquDNR3xZT3IV/gDD4MO9lXJObQ2RtOmzbrblxVt+JRg5kfwG8o+fAIYJ9dMFA20MwMJZnrgf6+Mujwr6ebZMieOwTHTyh74yVjK7KDuU4y27ClFVwo/6TpWISUq1ppR1dld17k3QhPueKd64/AuuTHFOJHFTx6E8/qtr3+8CBBcjTl9jO4hWqnq85b5yO9v/77S/YOu+gEBSudg4gPHJY4rYM3pKCCxcNmjHLtRkkoPM1jOlUN1XPPHK4nmr7VEjNblxvKXf7xAE1xdnrpw2JPufEntzJJ67nDLnGB4VfBlKEUj3PPfcQI4vDZOAGWl/Gqe2GJlkzj4bER8LlVmqvE4GWHSB3wEv+SHADf9jHeabGte5lHlLZbJYUbJ7IBShRTLccixuKoF+USDPwulfJ5/P1WjUDf7cj69XW74n9D+PyzPT8foJuYraMaJzZIYIqTCWBy/h4ri3PN+BT+8qXwI8sL4HU2mfsDtsfwEI9hRb3sJa/NUDZsEtnbfRnc7sELxVVu1BveTrsWhS51MSiPTjfKPN6LzlUDx/B2krwCATYfwLXbgBbtDYYFcTA4IThbL8Az5NHv8VwrzO/YhqVTEecDme3a7AWC+unKyvpN1nRBYoQzK4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM9PR04MB8602.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(346002)(396003)(376002)(39860400002)(366004)(41300700001)(316002)(478600001)(38100700002)(4326008)(6486002)(66946007)(5660300002)(8676002)(66476007)(8936002)(66556008)(26005)(2906002)(6916009)(107886003)(36756003)(186003)(86362001)(6506007)(1076003)(6666004)(2616005)(83380400001)(6512007); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4SagKdj04fDjMtQNCPA806/f1H4D+XB03y4hZ+dH7ivbwIivFWHhE/KSwecm?= =?us-ascii?Q?oF1E4RpK30nAzFgBOBQYLBI5KfQLxSkLUHjbgRl7syvWCxdoj+yTXW7A3lWA?= =?us-ascii?Q?9PVJCYgET16XSM1j7cvg8z1FtG2mfYkzr4DYvpORFYz0rIjy3Pk1vu4pr20S?= =?us-ascii?Q?SqcuTTYPiPTQjhqG9evlztjHuGVRUnfnG2Tffk1BhtdN2nRCDFyrfNEpR0oA?= =?us-ascii?Q?CrBy7yK2bQI+EQkmXf0w+3SNDhcj3Jmf0fdWLVexkKDpICanqEtiOTWFP65e?= =?us-ascii?Q?hszo4SCuatyq/gC61gFAplA3AsUEXTb0ju/YgRNnMt2t+pb95FYf4w4WcubU?= =?us-ascii?Q?qMVyU6FqO09M/x0OV1zWHm99Zket3C49ChzP/C6Xq1+4jwQQRYm6ve3T5B3V?= =?us-ascii?Q?YsSuKAoB2Qo+5DwXyo7v0VOnIuGmkrpEllbEX9rsNml95PV1LtB80sKSJGmo?= =?us-ascii?Q?a6OQ+91e6MljNXp3bbSwyELxiYqKtrwKDc9a2tw9NxFQhMHuqjOF2Yc2clqQ?= =?us-ascii?Q?JpY+nbP1hnAKpaFdfPMph4yVSa0DZHBOmwVuZx4EfO/Lx+PKUxGz+rmTg7mK?= =?us-ascii?Q?F/NIlWV3RGpT0jBpqxk/7OQJM/zIVMvdTqyEmr4mx1V/hzCbqeeDAkRkMCvK?= =?us-ascii?Q?B0FBd+LPbxlADqvzOFw/0IkuSqK9DIARJIes97jmVCNZ33219w+aPPSyKQCb?= =?us-ascii?Q?Cr42719+6f53el3SMTLvUoUgb+vthyR+oEE1TOvTnB5AoJFmXc9hi1TMAfhj?= =?us-ascii?Q?elBxwklmMtRLi3/yk3H6bJeqTbM4lonX4sQ5YbOMWskipjh65okC7X3YfyFh?= =?us-ascii?Q?SfOQujuvMnFBCG42QANhvRL04ODszyQoJHoFfYvWsGhsT8k8Hio6fb+83+Ay?= =?us-ascii?Q?F0mOqbvuQzSKXrpgOLFUhOk4UhUVRodulGYZdu7PDoBdF4gXcbboAr23HyNC?= =?us-ascii?Q?7mHelvftoGoVGcqhUOiRUqndefIzi12AFSERSPrynSqiItz49s6jJPPzpy2k?= =?us-ascii?Q?p0djqOMFt5EtAUX6RI5QK4FHVtkJvAO3T1fBEltta4YCE/aiSuKm510F9CZ5?= =?us-ascii?Q?06YMBY8HmLtBOfVHcruuBE6BGroSMUZC9tILuwj2QfyGMiGQHEVpy393GQu1?= =?us-ascii?Q?nS2SLA1Ggy4G/DkRqk7NLreEaBcNvjR0P0peUvZbmxQVsObggo+EjLGlM+hO?= =?us-ascii?Q?RqyZ054W8U3pjjdvfb5Tve+i7beQzbVvUhd+ZiF7XTN+7vaT87NlLcImHPVc?= =?us-ascii?Q?cbcE9woiWlhU+l/EQsy3LZKvjLPyou7cnUmY7PrUVtqUqMOLAYrIiIEy/Qpq?= =?us-ascii?Q?uQUct/q/N59ruYuhOstH7ysnLP7elknFRtl/Eo+2lWvELmZFtjCpCUtMilh7?= =?us-ascii?Q?aItXeKR51VSzy+Yyqb96OIzC7Y0HnfqOtOGC5AlhAUg2vsLCyjDmeAVpYH8/?= =?us-ascii?Q?MH4QAX8/OrPKvCFJuwVKtLQIdavDhqmE2/Hy6B6CJOhE1gc1GPsFhD5IWp0O?= =?us-ascii?Q?hYJaQnsthdncUXJ+toNE0cY1yO9wtHii0AiMseVpepW2adr600eEOX167ZD/?= =?us-ascii?Q?vDE1pExWR7PHEeyiqk4=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90153fba-29cb-4018-c836-08da802944b4 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8602.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 08:19:56.1996 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V++6x7MjopJijY6hDLAUAdlTRfetkTYbSqABnl9Ssvg4eIino8QUfSBfhHtbznCf X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7148 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lin Ma , dfaggioli@suse.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1660724422206100001 Content-Type: text/plain; charset="utf-8" Besides the -cpu host, The host-phys-bits=3Don applies to custom or max cpu model, So the host-passthrough validation check is unnecessary for maxphysaddr with mode=3D'passthrough'. Signed-off-by: Lin Ma --- src/qemu/qemu_validate.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 6e457f3814..e60575d8a0 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -344,13 +344,6 @@ qemuValidateDomainDefCpu(virQEMUDriver *driver, =20 switch (addr->mode) { case VIR_CPU_MAX_PHYS_ADDR_MODE_PASSTHROUGH: - if (def->cpu->mode !=3D VIR_CPU_MODE_HOST_PASSTHROUGH) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("CPU maximum physical address bits mode '= %s' can only be used with '%s' CPUs"), - virCPUMaxPhysAddrModeTypeToString(addr->mod= e), - virCPUModeTypeToString(VIR_CPU_MODE_HOST_PA= SSTHROUGH)); - return -1; - } if (addr->bits !=3D -1) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("CPU maximum physical address bits number= specification cannot be used with mode=3D'%s'"), --=20 2.26.2