From nobody Mon Feb 9 22:02:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1659963995; cv=none; d=zohomail.com; s=zohoarc; b=jq2vn2ddaIzzjBYAYBLUWF/qBKgYy3eDY4MfKYz+rbZOLhTNsXjoiMufUUNPxvuIf1hTGk6IggIanPAoLltYUHlCSxxKlMD5l1lSRIVoRXnV4nRezosmzNBrfDyI4A/ZOb8q1L9QT9bEdgf1WnuKOwC3W9WUP6FzXcEoyxE37P0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659963995; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bC9iSQK7RVMAZskqzG3rKk/oA/c+BL8lM0VvQLNWyMk=; b=HERmLsXXoMhi3C1k1ih07LfMuAv3p0qfoErxJ2WaHYVF6PNX8mP1TxpSltS35IyB06QDVfGKGmIYuzwWiKsQNz9IiiSvU9uXO6h6Q0dbnUZLdTOrtbQveiuNNcBkcn1TyUL3WSApS3dDU/O+2Y5T6fMjkT2o7CKgpQ046LShOv0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 165996399560170.65190164269052; Mon, 8 Aug 2022 06:06:35 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-397-JEiaolCuNzikoAC_6FZI1w-1; Mon, 08 Aug 2022 09:06:32 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 638332802282; Mon, 8 Aug 2022 13:06:28 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 504111121314; Mon, 8 Aug 2022 13:06:28 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 178961946A4F; Mon, 8 Aug 2022 13:06:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BC3661946A49 for ; Mon, 8 Aug 2022 13:06:26 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 95E2AC15BAA; Mon, 8 Aug 2022 13:06:26 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast08.extmail.prod.ext.rdu2.redhat.com [10.11.55.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90F8AC15BA9 for ; Mon, 8 Aug 2022 13:06:26 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 776723800C42 for ; Mon, 8 Aug 2022 13:06:26 +0000 (UTC) Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-423-1rZN1gq1PwmqHzKg_lHTSg-1; Mon, 08 Aug 2022 09:06:24 -0400 Received: by mail-ej1-f69.google.com with SMTP id gn23-20020a1709070d1700b0073094d0e02cso2399708ejc.20 for ; Mon, 08 Aug 2022 06:06:24 -0700 (PDT) Received: from goa-sendmail ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id os23-20020a170906af7700b0072ab06bf296sm4940357ejb.23.2022.08.08.06.06.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Aug 2022 06:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659963994; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bC9iSQK7RVMAZskqzG3rKk/oA/c+BL8lM0VvQLNWyMk=; b=FdYegHEWrhnEZp+B7mhhyN/8OSaUaz4Yhz3om//Hfm0n/QfGREQZgdZwp/r7FS5oUhJcd/ FAqAYqdXKI8twIIQRZBtvBHLfGSBta2IpK3hnSpOJp3f1zrDIv2EmQ/ioorleWKKOfsYRs o4JquoLbaB6yMn4ArdDP6F+q4eDNWdc= X-MC-Unique: JEiaolCuNzikoAC_6FZI1w-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: 1rZN1gq1PwmqHzKg_lHTSg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=bC9iSQK7RVMAZskqzG3rKk/oA/c+BL8lM0VvQLNWyMk=; b=mvjPhj8gAZE3HB1vyj1hxrJ25HR3KWEwyOSI/ZOHz9v7esGeuPWGC7PiQ+yiQx1Nr/ kPfNJNyyLbn8PzQTaKJuxtWmao8fCrnj4BG9IpLVZ1J/VVnYrr1TW/ifx2gt1A8jj0qW O4PUJ7p3B/EAANYkcfgf/xkw8tfRveiCVYim6cDTMkkYDssevKyEeh6HK5/GtjU1Phi2 bwX49aiL9vMmFQ5f0FTitrLW5eXc2cDACxcFhZyN9cPgHRrnI1NQYAnqS5+whD1qzzvh tYVy7wcqgz8olRdd31wDMh3+lwZOFf66zNDK0SPUWPFjMsYNplfzvPR/GeBfqpYMErhE SnRQ== X-Gm-Message-State: ACgBeo2qolHfByWUnVp+cv/TNYP3YxH2iR+rt55VA76Z0pIyLv0ojZKC H93IHN4AkBjLh0jg0Tt7lm/k5HCptEi0eZ3ipObHDtulOp1kjMDa62vvBQYGMFTONJctEgh5gAg 7ZuDW9JRMXCkEEXTJAVSojTGix/o7UpVbWNgc80luHXHIhxMw7j1kBdZR5ujW4cDj1PFa9yo= X-Received: by 2002:a17:907:7d8e:b0:730:8bd9:6840 with SMTP id oz14-20020a1709077d8e00b007308bd96840mr13080330ejc.370.1659963983498; Mon, 08 Aug 2022 06:06:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR4XtFXt/Zx++tLhW/PRSHStArCJl09H8S9CG4nx0ol1wfrzQ7dNQl+gVQgyalEczTqjU1e53A== X-Received: by 2002:a17:907:7d8e:b0:730:8bd9:6840 with SMTP id oz14-20020a1709077d8e00b007308bd96840mr13080315ejc.370.1659963983183; Mon, 08 Aug 2022 06:06:23 -0700 (PDT) From: Paolo Bonzini To: libvir-list@redhat.com Subject: [PATCH 7/7] qemu: deprecate query-cpus-fast capability Date: Mon, 8 Aug 2022 15:06:08 +0200 Message-Id: <20220808130608.61257-8-pbonzini@redhat.com> In-Reply-To: <20220808130608.61257-1-pbonzini@redhat.com> References: <20220808130608.61257-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1659963997023100001 Content-Type: text/plain; charset="utf-8" All supported versions of QEMU have the command. Signed-off-by: Paolo Bonzini --- src/qemu/qemu_capabilities.c | 4 ++-- src/qemu/qemu_capabilities.h | 2 +- tests/qemuhotplugtest.c | 2 -- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index c2c55f4800..1eb006e3ef 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -468,7 +468,7 @@ VIR_ENUM_IMPL(virQEMUCaps, "qcow2-luks", /* QEMU_CAPS_QCOW2_LUKS */ "pcie-pci-bridge", /* QEMU_CAPS_DEVICE_PCIE_PCI_BRIDGE */ "seccomp-blacklist", /* X_QEMU_CAPS_SECCOMP_BLACKLIST */ - "query-cpus-fast", /* QEMU_CAPS_QUERY_CPUS_FAST */ + "query-cpus-fast", /* X_QEMU_CAPS_QUERY_CPUS_FAST */ "disk-write-cache", /* QEMU_CAPS_DISK_WRITE_CACHE */ =20 /* 290 */ @@ -1212,7 +1212,7 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = =3D { { "query-cpu-model-expansion", QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION }, { "query-cpu-definitions", QEMU_CAPS_QUERY_CPU_DEFINITIONS }, { "query-named-block-nodes", QEMU_CAPS_QUERY_NAMED_BLOCK_NODES }, - { "query-cpus-fast", QEMU_CAPS_QUERY_CPUS_FAST }, + { "query-cpus-fast", X_QEMU_CAPS_QUERY_CPUS_FAST }, { "qom-list-properties", QEMU_CAPS_QOM_LIST_PROPERTIES }, { "blockdev-del", QEMU_CAPS_BLOCKDEV_DEL }, { "query-current-machine", QEMU_CAPS_QUERY_CURRENT_MACHINE }, diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 8f3090e2ce..20b1034ca5 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -447,7 +447,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for = syntax-check */ QEMU_CAPS_QCOW2_LUKS, /* qcow2 format support LUKS encryption */ QEMU_CAPS_DEVICE_PCIE_PCI_BRIDGE, /* -device pcie-pci-bridge */ X_QEMU_CAPS_SECCOMP_BLACKLIST, /* -sandbox.elevateprivileges */ - QEMU_CAPS_QUERY_CPUS_FAST, /* query-cpus-fast command */ + X_QEMU_CAPS_QUERY_CPUS_FAST, /* query-cpus-fast command */ QEMU_CAPS_DISK_WRITE_CACHE, /* qemu block frontends support write-cach= e param */ =20 /* 290 */ diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index 3c9dac241a..133145a23a 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -443,8 +443,6 @@ testQemuHotplugCpuPrepare(const char *test, =20 priv =3D data->vm->privateData; =20 - virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_QUERY_CPUS_FAST); - if (data->modern) virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_QUERY_HOTPLUGGABLE_CPUS); =20 --=20 2.37.1