From nobody Sun Apr 28 09:38:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1659127568; cv=none; d=zohomail.com; s=zohoarc; b=GmKVtog7k7Ixny+/e4xQgqjgX8XGAcZ1j+0gai7ju3q0uEwwFhey9gS4GtpLjScOYfc1QCRXkOFYbWHxDUIjSvaTfBwuoiOLNWKMpzhw7TBQgUWScW5+Z6wEIyUisBiLD9bNHaM4GpBH+9FZtEYl27d+rtUZMg9ITtEsKv0yXbI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659127568; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Lbpx1W+z9NETHTdyVGXZbcnMGGj4bp5tMr90cDNpbck=; b=LzPE1GUC8hNf0iN5UiQvNNc/z8WJ+hpTYDV8IfK/w+NX4lSC1gpa/jrBnbwK5P0Q7CMCdwy8CouSI7pAwzwU2xAOfOaBB8A7KqGUzXMv9Zhl0xR1iqXomVs8CKGZgx0vt8lEQaKb9wp7HT6vSesFHqS4dq8Nv9Em5QVUThtap7E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1659127568406696.1105785204711; Fri, 29 Jul 2022 13:46:08 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-473-OpeiKvv-PuK5K6PfQceFOA-1; Fri, 29 Jul 2022 16:45:11 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 006CE3C0ED78; Fri, 29 Jul 2022 20:45:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E1E39492C3B; Fri, 29 Jul 2022 20:45:07 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6B854194D063; Fri, 29 Jul 2022 20:45:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7BD87194D042 for ; Fri, 29 Jul 2022 20:45:04 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 5E2DB18EB7; Fri, 29 Jul 2022 20:45:04 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A57390A04 for ; Fri, 29 Jul 2022 20:45:04 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3FDF2811E75 for ; Fri, 29 Jul 2022 20:45:04 +0000 (UTC) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by relay.mimecast.com with ESMTP id us-mta-536--WCQfaZpPoyIHAfssTiLxw-1; Fri, 29 Jul 2022 16:45:02 -0400 Received: from prapal-ch2.oiwy50ateaxezb1sqsoezlib2f.xx.internal.cloudapp.net (unknown [20.80.162.67]) by linux.microsoft.com (Postfix) with ESMTPSA id E7B9A20FE9D8 for ; Fri, 29 Jul 2022 13:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659127567; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Lbpx1W+z9NETHTdyVGXZbcnMGGj4bp5tMr90cDNpbck=; b=eyizwjO1Li4t1MP+ivgyHHhk3oI7ds1qS/6oWy+I8Rbkiii5zRhS8x9jwUS9GHgHjXEFvQ hiWVD6mvn9NTelqepUvgTeo5bAU9T7HXDlfRfI8LAGoknoTstA9j6q2DASqg5E+gtf8L5q Vr/XdoeY0fuLIO7zg2jD8owGb4fYtN0= X-MC-Unique: OpeiKvv-PuK5K6PfQceFOA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: -WCQfaZpPoyIHAfssTiLxw-1 DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E7B9A20FE9D8 From: Praveen K Paladugu To: libvir-list@redhat.com Subject: [libvirt PATCH 1/2] ch: drop the check to have a single console/serial Date: Fri, 29 Jul 2022 20:36:56 +0000 Message-Id: <20220729203657.4761-2-prapal@linux.microsoft.com> In-Reply-To: <20220729203657.4761-1-prapal@linux.microsoft.com> References: <20220729203657.4761-1-prapal@linux.microsoft.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1659127569360100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Starting with version 18.0, cloud-hypervisor supports a console and a serial device in parallel. https://github.com/cloud-hypervisor/cloud-hypervisor/issues/3012 Signed-off-by: Praveen K Paladugu --- src/ch/ch_domain.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c index ae53c6fe05..bf687a6c32 100644 --- a/src/ch/ch_domain.c +++ b/src/ch/ch_domain.c @@ -281,14 +281,7 @@ chValidateDomainDeviceDef(const virDomainDeviceDef *de= v, return -1; } =20 - if ((def->nconsoles && - def->consoles[0]->source->type =3D=3D VIR_DOMAIN_CHR_TYPE_PTY) - && (def->nserials && - def->serials[0]->source->type =3D=3D VIR_DOMAIN_CHR_TYPE_PTY))= { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Only a single console or serial can be configure= d for this domain")); - return -1; - } else if (def->nconsoles > 1) { + if (def->nconsoles > 1) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Only a single console can be configured for this= domain")); return -1; --=20 2.27.0 From nobody Sun Apr 28 09:38:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1659127514; cv=none; d=zohomail.com; s=zohoarc; b=L+0KYw+T0fJ4Q+s9wqsNvbaNegB63ZLHXvnyzwP71OTnnnFu4r659Nqwe2oNu4IKDK7z/rzkANUF+ap0OLV8ZRQkYHdIVLW1+Pyi2hAQIVUtkXvkgz15o2wLK/LvisvOL86fTfjR02fkEZHADoBSb8q38Xr6JnNYdGsqLgE1ByY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659127514; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oODdybOjvKSKgbOojWHNV99qEkAewZr4BaQoYUq7tPQ=; b=eGicrFVZf0i+GFEJy34EMLWf2V/gWJ+vPHcFbdLHq8yUIuzVKPrT7ndmznSsUn/WXY3DbNLF24GfZdxVF0/haoT1i+b9GgMzmWwA4ZBDITZmTe0lDotc6jGK9zl/iwRRlf6geBLE6q66Q6f03csbv6+wFTSIGItyziIC8PXPImQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1659127514340480.9209118752012; Fri, 29 Jul 2022 13:45:14 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-277-8x9JyjmFO7u2vcvtgoCoSw-1; Fri, 29 Jul 2022 16:45:10 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BF2598032E3; Fri, 29 Jul 2022 20:45:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63A741121314; Fri, 29 Jul 2022 20:45:05 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 184BE194D063; Fri, 29 Jul 2022 20:45:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4C5B2194D042 for ; Fri, 29 Jul 2022 20:45:04 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2B365400DEF8; Fri, 29 Jul 2022 20:45:04 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast08.extmail.prod.ext.rdu2.redhat.com [10.11.55.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2760440CFD0A for ; Fri, 29 Jul 2022 20:45:04 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0EADE380452B for ; Fri, 29 Jul 2022 20:45:04 +0000 (UTC) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by relay.mimecast.com with ESMTP id us-mta-543-AgHue1eXMFulBXZmhdZ5fA-1; Fri, 29 Jul 2022 16:45:02 -0400 Received: from prapal-ch2.oiwy50ateaxezb1sqsoezlib2f.xx.internal.cloudapp.net (unknown [20.80.162.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 093E920FE9DA for ; Fri, 29 Jul 2022 13:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659127513; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=oODdybOjvKSKgbOojWHNV99qEkAewZr4BaQoYUq7tPQ=; b=DRsKD0rXv8YshCwc/iV9RV/j+Sz5n50ZuoayzgPNJKM5MnmTUbTPaLFSl98BbuoS2RMTg4 Mi2UXctepNXJfusPUsmhD7eWT9O1Rv02AvaSGoYczLKaIn3cc7MIXPusb4wC9lrkwF4xUB 8v8SS+JNDXo69nd/RMV22nfNHlOtpdQ= X-MC-Unique: 8x9JyjmFO7u2vcvtgoCoSw-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: AgHue1eXMFulBXZmhdZ5fA-1 DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 093E920FE9DA From: Praveen K Paladugu To: libvir-list@redhat.com Subject: [libvirt PATCH 2/2] conf: set the default chr device type to pty Date: Fri, 29 Jul 2022 20:36:57 +0000 Message-Id: <20220729203657.4761-3-prapal@linux.microsoft.com> In-Reply-To: <20220729203657.4761-1-prapal@linux.microsoft.com> References: <20220729203657.4761-1-prapal@linux.microsoft.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1659127515851100003 Content-Type: text/plain; charset="utf-8"; x-default="true" explicitly set the chr device type to pty to pass the checks of ch driver. https://gitlab.com/libvirt/libvirt/-/issues/344 Signed-off-by: Praveen K Paladugu --- src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e85cc1f809..abe9d8ae08 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10078,6 +10078,7 @@ virDomainChrSourceDefNew(virDomainXMLOption *xmlopt) =20 if (!(def =3D virObjectNew(virDomainChrSourceDefClass))) return NULL; + def->type =3D VIR_DOMAIN_CHR_TYPE_PTY; =20 if (xmlopt && xmlopt->privateData.chrSourceNew && !(def->privateData =3D xmlopt->privateData.chrSourceNew())) { --=20 2.27.0