[PATCH V2 0/4] Handle physical address bits

Jim Fehlig posted 4 patches 1 year, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220729193436.15575-1-jfehlig@suse.com
docs/formatdomain.rst                         | 23 +++++++
src/conf/cpu_conf.c                           | 63 +++++++++++++++++++
src/conf/cpu_conf.h                           | 17 +++++
src/conf/schemas/cputypes.rng                 | 19 ++++++
src/cpu/cpu_x86.c                             |  8 +++
src/libvirt_private.syms                      |  2 +
src/qemu/qemu_command.c                       | 21 +++++++
src/qemu/qemu_domain.c                        | 46 ++++++++++++++
src/qemu/qemu_validate.c                      | 12 ++++
src/util/virhostcpu.c                         | 55 ++++++++++++++++
src/util/virhostcpu.h                         |  3 +
.../cpu-phys-bits-emulate.xml                 | 20 ++++++
.../cpu-phys-bits-passthrough.xml             | 20 ++++++
tests/genericxml2xmltest.c                    |  3 +
.../cpu-phys-bits-emulate.args                | 32 ++++++++++
.../cpu-phys-bits-emulate.xml                 | 20 ++++++
.../cpu-phys-bits-emulate2.args               | 32 ++++++++++
.../cpu-phys-bits-emulate2.xml                | 20 ++++++
.../cpu-phys-bits-emulate3.err                |  1 +
.../cpu-phys-bits-emulate3.xml                | 20 ++++++
.../cpu-phys-bits-passthrough.args            | 32 ++++++++++
.../cpu-phys-bits-passthrough.xml             | 20 ++++++
.../cpu-phys-bits-passthrough2.err            |  1 +
.../cpu-phys-bits-passthrough2.xml            | 20 ++++++
.../cpu-phys-bits-passthrough3.err            |  1 +
.../cpu-phys-bits-passthrough3.xml            | 20 ++++++
tests/qemuxml2argvtest.c                      |  7 +++
27 files changed, 538 insertions(+)
create mode 100644 tests/genericxml2xmlindata/cpu-phys-bits-emulate.xml
create mode 100644 tests/genericxml2xmlindata/cpu-phys-bits-passthrough.xml
create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate.args
create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate.xml
create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate2.args
create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate2.xml
create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate3.err
create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate3.xml
create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough.args
create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough.xml
create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough2.err
create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough2.xml
create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough3.err
create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough3.xml
[PATCH V2 0/4] Handle physical address bits
Posted by Jim Fehlig 1 year, 8 months ago
Hi All,

This is a V2 of Dario's old patches adding support for specifying the
virtual CPU address size in bits

https://listman.redhat.com/archives/libvir-list/2020-October/210901.html

I've rebased those patches to latest master and tweaked them a bit. E.g.
I removed the qemucaps code since phys-bits and host-phys-bits have been
around before the minimum qemu version supported by libvirt. I also added
patches to expose the number of host address bits and ensure ABI stability
as requested in the old review comments.

Dario Faggioli (2):
  conf: Add support for specifying CPU max physical address size
  qemu: Add support for max physical address size

Jim Fehlig (2):
  capabilities: Report number of host CPU physical address bits
  cpu conf: Check ABI stability of CPU maxphysaddr config

 docs/formatdomain.rst                         | 23 +++++++
 src/conf/cpu_conf.c                           | 63 +++++++++++++++++++
 src/conf/cpu_conf.h                           | 17 +++++
 src/conf/schemas/cputypes.rng                 | 19 ++++++
 src/cpu/cpu_x86.c                             |  8 +++
 src/libvirt_private.syms                      |  2 +
 src/qemu/qemu_command.c                       | 21 +++++++
 src/qemu/qemu_domain.c                        | 46 ++++++++++++++
 src/qemu/qemu_validate.c                      | 12 ++++
 src/util/virhostcpu.c                         | 55 ++++++++++++++++
 src/util/virhostcpu.h                         |  3 +
 .../cpu-phys-bits-emulate.xml                 | 20 ++++++
 .../cpu-phys-bits-passthrough.xml             | 20 ++++++
 tests/genericxml2xmltest.c                    |  3 +
 .../cpu-phys-bits-emulate.args                | 32 ++++++++++
 .../cpu-phys-bits-emulate.xml                 | 20 ++++++
 .../cpu-phys-bits-emulate2.args               | 32 ++++++++++
 .../cpu-phys-bits-emulate2.xml                | 20 ++++++
 .../cpu-phys-bits-emulate3.err                |  1 +
 .../cpu-phys-bits-emulate3.xml                | 20 ++++++
 .../cpu-phys-bits-passthrough.args            | 32 ++++++++++
 .../cpu-phys-bits-passthrough.xml             | 20 ++++++
 .../cpu-phys-bits-passthrough2.err            |  1 +
 .../cpu-phys-bits-passthrough2.xml            | 20 ++++++
 .../cpu-phys-bits-passthrough3.err            |  1 +
 .../cpu-phys-bits-passthrough3.xml            | 20 ++++++
 tests/qemuxml2argvtest.c                      |  7 +++
 27 files changed, 538 insertions(+)
 create mode 100644 tests/genericxml2xmlindata/cpu-phys-bits-emulate.xml
 create mode 100644 tests/genericxml2xmlindata/cpu-phys-bits-passthrough.xml
 create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate.args
 create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate.xml
 create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate2.args
 create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate2.xml
 create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate3.err
 create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate3.xml
 create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough.args
 create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough.xml
 create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough2.err
 create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough2.xml
 create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough3.err
 create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough3.xml

-- 
2.36.1
Re: [PATCH V2 0/4] Handle physical address bits
Posted by Michal Prívozník 1 year, 7 months ago
On 7/29/22 21:34, Jim Fehlig wrote:
> Hi All,
> 
> This is a V2 of Dario's old patches adding support for specifying the
> virtual CPU address size in bits
> 
> https://listman.redhat.com/archives/libvir-list/2020-October/210901.html
> 
> I've rebased those patches to latest master and tweaked them a bit. E.g.
> I removed the qemucaps code since phys-bits and host-phys-bits have been
> around before the minimum qemu version supported by libvirt. I also added
> patches to expose the number of host address bits and ensure ABI stability
> as requested in the old review comments.
> 
> Dario Faggioli (2):
>   conf: Add support for specifying CPU max physical address size
>   qemu: Add support for max physical address size
> 
> Jim Fehlig (2):
>   capabilities: Report number of host CPU physical address bits
>   cpu conf: Check ABI stability of CPU maxphysaddr config
> 

Dario, Jim,

I've went through the patches and they look good. I made couple of
suggestions. Proposed diffs live as a fixup commits on my local branch.
So if you agree with my suggestions I can just squash them before
pushing. Does that work for you?

Michal
Re: [PATCH V2 0/4] Handle physical address bits
Posted by Jim Fehlig 1 year, 7 months ago
On 8/3/22 09:29, Michal Prívozník wrote:
> On 7/29/22 21:34, Jim Fehlig wrote:
>> Hi All,
>>
>> This is a V2 of Dario's old patches adding support for specifying the
>> virtual CPU address size in bits
>>
>> https://listman.redhat.com/archives/libvir-list/2020-October/210901.html
>>
>> I've rebased those patches to latest master and tweaked them a bit. E.g.
>> I removed the qemucaps code since phys-bits and host-phys-bits have been
>> around before the minimum qemu version supported by libvirt. I also added
>> patches to expose the number of host address bits and ensure ABI stability
>> as requested in the old review comments.
>>
>> Dario Faggioli (2):
>>    conf: Add support for specifying CPU max physical address size
>>    qemu: Add support for max physical address size
>>
>> Jim Fehlig (2):
>>    capabilities: Report number of host CPU physical address bits
>>    cpu conf: Check ABI stability of CPU maxphysaddr config
>>
> 
> Dario, Jim,
> 
> I've went through the patches and they look good. I made couple of
> suggestions. Proposed diffs live as a fixup commits on my local branch.
> So if you agree with my suggestions I can just squash them before
> pushing. Does that work for you?

Sure, that's fine. All the suggestions look good. And thanks for the 
clarification on hypervisor specific vs agnostic aspects of postparse and 
validation phases!

Jim