From nobody Sun Apr 28 11:18:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=windriver.com ARC-Seal: i=1; a=rsa-sha256; t=1658307521; cv=none; d=zohomail.com; s=zohoarc; b=DdMA42bH9q+6gydYGL1NWI3oqlhIrcJuKbI5MCFoFoi7KFHdYWfiYYIyOw3fPrlXbs8ksy2yuBIW/n0AfsYhuAXZsvMjCYCzuvW8J6OjckzqIS1qa4jpqGy+rXsPlOZigXT1N/26u42hYKx6+R4idEXTyIPMdsHBJaEDqz9Gllc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658307521; h=Content-Type:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=x5w2nsWVMmJqUsiHsrV4apqejCwJD19rFaKTWpW3UTM=; b=Kq0K+o11LSMY8LW1YUj0So2s7HPvJ3v4LKP1cDWTTDnJvCFKoL7/MjeSAHfl+ZSngD+gJ0jETXEcNtqsKNIkVClTOMRduxJigd5MfX/OGGm9s6JdFemIejmVHWABfLAXtB0wOtxRbc9P7GZOknAR/xOACwUD6AgNfapxcY0GJ9U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1658307521913133.90081397276026; Wed, 20 Jul 2022 01:58:41 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-210-NaicY9lnM3ifU6ZVq0a5ag-1; Wed, 20 Jul 2022 04:58:30 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8D968185A794; Wed, 20 Jul 2022 08:58:28 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1323C492C3B; Wed, 20 Jul 2022 08:58:28 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CC0081947067; Wed, 20 Jul 2022 08:58:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id DC38A1945DA7 for ; Wed, 20 Jul 2022 08:58:24 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6955F2166B29; Wed, 20 Jul 2022 08:58:24 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast10.extmail.prod.ext.rdu2.redhat.com [10.11.55.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6498D2166B26 for ; Wed, 20 Jul 2022 08:58:24 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F3D1F1C0BDFD for ; Wed, 20 Jul 2022 08:58:14 +0000 (UTC) Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-500-8KN_d7BpM_KY0xCvmOR_mA-1; Wed, 20 Jul 2022 04:58:10 -0400 Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26K8ffBC028022 for ; Wed, 20 Jul 2022 01:41:41 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2105.outbound.protection.outlook.com [104.47.70.105]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3hbvuktsqn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 20 Jul 2022 01:41:41 -0700 Received: from MWHPR11MB1358.namprd11.prod.outlook.com (2603:10b6:300:23::8) by SJ0PR11MB4927.namprd11.prod.outlook.com (2603:10b6:a03:2d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Wed, 20 Jul 2022 08:41:38 +0000 Received: from MWHPR11MB1358.namprd11.prod.outlook.com ([fe80::e962:2a9c:c503:db56]) by MWHPR11MB1358.namprd11.prod.outlook.com ([fe80::e962:2a9c:c503:db56%11]) with mapi id 15.20.5438.024; Wed, 20 Jul 2022 08:41:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658307520; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=x5w2nsWVMmJqUsiHsrV4apqejCwJD19rFaKTWpW3UTM=; b=DNwddH630FI2vbWOaxPgJ16CIi7BqV/3Mmob3J4N9roDoJpRDpAOv4+wUhNJ8/H8z1+nja 9PnsGnSkmxUQXstwHVOcQjUgqoCMjIED0fMxZbUGuy/Q5gxeyjbrs7Bo7abEk5RBRjTiR2 lAgcNot6cZ7RhRPgLONYC1HELauAcdw= X-MC-Unique: NaicY9lnM3ifU6ZVq0a5ag-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: 8KN_d7BpM_KY0xCvmOR_mA-1 From: He Zhe To: libvir-list@redhat.com, zhe.he@windriver.com Subject: [PATCH] remote: Make remote_daemon depend on qemu_protocol.h Date: Wed, 20 Jul 2022 16:41:20 +0800 Message-Id: <20220720084120.14207-1-zhe.he@windriver.com> X-ClientProxiedBy: SG2PR04CA0170.apcprd04.prod.outlook.com (2603:1096:4::32) To MWHPR11MB1358.namprd11.prod.outlook.com (2603:10b6:300:23::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fdfa4255-dbbb-42ab-55bc-08da6a2ba8c5 X-MS-TrafficTypeDiagnostic: SJ0PR11MB4927:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: UvediHq6w1LgijsqkqAkVOu1hsMC9Vdj+sB6brP7JQz581S/2wokwcMwNC8bNy1q8bxcUpUxUSAtjkCG75BWviuo8fw1bAIVsTgtZiHJ35kHs4+4H4xET3xbEYo1Regan+Uu9y9ui06cAP6E0A8Jkxs4WotAIz5Nrby52ResPYUhog0MEvtUkrTraOvyz/RSIQL8nyyRyOxvINSD9uTfrFyPxs/vbLksS5F/pVsCrE5q8wV1uBst4XDIg0xdAdqUquzpniEN4CnXz/z7eCDjkEWJvV/QzCy66MoqBJRoRqaHF6GMN73Echc+x96zlZ7ojL4hanayvzpSXxCFYaFhq+ScweVTV7tNibxlGsEcmYnxa8dhRD+GZxMP0aS/b8ZMl6CnnGxFiOpYR/HfsBeRIK3d89RRt0KUZGijhrE7hjfWK/LtrKx6iBpYb1WWcFTUEnDqOX6VNH04pTztdP4ekbmG3Xe5IcgZEM0pZc+Gvp7lUiok/eQ68sKEBX8r6ecH/z032+qkCEG0EZKf32s9y6du4rRaBxuZLIa5L2YgD3HW/4LpYzh/WSCDmNeeHWq3JpWz/+//KpOWrHwnfP07Zh65WEIZu4RT3S7ubIfXT/FDUerwmYsecqSjaXOq+rdr3xLTqBxaz2Cp12j9xCNd7h6t2RPaSpTKDUOa3Cfb7G1WwUXxUB3vDk4iHmcZ2BMFMblv4ciV0z/BPjw4n3ekCefa/d9QI5ocezpoYtyRHdDMTWzgMMWAf8J+A3cmzMHUz/vzgB9dnrrgK8n516Ul3X4otNRMB655WT/7A/RYIsg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1358.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39850400004)(346002)(396003)(366004)(136003)(376002)(6506007)(52116002)(2616005)(26005)(6512007)(478600001)(5660300002)(66946007)(8936002)(2906002)(41300700001)(86362001)(6486002)(1076003)(186003)(83380400001)(6666004)(38100700002)(36756003)(38350700002)(8676002)(316002)(66556008)(66476007); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9YycHIP/10XQ47/Y2r74A6bd4ndKpC75IwCb/WGatUuOEkkMD+XXdx3qGk/p?= =?us-ascii?Q?Ea9ZORjThSdYLdgZox/cr09LpDEmCJUhRT8phi2LJzhWfCzlphjQsm+g6WrX?= =?us-ascii?Q?jB8xf2etXhpPJ7gF9eL4gwZd73IZVT6LYti/0g7IuqEkSky+EVl3PTaMs2Er?= =?us-ascii?Q?MwibD5V5Qs7dmmOeJWM2vYF7FI+17usF5aItqgQxo1eKUYi3sEiZa+L6MeNt?= =?us-ascii?Q?36TZrHTsE1ct7hg2nwuPdeiH4NvlJ4FMu/NPNRUd1s2SoQPQ2SkD+NBmARnB?= =?us-ascii?Q?zzeUOGDfZ8c6vqI0ftbZn/L1GmwVTgB+WHHKYQw2yN3P7Azz03JcBs3tSfsD?= =?us-ascii?Q?FleWV3XqAh1Xj3Pw6pg7UcttNUT+BM6zFUiT/XDgV0rLqw0Truxxb57Proum?= =?us-ascii?Q?/dCFzZ1rukitmRCWCc1mmT33md/KxxYcTCeoWH5LjuWix1H9r0JA15g+B5Hc?= =?us-ascii?Q?JSjx4989Rl4GWh4Xe7L+5DPEpf7fcNqbMU11uM0qH7hehay/R3IeWmpzx/ZY?= =?us-ascii?Q?Re+BW0TKdGSHHDzz6pfgQbUAnfqN8W/7RkXYCQ7KD2ewexp+yEryllF+GRd2?= =?us-ascii?Q?H0HzGswyHOYv2QC9NC3Spt302NjwU0PM5GNvAq0Ve9wtYB/mCNG4e2HaOA+T?= =?us-ascii?Q?bQhjOO8Qf9DhQXb1XDxX/YRx0jnDJqm01j6oJKXq0nfD16dlk6haNGXhTNtM?= =?us-ascii?Q?wqHk0b0kk/0dQj6/x61xU9YyDoYzQ4me4iIwx8lWcvAfg+jCayhAidj7iyPO?= =?us-ascii?Q?14EHcSgY674cV1osCLn3tSdSVilP0QHwXDuMBM+i25eU/EvCVMG8gSMCjJvx?= =?us-ascii?Q?ooCqWezMF6WJRCwtMtClFrcaYuECsnD5u2gk4nxQwgxmI0U1sHHMEP28CirV?= =?us-ascii?Q?DDYh25G7zH+CZGHy9cIKcqfWhBlwJa0Fk+2CUkIr8Q9vpxYM+UmmtGMBAUVc?= =?us-ascii?Q?9+0XteYmuypnErn5kZfBhri4G9mJEnIntvylVHmZsTrKclLq/TImokbvaTCP?= =?us-ascii?Q?RvOVIbOII6pPk96WSf35i/IKOCaLzymiKXvpt0/CrVwB5hihDzvsoSQc+XhW?= =?us-ascii?Q?bIOK1XlQ3nwikfKVbsVegOSWmw4SoyFG9bb9NFFGdXV2do66jcbhYaXLmyqh?= =?us-ascii?Q?mGLrChGKAwZqwQRL8Swp9PXd5SB2DcAaw/1HaF1Kyu9ZWeq6KeP0hvKmBTS+?= =?us-ascii?Q?LxC6sSSPN596DTbh+CPwDBfYcvb8CihudoPqI8k1aFtZvYoW6O44hJU2Gk9Z?= =?us-ascii?Q?+a862RFktME0EOHrQt0cQl2Hnt+4n/fSvdPLFqMh6FjSuwZUCG6QB2xXbyI8?= =?us-ascii?Q?UV0MqA1JACZCY33ZOxUHviKbqd6aCa45E7afYb/1n+0L6ohU6ZxctD2SfUXG?= =?us-ascii?Q?4DoNqLSAg31kNDllzGVjT666tN1yMaqR66ktQpsEoirbeqibMCksaAWjGpAB?= =?us-ascii?Q?nbl9MVOhSilzKvIrnmqXklAKbFS2L44GAqd0iaw/+zotHlWQvYsZ0VHCLDXF?= =?us-ascii?Q?cdwrcaBEopWZ8x9Iz7hcWZuKBB45yfkqRsDx6F/H7rP2fXfDSmh4F1RgUPrA?= =?us-ascii?Q?sMhC3OGOxvFLI5sm0bAwLdtKS67JYS43qWhGc9bb?= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdfa4255-dbbb-42ab-55bc-08da6a2ba8c5 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1358.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 08:41:37.6332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wwxxjrFs0ypP30zV/e+vqcCi0yC8tNOB0d940pX10ef97ndDd9rnOx3u8oo2UxA9YEOADQWT12fqJhI56uGenA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4927 X-Proofpoint-GUID: u1XS-HcLsnvSZ0CEvWGmJhS5g6dwfvw8 X-Proofpoint-ORIG-GUID: u1XS-HcLsnvSZ0CEvWGmJhS5g6dwfvw8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-20_04,2022-07-19_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=643 suspectscore=0 clxscore=1011 malwarescore=0 mlxscore=0 phishscore=0 adultscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207200035 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1658307523289100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We sometimes meet the following parallel compililation issue, since remote_daemon depends on remote_protocol.h qemu_protocol.h and lxc_protocol= .h, which are usually generated due to remote_driver . | FAILED: src/virtnetworkd.p/remote_remote_daemon_dispatch.c.o | x86_64-wrs-linux-gcc ... | In file included from ../libvirt-8.1.0/src/remote/remote_daemon_dispatch.= c:26: | ../libvirt-8.1.0/src/remote/remote_daemon.h:30:10: fatal error: qemu_prot= ocol.h: No such file or directory | 30 | #include "qemu_protocol.h" | | ^~~~~~~~~~~~~~~~~ | compilation terminated. This patch adds the headers as dependencies of remote_daemon to make sure t= hey are always in place in advance. Signed-off-by: He Zhe --- src/remote/meson.build | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/remote/meson.build b/src/remote/meson.build index eb4f7a0068..04525fb4a6 100644 --- a/src/remote/meson.build +++ b/src/remote/meson.build @@ -5,6 +5,15 @@ remote_driver_sources =3D [ =20 remote_driver_generated =3D [] =20 +remote_daemon_sources =3D files( + 'remote_daemon.c', + 'remote_daemon_config.c', + 'remote_daemon_dispatch.c', + 'remote_daemon_stream.c', +) + +remote_daemon_generated =3D [] + foreach name : [ 'remote', 'qemu', 'lxc' ] client_bodies_h =3D '@0@_client_bodies.h'.format(name) protocol_c =3D '@0@_protocol.c'.format(name) @@ -21,7 +30,7 @@ foreach name : [ 'remote', 'qemu', 'lxc' ] capture: true, ) =20 - remote_driver_generated +=3D custom_target( + protocol_h_generated =3D custom_target( protocol_h, input: protocol_x, output: protocol_h, @@ -30,6 +39,9 @@ foreach name : [ 'remote', 'qemu', 'lxc' ] ], ) =20 + remote_driver_generated +=3D protocol_h_generated + remote_daemon_generated +=3D protocol_h_generated + remote_driver_generated +=3D custom_target( protocol_c, input: protocol_x, @@ -42,15 +54,6 @@ foreach name : [ 'remote', 'qemu', 'lxc' ] rpc_probe_files +=3D files(protocol_x) endforeach =20 -remote_daemon_sources =3D files( - 'remote_daemon.c', - 'remote_daemon_config.c', - 'remote_daemon_dispatch.c', - 'remote_daemon_stream.c', -) - -remote_daemon_generated =3D [] - virt_ssh_helper_sources =3D files( 'remote_sockets.c', 'remote_ssh_helper.c', --=20 2.17.1