From nobody Wed May 8 06:36:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1658245259; cv=none; d=zohomail.com; s=zohoarc; b=LvoK+7zKyvTd6s6J13lnLSGRKMqqSDTmEzUbAMmrSonIj+1QlX23bKnD7mJABkS5x8sNkuhDmckRCdKr1m0172+wbu8Q19wMVobOBeJ3NEvFMCLxLMEa3C/HhcfEHW5MjermcxYPRByp/1fVfkP70cduiwBnL8W5KsvccuyHAUE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658245259; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=5n1kC0KeSMdpHLm9TDTE+9Casl4vJ3YxdiGIvV9Ux5g=; b=j82SWhuQhGi56trjdOEOKPSnMAFshKTp6N1L2PhFCfBiaJf9aj5AqHILWqEzQhi5n2HETvMS3VxIa4VWZd7tyZqeIJBxnhgiEVjkgGC9fP6XZ+YexxXcKy+AWhJTgcqFuGlkpmoEQllpiJGIYTcjVWbh/yKMKBcGOoutGJxtL2E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1658245259169934.0214969255277; Tue, 19 Jul 2022 08:40:59 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-589-Q3-b_hOWNzuWHY2wQqt8Mw-1; Tue, 19 Jul 2022 11:40:52 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F4A91C04B6B; Tue, 19 Jul 2022 15:40:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C55851121314; Tue, 19 Jul 2022 15:40:48 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7FACD1947070; Tue, 19 Jul 2022 15:40:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1EBDE1945DA7 for ; Tue, 19 Jul 2022 15:40:47 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EDD3F492CA5; Tue, 19 Jul 2022 15:40:46 +0000 (UTC) Received: from himantopus.redhat.com (unknown [10.22.32.197]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CDB53492C3B for ; Tue, 19 Jul 2022 15:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658245256; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5n1kC0KeSMdpHLm9TDTE+9Casl4vJ3YxdiGIvV9Ux5g=; b=aW1B/ZN4lIlKwWcnF9fWtlDnvrMUwDt7z0g+CkdDaeafvHIkBa6JrixKBpaA3RCgYvHhR3 HpMBQZSwiDOJuwMDHIzNDOmJDVRx87G2xo9Tgj0a7CeP9SH14ni1pHhIs9ymK5rJCJBYBW MKK/KcemUoGadQBU/pgtRcxwGmcw3+k= X-MC-Unique: Q3-b_hOWNzuWHY2wQqt8Mw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Jonathon Jongsma To: libvir-list@redhat.com Subject: [libvirt PATCH] conf: add missing break on a switch case Date: Tue, 19 Jul 2022 10:40:46 -0500 Message-Id: <20220719154046.314662-1-jjongsma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1658245260227100001 Content-Type: text/plain; charset="utf-8"; x-default="true" This was not causing any problems because all cases below were empty, but in order to avoid future misbehavior, add a break to this case. Signed-off-by: Jonathon Jongsma Reviewed-by: Daniel P. Berrang=C3=A9 --- src/conf/node_device_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 51746229fc..364bb489bd 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -770,7 +770,7 @@ virNodeDeviceDefFormat(const virNodeDeviceDef *def) virNodeDeviceCapMdevTypesFormat(&buf, data->ap_matrix.mdev_types, data->ap_matrix.nmdev_type= s); - + break; case VIR_NODE_DEV_CAP_MDEV_TYPES: case VIR_NODE_DEV_CAP_FC_HOST: case VIR_NODE_DEV_CAP_VPORTS: --=20 2.35.3