From nobody Mon Feb 9 10:12:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1656000966; cv=none; d=zohomail.com; s=zohoarc; b=GnJpkbVFpq6uXUhepNnp8FrOtZX7EncPKV4VO8BuHkbEHAxDL6JpBKG2KL4/KlUGE0Qmc7vuFvF4KBHVJZ6NGffZD5FgfPvqWOwY/DSxFarW/c0saS48uHXm1hJv8/5yn/a6jknoYq9eLJAFZ1/RyF+qe9hi4h1KUPSZ0oToaKo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1656000966; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vWuzenxczww/c/boY6gXohboM4guv2oXnsgnkE5Wfe8=; b=N/bPfNlrWA9sN2S7idUf7JBPxQR4EOe5HV+yf1ybBntrNYdyWBzq0aPsIRXq5ZgvCKLfcjtfUiMkk8/SljkRZ242/UoUOaBtkRvYZMA3WnboDjhaevqVoc2Ojz2WgomlG7cRjEm2mLnLBntlIWoZC0g4byfm9m8ueiZcPiJVUmI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1656000966114799.6363284576743; Thu, 23 Jun 2022 09:16:06 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-642-Mh1CAmEGOQiQ0CSDdm3efw-1; Thu, 23 Jun 2022 12:15:19 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B3E9A1828F08; Thu, 23 Jun 2022 16:14:48 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9665F1121314; Thu, 23 Jun 2022 16:14:48 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 31205194B976; Thu, 23 Jun 2022 16:14:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D568F194B959 for ; Thu, 23 Jun 2022 16:14:46 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id C6B8E1121319; Thu, 23 Jun 2022 16:14:46 +0000 (UTC) Received: from harajuku.homenet.telecomitalia.it (unknown [10.40.194.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0B3301121315 for ; Thu, 23 Jun 2022 16:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656000965; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vWuzenxczww/c/boY6gXohboM4guv2oXnsgnkE5Wfe8=; b=Bcp4kF8v2ync0bBSoRbDOjhR9qCQZ8HaWPklEpcjb0/wKzIdnA35EzZBVgmTLXbHZwqgtO 95yjGIkdKLhUWLZ9d9kHtYNkfG/ClH04w5X+/WX118O/OJyD3VY7HzB64/9gceMiPvRK/T EarXD3QI7I0fdvZrYr3CG1l0VeZky94= X-MC-Unique: Mh1CAmEGOQiQ0CSDdm3efw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 05/28] tests: Use minimal hardware for firmware tests Date: Thu, 23 Jun 2022 18:14:17 +0200 Message-Id: <20220623161440.61653-6-abologna@redhat.com> In-Reply-To: <20220623161440.61653-1-abologna@redhat.com> References: <20220623161440.61653-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1656000967989100005 Content-Type: text/plain; charset="utf-8" When testing firmware selection, we don't really care about any of the hardware assigned to the VM, and in fact it's better to keep it as minimal as possible to make sure that the focus remains on the firmware bits. Signed-off-by: Andrea Bolognani --- .../firmware-auto-bios.x86_64-latest.args | 12 +---- tests/qemuxml2argvdata/firmware-auto-bios.xml | 53 +------------------ ...mware-auto-efi-aarch64.aarch64-latest.args | 6 +-- .../firmware-auto-efi-aarch64.xml | 18 +------ ...-auto-efi-loader-secure.x86_64-latest.args | 12 +---- .../firmware-auto-efi-loader-secure.xml | 53 +------------------ ...to-efi-no-enrolled-keys.x86_64-latest.args | 3 -- .../firmware-auto-efi-no-enrolled-keys.xml | 32 +---------- .../firmware-auto-efi.x86_64-latest.args | 12 +---- tests/qemuxml2argvdata/firmware-auto-efi.xml | 53 +------------------ ...manual-bios-rw-implicit.x86_64-latest.args | 8 +-- .../firmware-manual-bios-rw-implicit.xml | 21 +------- ...firmware-manual-bios-rw.x86_64-latest.args | 8 +-- .../firmware-manual-bios-rw.xml | 21 +------- .../firmware-manual-bios.args | 11 +--- .../qemuxml2argvdata/firmware-manual-bios.xml | 26 +-------- .../firmware-manual-efi-acpi-aarch64.args | 1 - .../firmware-manual-efi-acpi-aarch64.xml | 4 +- .../firmware-manual-efi-acpi-q35.args | 1 - .../firmware-manual-efi-acpi-q35.xml | 4 +- .../firmware-manual-efi-no-path.xml | 5 +- .../firmware-manual-efi-noacpi-aarch64.args | 1 - .../firmware-manual-efi-noacpi-aarch64.xml | 4 +- .../firmware-manual-efi-noacpi-q35.xml | 4 +- ...e-manual-efi-nvram-file.x86_64-latest.args | 4 +- .../firmware-manual-efi-nvram-file.xml | 6 +-- ...efi-nvram-network-iscsi.x86_64-latest.args | 4 +- ...irmware-manual-efi-nvram-network-iscsi.xml | 9 +--- ...l-efi-nvram-network-nbd.x86_64-latest.args | 4 +- .../firmware-manual-efi-nvram-network-nbd.xml | 9 +--- ...nual-efi-nvram-template.x86_64-latest.args | 4 +- .../firmware-manual-efi-nvram-template.xml | 6 +-- .../firmware-manual-efi-secure.args | 9 +--- .../firmware-manual-efi-secure.xml | 19 +------ .../qemuxml2argvdata/firmware-manual-efi.args | 7 +-- .../qemuxml2argvdata/firmware-manual-efi.xml | 21 +------- .../firmware-manual-noefi-acpi-aarch64.xml | 7 +-- .../firmware-manual-noefi-acpi-q35.args | 4 -- .../firmware-manual-noefi-acpi-q35.xml | 7 +-- .../firmware-manual-noefi-noacpi-aarch64.args | 4 -- .../firmware-manual-noefi-noacpi-aarch64.xml | 7 +-- .../firmware-manual-noefi-noacpi-q35.args | 4 -- .../firmware-manual-noefi-noacpi-q35.xml | 7 +-- .../firmware-auto-bios.x86_64-latest.xml | 43 ++------------- ...rmware-auto-efi-aarch64.aarch64-latest.xml | 12 ++--- ...e-auto-efi-loader-secure.x86_64-latest.xml | 43 ++------------- ...uto-efi-no-enrolled-keys.x86_64-latest.xml | 37 ++++++++++++- .../firmware-auto-efi.x86_64-latest.xml | 43 ++------------- ...re-manual-efi-nvram-file.x86_64-latest.xml | 9 +--- ...-efi-nvram-network-iscsi.x86_64-latest.xml | 11 ++-- ...al-efi-nvram-network-nbd.x86_64-latest.xml | 11 ++-- .../firmware-manual-efi.xml | 21 ++------ 52 files changed, 111 insertions(+), 634 deletions(-) mode change 120000 =3D> 100644 tests/qemuxml2xmloutdata/firmware-auto-efi-= no-enrolled-keys.x86_64-latest.xml diff --git a/tests/qemuxml2argvdata/firmware-auto-bios.x86_64-latest.args b= /tests/qemuxml2argvdata/firmware-auto-bios.x86_64-latest.args index dd159e2604..1d45a8cfba 100644 --- a/tests/qemuxml2argvdata/firmware-auto-bios.x86_64-latest.args +++ b/tests/qemuxml2argvdata/firmware-auto-bios.x86_64-latest.args @@ -26,17 +26,7 @@ XDG_CONFIG_HOME=3D/tmp/lib/domain--1-fedora/.config \ -mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ -rtc base=3Dutc \ -no-shutdown \ --global ICH9-LPC.disable_s3=3D0 \ --global ICH9-LPC.disable_s4=3D1 \ --boot menu=3Don,strict=3Don \ --device '{"driver":"i82801b11-bridge","id":"pci.1","bus":"pcie.0","addr":"= 0x1e"}' \ --device '{"driver":"pci-bridge","chassis_nr":2,"id":"pci.2","bus":"pci.1",= "addr":"0x0"}' \ --device '{"driver":"ioh3420","port":8,"chassis":3,"id":"pci.3","bus":"pcie= .0","addr":"0x1"}' \ --device '{"driver":"ich9-usb-ehci1","id":"usb","bus":"pcie.0","addr":"0x1d= .0x7"}' \ --device '{"driver":"ich9-usb-uhci1","masterbus":"usb.0","firstport":0,"bus= ":"pcie.0","multifunction":true,"addr":"0x1d"}' \ --device '{"driver":"ich9-usb-uhci2","masterbus":"usb.0","firstport":2,"bus= ":"pcie.0","addr":"0x1d.0x1"}' \ --device '{"driver":"ich9-usb-uhci3","masterbus":"usb.0","firstport":4,"bus= ":"pcie.0","addr":"0x1d.0x2"}' \ +-boot strict=3Don \ -audiodev '{"id":"audio1","driver":"none"}' \ --device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.2","add= r":"0x1"}' \ -sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ -msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/firmware-auto-bios.xml b/tests/qemuxml2= argvdata/firmware-auto-bios.xml index 18ceafa948..0abbddb22e 100644 --- a/tests/qemuxml2argvdata/firmware-auto-bios.xml +++ b/tests/qemuxml2argvdata/firmware-auto-bios.xml @@ -2,67 +2,18 @@ fedora 63840878-0deb-4095-97e6-fc444d9bc9fa 8192 - 8192 1 hvm /some/user/nvram/path/guest_VARS.fd - - - - - - destroy - restart - restart - - - - /usr/bin/qemu-system-x86_64 - -
- - - -
- - - -
- - - -
- - -
- - - - -
- - - - -
- - - - -
- - - - -
- + + diff --git a/tests/qemuxml2argvdata/firmware-auto-efi-aarch64.aarch64-lates= t.args b/tests/qemuxml2argvdata/firmware-auto-efi-aarch64.aarch64-latest.ar= gs index 484905d863..93f808aba9 100644 --- a/tests/qemuxml2argvdata/firmware-auto-efi-aarch64.aarch64-latest.args +++ b/tests/qemuxml2argvdata/firmware-auto-efi-aarch64.aarch64-latest.args @@ -16,7 +16,7 @@ XDG_CONFIG_HOME=3D/tmp/lib/domain--1-aarch64test/.config \ -blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"raw","file":"libvirt-pflash1-storage"}' \ -machine virt-4.0,usb=3Doff,dump-guest-core=3Doff,gic-version=3D2,pflash0= =3Dlibvirt-pflash0-format,pflash1=3Dlibvirt-pflash1-format,memory-backend= =3Dmach-virt.ram \ -accel tcg \ --cpu cortex-a53 \ +-cpu cortex-a15 \ -m 1024 \ -object '{"qom-type":"memory-backend-ram","id":"mach-virt.ram","size":1073= 741824}' \ -overcommit mem-lock=3Doff \ @@ -30,10 +30,6 @@ XDG_CONFIG_HOME=3D/tmp/lib/domain--1-aarch64test/.config= \ -rtc base=3Dutc \ -no-shutdown \ -boot strict=3Don \ --kernel /aarch64.kernel \ --initrd /aarch64.initrd \ --append 'earlyprintk console=3DttyAMA0,115200n8 rw root=3D/dev/vda rootwai= t' \ --dtb /aarch64.dtb \ -audiodev '{"id":"audio1","driver":"none"}' \ -sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ -msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/firmware-auto-efi-aarch64.xml b/tests/q= emuxml2argvdata/firmware-auto-efi-aarch64.xml index 48605f7198..1e8dfffb5b 100644 --- a/tests/qemuxml2argvdata/firmware-auto-efi-aarch64.xml +++ b/tests/qemuxml2argvdata/firmware-auto-efi-aarch64.xml @@ -2,30 +2,16 @@ aarch64test 496d7ea8-9739-544b-4ebd-ef08be936e8b 1048576 - 1048576 1 hvm - /aarch64.kernel - /aarch64.initrd - earlyprintk console=3DttyAMA0,115200n8 rw root=3D/dev/vda roo= twait - /aarch64.dtb - - - - - - cortex-a53 - - - destroy - restart - restart /usr/bin/qemu-system-aarch64 + + diff --git a/tests/qemuxml2argvdata/firmware-auto-efi-loader-secure.x86_64-= latest.args b/tests/qemuxml2argvdata/firmware-auto-efi-loader-secure.x86_64= -latest.args index 1bf6ec65bd..37564db12c 100644 --- a/tests/qemuxml2argvdata/firmware-auto-efi-loader-secure.x86_64-latest.= args +++ b/tests/qemuxml2argvdata/firmware-auto-efi-loader-secure.x86_64-latest.= args @@ -30,17 +30,7 @@ XDG_CONFIG_HOME=3D/tmp/lib/domain--1-fedora/.config \ -mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ -rtc base=3Dutc \ -no-shutdown \ --global ICH9-LPC.disable_s3=3D0 \ --global ICH9-LPC.disable_s4=3D1 \ --boot menu=3Don,strict=3Don \ --device '{"driver":"i82801b11-bridge","id":"pci.1","bus":"pcie.0","addr":"= 0x1e"}' \ --device '{"driver":"pci-bridge","chassis_nr":2,"id":"pci.2","bus":"pci.1",= "addr":"0x0"}' \ --device '{"driver":"ioh3420","port":8,"chassis":3,"id":"pci.3","bus":"pcie= .0","addr":"0x1"}' \ --device '{"driver":"ich9-usb-ehci1","id":"usb","bus":"pcie.0","addr":"0x1d= .0x7"}' \ --device '{"driver":"ich9-usb-uhci1","masterbus":"usb.0","firstport":0,"bus= ":"pcie.0","multifunction":true,"addr":"0x1d"}' \ --device '{"driver":"ich9-usb-uhci2","masterbus":"usb.0","firstport":2,"bus= ":"pcie.0","addr":"0x1d.0x1"}' \ --device '{"driver":"ich9-usb-uhci3","masterbus":"usb.0","firstport":4,"bus= ":"pcie.0","addr":"0x1d.0x2"}' \ +-boot strict=3Don \ -audiodev '{"id":"audio1","driver":"none"}' \ --device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.2","add= r":"0x1"}' \ -sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ -msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/firmware-auto-efi-loader-secure.xml b/t= ests/qemuxml2argvdata/firmware-auto-efi-loader-secure.xml index 67c93fdbb9..1b94c25f32 100644 --- a/tests/qemuxml2argvdata/firmware-auto-efi-loader-secure.xml +++ b/tests/qemuxml2argvdata/firmware-auto-efi-loader-secure.xml @@ -2,67 +2,18 @@ fedora 63840878-0deb-4095-97e6-fc444d9bc9fa 8192 - 8192 1 hvm /some/user/nvram/path/guest_VARS.fd - - - - - - destroy - restart - restart - - - - /usr/bin/qemu-system-x86_64 - -
- - - -
- - - -
- - - -
- - -
- - - - -
- - - - -
- - - - -
- - - - -
- + + diff --git a/tests/qemuxml2argvdata/firmware-auto-efi-no-enrolled-keys.x86_= 64-latest.args b/tests/qemuxml2argvdata/firmware-auto-efi-no-enrolled-keys.= x86_64-latest.args index 57fc34cc4d..b2cc6d3ab8 100644 --- a/tests/qemuxml2argvdata/firmware-auto-efi-no-enrolled-keys.x86_64-late= st.args +++ b/tests/qemuxml2argvdata/firmware-auto-efi-no-enrolled-keys.x86_64-late= st.args @@ -30,9 +30,6 @@ XDG_CONFIG_HOME=3D/tmp/lib/domain--1-fedora/.config \ -rtc base=3Dutc \ -no-shutdown \ -boot strict=3Don \ --device '{"driver":"pcie-root-port","port":8,"chassis":1,"id":"pci.1","bus= ":"pcie.0","multifunction":true,"addr":"0x1"}' \ --device '{"driver":"pcie-root-port","port":9,"chassis":2,"id":"pci.2","bus= ":"pcie.0","addr":"0x1.0x1"}' \ --device '{"driver":"qemu-xhci","id":"usb","bus":"pci.1","addr":"0x0"}' \ -audiodev '{"id":"audio1","driver":"none"}' \ -sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ -msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/firmware-auto-efi-no-enrolled-keys.xml = b/tests/qemuxml2argvdata/firmware-auto-efi-no-enrolled-keys.xml index 352908f745..e9717000a3 100644 --- a/tests/qemuxml2argvdata/firmware-auto-efi-no-enrolled-keys.xml +++ b/tests/qemuxml2argvdata/firmware-auto-efi-no-enrolled-keys.xml @@ -2,49 +2,19 @@ fedora 63840878-0deb-4095-97e6-fc444d9bc9fa 8192 - 8192 1 hvm - - - - - qemu64 - - - destroy - restart - destroy /usr/bin/qemu-system-x86_64 - - - - -
- - - - -
- - -
- - -
- - - -