From nobody Tue Feb 10 16:18:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1653327543; cv=none; d=zohomail.com; s=zohoarc; b=MNXcG18HGKMhO8tPYpaG9iJR20HdpSnv3kckQl/r189jMrDsRILQMEfOg0hfge2sIpLnpCknDBszNzL+ZfFk3ZQ6yrW7V77B00eipfGqU2aYUEjypfCnKN9+2X2swWkIwVKLRYfRyq/IpdY1uwPT3yVLW7iNpiix1DNY0rQ9VOE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653327543; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xHWsiFxtJrzp9yZ5HEiyMYIY7aLzILAHrK8qKlt/jOI=; b=HAQ634Ya/ij/bLgAeMzPQ/AyPt4eotfsw09lEZDK/ikKXwDstfxGgDAVP5d9BfnESXQsarjr62vIup4WuKnsfjqx/sb8DPJEFqaW8HQnmN3ZdnMKCmdee3UlIHc2MK923XwkingjOeis8QNZg78rnOWrjQ/tF1CvcceKS73Pflw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1653327543604120.40948400673585; Mon, 23 May 2022 10:39:03 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-657-jA42SgKmP4WNFEYQkZgglA-1; Mon, 23 May 2022 13:38:05 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1ADCF299E762; Mon, 23 May 2022 17:38:03 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD90040D2822; Mon, 23 May 2022 17:38:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7F341194705A; Mon, 23 May 2022 17:38:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6F4FF1947059 for ; Mon, 23 May 2022 17:38:01 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 5DE33112131E; Mon, 23 May 2022 17:38:01 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.40.192.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE478112131B for ; Mon, 23 May 2022 17:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653327542; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xHWsiFxtJrzp9yZ5HEiyMYIY7aLzILAHrK8qKlt/jOI=; b=XDOGAY8m2HYex9j5ut3zkQ2HSsr1AG3w9q4RF57+35GktXTwXxJPNY61R+uzc1u4TUD3yG Bmq2/cl20XXQ591F0wguXaM6FzSoq4M4AwJay1bUA0jnwPIjmvO4UtuKhoiC6cFU26x08H cOpQv98Jb1PfZBQq2qsMaufT8gYt5JM= X-MC-Unique: jA42SgKmP4WNFEYQkZgglA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 06/13] syntax-check: Simplify VC_LIST_ALWAYS_EXCLUDE_REGEX Date: Mon, 23 May 2022 19:37:47 +0200 Message-Id: <20220523173754.336735-7-abologna@redhat.com> In-Reply-To: <20220523173754.336735-1-abologna@redhat.com> References: <20220523173754.336735-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1653327543977100001 Content-Type: text/plain; charset="utf-8" Most of the pattern is no longer relevant, because the files it was intended to match have been dropped from the repository. Specifically: files commit date ------------------ ------------ ---------- *.gif 6cb131e5cbd0 2022-01-19 *.fig 9ad637c9651f 2020-07-10 docs/news*.html.in f45735786a3d 2020-06-02 docs/*.patch 6be034a8c062 2018-08-23 We can also avoid having a fallback value for the pattern: that made sense when the implementation was coming from gnulib, as they wouldn't be able to know in advance if the user would need to provide their own exclude patterns, but that scenario is no longer relevant to us. Signed-off-by: Andrea Bolognani --- build-aux/syntax-check.mk | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index d6f2a0602d..1252cb8eb4 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -40,10 +40,6 @@ _equal =3D $(and $(findstring $(1),$(2)),$(findstring $(= 2),$(1))) VC_LIST =3D cd $(top_srcdir); git ls-tree -r 'HEAD:' | \ sed -n "s|^100[^ ]*.||p" =20 -# You can override this variable in syntax-check.mk to set your own regexp -# matching files to ignore. -VC_LIST_ALWAYS_EXCLUDE_REGEX ?=3D ^$$ - # This is to preprocess robustly the output of $(VC_LIST), so that even # when $(top_srcdir) is a pathological name like "....", the leading sed c= ommand # removes only the intended prefix. @@ -110,7 +106,7 @@ syntax-check: $(local-check) =20 # Files that should never cause syntax check failures. VC_LIST_ALWAYS_EXCLUDE_REGEX =3D \ - (^(docs/(news(-[0-9]*)?\.html\.in|.*\.patch))|\.(po|fig|gif|ico|png))$$ + \.(po|ico|png)$$ =20 # Avoid uses of write(2). Either switch to streams (fwrite), or use # the safewrite wrapper. --=20 2.35.3