From nobody Mon Feb 9 20:59:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.74 as permitted sender) client-ip=170.10.133.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1651767087; cv=none; d=zohomail.com; s=zohoarc; b=g8/TAk9rGDQ5GYwQzytiW/SkkjHdV7t8hdS6iRTAWWzRSfErp9HX30/y480vopa7G24Wj/x+/7Wuz3NB/qSpuK8FqAPZ/AczUQ/Pzp/WLrJE8wvxWxMu208JkWgzF2J3bZPEunilq4/Ll8gPXQHMtAVAraem2pKCqIJJa4JNnGg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651767087; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8pFUGlovvr8Q+aruXmH1NTLsT1vqJHZ6UBiVroupZs4=; b=D+bJskfKich6as1oAGlHlGP06wq+vBZAyYbvMeEQSUNSyVrsHJdGkwLZDx+Y9lHzMNgjt3uVSH4FQm6Pp8OP2rJWawodJ+8jaaZzwIWx4yagbq4954Wa+FWGabtMz0N07wdBXTT6qTSq+1VSzree0JwCXgZVeRM+IJ28q2Jvg0c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.133.74]) by mx.zohomail.com with SMTPS id 1651767087184275.54357233286385; Thu, 5 May 2022 09:11:27 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-516-SXS4u51_OD-_jqFnTSEFWg-1; Thu, 05 May 2022 12:11:22 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 47FC83C02B79; Thu, 5 May 2022 16:11:20 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 32551C28119; Thu, 5 May 2022 16:11:20 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B467F1947047; Thu, 5 May 2022 16:11:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5F4AB1947043 for ; Thu, 5 May 2022 16:11:18 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2F5267AEB; Thu, 5 May 2022 16:11:18 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.40.193.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B3310BC86 for ; Thu, 5 May 2022 16:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651767086; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8pFUGlovvr8Q+aruXmH1NTLsT1vqJHZ6UBiVroupZs4=; b=N2xEyju6UY/TRKhV6Zwj015URs6EakGMBI8xNMvw2hsWyBZ2tEI7kSArK8nfe7L28BIGHy ROMPjHBT4AxSlsrsX2Ll6ZwmcMSIWgQRMLOP+CxOOiE5u/43n7uXwoV2wLjADJ+GcXH54i Q+gruIecBdb6Zf7S8PnNueNLpClauJ8= X-MC-Unique: SXS4u51_OD-_jqFnTSEFWg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 2/3] meson: Don't attempt to use version scripts on macOS Date: Thu, 5 May 2022 18:10:59 +0200 Message-Id: <20220505161100.418597-3-abologna@redhat.com> In-Reply-To: <20220505161100.418597-1-abologna@redhat.com> References: <20220505161100.418597-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1651767087817100001 Content-Type: text/plain; charset="utf-8" macOS libraries don't support symbol versioning, so the only result that we achieve by passing additional flags to the linker is a bunch of messages like ld: warning: ignoring file .../libvirt/build/src/libvirt.syms, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0x23 0x20 0x57 0x41 ... ) being produced during the build. Signed-off-by: Andrea Bolognani --- meson.build | 3 +++ src/admin/meson.build | 14 ++++++++------ src/meson.build | 42 ++++++++++++++++++++++++------------------ tools/nss/meson.build | 18 ++++++++++++------ 4 files changed, 47 insertions(+), 30 deletions(-) diff --git a/meson.build b/meson.build index 17cc829543..5787397dcd 100644 --- a/meson.build +++ b/meson.build @@ -510,6 +510,9 @@ libvirt_no_indirect =3D cc.get_supported_link_arguments= ([ =20 if host_machine.system() =3D=3D 'windows' version_script_flags =3D '-Wl,' +elif host_machine.system() =3D=3D 'darwin' + # macOS libraries don't support symbol versioning + version_script_flags =3D '' else test_file =3D '@0@/src/libvirt_qemu.syms'.format(meson.source_root()) if cc.has_link_argument('-Wl,--version-script=3D@0@'.format(test_file)) diff --git a/src/admin/meson.build b/src/admin/meson.build index cacd6feb25..692cc128a3 100644 --- a/src/admin/meson.build +++ b/src/admin/meson.build @@ -92,14 +92,16 @@ endif =20 libvirt_admin_link_args =3D [ libvirt_nodelete, - '@0@@1@'.format( +] +libvirt_admin_link_depends =3D [] + +if version_script_flags !=3D '' + libvirt_admin_link_args +=3D '@0@@1@'.format( version_script_flags, libvirt_admin_syms_path, - ), -] -libvirt_admin_link_depends =3D [ - libvirt_admin_syms_file, -] + ) + libvirt_admin_link_depends +=3D libvirt_admin_syms_file +endif =20 if conf.has('WITH_REMOTE') admin_driver_lib =3D static_library( diff --git a/src/meson.build b/src/meson.build index ca0e756e5c..88a6f15760 100644 --- a/src/meson.build +++ b/src/meson.build @@ -379,14 +379,16 @@ libvirt_link_args =3D [ libvirt_flat_namespace, libvirt_no_undefined, libvirt_nodelete, - '@0@@1@'.format( +] +libvirt_link_depends =3D [] + +if version_script_flags !=3D '' + libvirt_link_args +=3D '@0@@1@'.format( version_script_flags, libvirt_syms_path, - ), -] -libvirt_link_depends =3D [ - libvirt_syms_file, -] + ) + libvirt_link_depends +=3D libvirt_syms_file +endif =20 libvirt_lib =3D shared_library( 'virt', @@ -431,14 +433,16 @@ endif =20 libvirt_qemu_link_args =3D [ libvirt_nodelete, - '@0@@1@'.format( +] +libvirt_qemu_link_depends =3D [] + +if version_script_flags !=3D '' + libvirt_qemu_link_args +=3D '@0@@1@'.format( version_script_flags, libvirt_qemu_syms_path, - ), -] -libvirt_qemu_link_depends =3D [ - libvirt_qemu_syms_file, -] + ) + libvirt_qemu_link_depends +=3D libvirt_qemu_syms_file +endif =20 libvirt_qemu_sources =3D files( 'libvirt-qemu.c', @@ -488,14 +492,16 @@ endif =20 libvirt_lxc_link_args =3D [ libvirt_nodelete, - '@0@@1@'.format( +] +libvirt_lxc_link_depends =3D [] + +if version_script_flags !=3D '' + libvirt_lxc_link_args +=3D '@0@@1@'.format( version_script_flags, libvirt_lxc_syms_path, - ), -] -libvirt_lxc_link_depends =3D [ - libvirt_lxc_syms_file, -] + ) + libvirt_lxc_link_depends +=3D libvirt_lxc_syms_file +endif =20 libvirt_lxc_sources =3D files( 'libvirt-lxc.c', diff --git a/tools/nss/meson.build b/tools/nss/meson.build index c827b865b3..85e2838fb7 100644 --- a/tools/nss/meson.build +++ b/tools/nss/meson.build @@ -55,11 +55,14 @@ nss_libvirt_syms_path =3D nss_libvirt_syms_file nss_libvirt_link_args =3D [ libvirt_export_dynamic, coverage_flags, - '@0@@1@'.format( +] + +if version_script_flags !=3D '' + nss_libvirt_link_args +=3D '@0@@1@'.format( version_script_flags, nss_libvirt_syms_path, - ), -] + ) +endif =20 nss_libvirt_lib =3D shared_library( 'nss_libvirt', @@ -79,11 +82,14 @@ nss_libvirt_guest_syms_path =3D nss_libvirt_guest_syms_= file nss_libvirt_guest_link_args =3D [ libvirt_export_dynamic, coverage_flags, - '@0@@1@'.format( +] + +if version_script_flags !=3D '' + nss_libvirt_guest_link_args +=3D '@0@@1@'.format( version_script_flags, nss_libvirt_guest_syms_path, - ), -] + ) +endif =20 nss_libvirt_guest_lib =3D shared_library( 'nss_libvirt_guest', --=20 2.35.1