From nobody Mon Feb 9 20:58:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=nutanix.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1651683128069646.7531074961289; Wed, 4 May 2022 09:52:08 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-511-Fx_yR6L5N3y4-VO9jdczDw-1; Wed, 04 May 2022 12:51:48 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E50BC38149A8; Wed, 4 May 2022 16:51:45 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB1A740D2820; Wed, 4 May 2022 16:51:45 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 79FC01947046; Wed, 4 May 2022 16:51:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9B2BB1947043 for ; Wed, 4 May 2022 16:51:44 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 8AF862024CAE; Wed, 4 May 2022 16:51:44 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 857852026614 for ; Wed, 4 May 2022 16:51:41 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1A3CA29AB45F for ; Wed, 4 May 2022 16:51:41 +0000 (UTC) Received: from mx0b-002c1b01.pphosted.com (mx0b-002c1b01.pphosted.com [148.163.155.12]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-121-0SmWbRc9P-eDSovhg75t0w-1; Wed, 04 May 2022 12:51:39 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 244APBDr029549 for ; Wed, 4 May 2022 09:51:39 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 3fs37h8fsq-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 04 May 2022 09:51:37 -0700 Received: from SJ0PR02MB8564.namprd02.prod.outlook.com (2603:10b6:a03:3f6::16) by DM5PR02MB2699.namprd02.prod.outlook.com (2603:10b6:3:107::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 16:51:35 +0000 Received: from SJ0PR02MB8564.namprd02.prod.outlook.com ([fe80::8ac:200b:2dc3:5e99]) by SJ0PR02MB8564.namprd02.prod.outlook.com ([fe80::8ac:200b:2dc3:5e99%5]) with mapi id 15.20.5206.024; Wed, 4 May 2022 16:51:34 +0000 X-MC-Unique: Fx_yR6L5N3y4-VO9jdczDw-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: 0SmWbRc9P-eDSovhg75t0w-1 From: Rohit Kumar To: libvir-list@redhat.com Subject: [PATCH v3 5/5] Add unit test to support new 'file' type NVRAM Date: Wed, 4 May 2022 09:51:15 -0700 Message-Id: <20220504165115.1225892-6-rohit.kumar3@nutanix.com> In-Reply-To: <20220504165115.1225892-1-rohit.kumar3@nutanix.com> References: <20220504165115.1225892-1-rohit.kumar3@nutanix.com> X-ClientProxiedBy: BYAPR06CA0043.namprd06.prod.outlook.com (2603:10b6:a03:14b::20) To SJ0PR02MB8564.namprd02.prod.outlook.com (2603:10b6:a03:3f6::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d8c5db4-f9d9-4755-1a1b-08da2dee586b X-MS-TrafficTypeDiagnostic: DM5PR02MB2699:EE_ X-Microsoft-Antispam-PRVS: x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: RUFobzTV8asfTW6W8z9A3JyGFJIDCxrrBwUvseNHN4XVi6R698kvG/ODLUjD4UpKlJsJoxsDWHBCCjiXgDwSNj2DUGYIVbU6twoS55u1xSfwml5fq54/bk8YrTUkgTlDyqIHuL37EJzApgetTQfhWqDMZvDd65mJzhau3yPzUiKd0JH5wqorGRxS89tdDsOjCvwojI04xtbls0kXPgZNtptxzMeJUd3yb0VUnchEb+qfGxGOELHK9GJ/1QBQr2G+pBmIVWzO0/Fr3h7+3P44CTKYJZn78XSNBWZnBw7Cglq4gZeLfqn3vQg5y/iFKGctrKDcmOuWrNAwobOkR7BgJeP7IM/zbWMkwUf1w4do7RVQ80vk9BrCY5Lr9qCLWxk4Ik8sEB7xvwllwZj1lGJlPOZ7+bzgRByTcnzm0EeM7LYPG+KYwBwEB60NEGW9+eXM5OiPaHyKhCfXknWYX8GZnGvQ3zLvmPbub+KZxrQtCmVM8/JF0g2L/+GekwjQa7jXretNRxqtcvz51qOM05oQa/7pybmc26PjeHx4DDHVsQPHL+3RZkTOogYIU4zgJVZLq1k1wwH6hpXsZvD/NjVKEsB1m0SdjzA1KoeJoKt7kLeUdj+8QHGYSQJnbIt2GPA/oNnas9DKXiK4pgbKMhpCAqcsvZtDDo2fJIDTS+l9G5JX94pw3FRhCIPmw1NxDRmr4XPbmrW8e06Lr54Hga3ZvQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR02MB8564.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66556008)(66946007)(8936002)(66476007)(5660300002)(86362001)(6916009)(2906002)(4326008)(8676002)(316002)(6486002)(508600001)(186003)(52116002)(36756003)(26005)(6512007)(2616005)(1076003)(107886003)(38100700002)(38350700002)(6506007)(6666004)(83380400001); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lzdnGQlxUrawxw23f7MS9sERKV9dvpaEaSB4qLF31/MwwimZUPHRW7glu3Yq?= =?us-ascii?Q?JAyjKC35AooODNM1+PCAWicxsCCIl0xlzeb0YR8o0+RpZiiNiYBR6UePiEKk?= =?us-ascii?Q?CaZJZMYdxcL5Oq0W4hsOqLRaB0bd+si7pyH7okNkeigDio/pT/9If1wF9gbJ?= =?us-ascii?Q?dO6VTr3XmMSjfJIoeA7e6404ekR8DbdB9FepJizkFHsW34apb7zdM8wM1aPd?= =?us-ascii?Q?b0Wd9Jcc68/mhKMzJkV8VHmJn+zkwSl+2LW4QYaRF9NkY6uUrfJTKxQDwsPS?= =?us-ascii?Q?b6YFrUPl08zQ1Fep70uvE7AHe9OgDsWsTjD8G0H7B2gCuxPycZMregn+tqM9?= =?us-ascii?Q?C3WQZwH5Ueu8f7kfN0WCppJvYu9u123909bc8qTro9TUfJyEr8I20w8Y1gFP?= =?us-ascii?Q?CuMOguV4fj4eG567kb9IRaIIoya9zyO+hU4BuUqC/YXehMQpSFkuFMEEqZZf?= =?us-ascii?Q?CWkO1N2SrpnAX+MlGRLC6ykwo+3HwJUfuZK0inCIPfBsnVxo0wr6MQRx78I4?= =?us-ascii?Q?O7lidIe42IsCwnurBuMxonKx8PngOxxRfhzLhafzFn2XuMrr4/uHRpOo4I5P?= =?us-ascii?Q?XurrKhZJZ6DfZKwEDZNYrzHuyBJC2m2XR8ZcHtai2Apl6mBVVPOgjfg2EO1X?= =?us-ascii?Q?TzhRXVDiHWSWH5fIQLJG0IaORdrNB8tOnBL1rC5gzrnQejEz/iiylmKGiMMO?= =?us-ascii?Q?FK7Zj6UZLFTfU2PJ5MwI8bi3mZygJ7Nre9WTFtKivS6/6aqi/pWWRjr6uEjf?= =?us-ascii?Q?sIQIe2eBf+7maVn3vKoh0v1ljvVyxGfXUGTwhEke9lVSDZgfsVcQ+JN6Y/oD?= =?us-ascii?Q?wW3PdEsvcsGUEzX3I86BsQMOj6p73BttYBld4xXk5ZZ1f6I90n3XK9wiw8YK?= =?us-ascii?Q?EEufpHjn933NSwt/vdBrqRO77peoCpn1ZmzLLZsMAZ/lzNsi4lmIoBggxiOG?= =?us-ascii?Q?Vde4zjraAq6cy3k4EREdHXmULH8+cZMFc4nv3rhy15ZEKoP0KHd5Lyd83JYo?= =?us-ascii?Q?5q+Y+iDPUfW1Azj1zZSiPI4dmFWt22/+1nIbk8pY5MEOUbehanOKhYgWwyPe?= =?us-ascii?Q?YuaX8XxJ8tvYKQXozBvwOh+Yh0dSkH/uD/eyY7uy5793ZVVutmzjh5Kd3KSR?= =?us-ascii?Q?wi4MpN0WyGK0GhsmwkdlYBNjaXCZozHEeCkG0I87X0Kquj0LajY0DTE4fGT8?= =?us-ascii?Q?suFyWtrIqRt+hGfdXY8QvQ3PfAfuxgtaICZic7dnAJDxeSo7lvm4KmsmqbtY?= =?us-ascii?Q?95E2W20c9/wMOyX69Udy2LRlKOmohBceK1chHR8kq0rT24n1eOvZcaCE7q8b?= =?us-ascii?Q?3C4mO2hX9MqczBbHO+n7EIY0oIGQC+KhD/3vrcaTr3NoG2kRKGN7n/w2ZZ+W?= =?us-ascii?Q?1fzhVX+UprS8k51JVrUF1POzoscWfZqY1c576eoPZj4e/w9GjLey9YS47cxT?= =?us-ascii?Q?LdtMjbcVy80xUSO1LbqXJ3cYNFj39YRvlNLiW/jwYX4dCZAeRCvIMUp9Zf4e?= =?us-ascii?Q?8mx0PbVS5xopaNDgM6L5ixKe0xaaeqO3rB99qo0PuM0kVIkMascmx5gz5REP?= =?us-ascii?Q?wtqf+ULGvUM6lDklpL4PipASVLCdcKHKz1IVGz8e3AbC/UohcCEYizKFNBRu?= =?us-ascii?Q?3DIRJi++h1qkhlYnNkzCgWZWJFSx2GO2NfFoQJ/aZodx0E0tY4M+kvP/TXPa?= =?us-ascii?Q?BXeajkXyv5SDiJpL8+yIZ0VchjTkfvQaBuoLZ5A1w2BsUIUujddv9IW5/Yn2?= =?us-ascii?Q?CXBChkSKnduhvlgMTgKfbAI9/D+ddMU=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d8c5db4-f9d9-4755-1a1b-08da2dee586b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR02MB8564.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 16:51:33.6476 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YQxLcFcUOJZEYvpyJ5FjcRdpW4NX6mU+lBtAE7EsqB6RuT3GiJf0k1UPOY2kBpab9LFPCe8LoHmjpJMupZhcB50jOu3QS5DJo5prnT23Obk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB2699 X-Proofpoint-ORIG-GUID: 6jDoA1hDRe-Ss1KFhOd0deKzRvBOMGZ3 X-Proofpoint-GUID: 6jDoA1hDRe-Ss1KFhOd0deKzRvBOMGZ3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-04_04,2022-05-04_02,2022-02-23_01 X-Proofpoint-Spam-Reason: safe X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: prachatos.mitra@nutanix.com, Rohit Kumar , flosch@nutanix.com, prerna.saxena@nutanix.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1651683128527100001 Content-Type: text/plain; charset="utf-8" This patch adds an unit test to test xml when NVRAM type 'file' is provided. Example: Signed-off-by: Prerna Saxena Signed-off-by: Florian Schmidt Signed-off-by: Rohit Kumar --- .../bios-nvram-file.x86_64-latest.args | 37 ++++++++++++++++++ tests/qemuxml2argvdata/bios-nvram-file.xml | 23 +++++++++++ tests/qemuxml2argvtest.c | 1 + .../bios-nvram-file.x86_64-latest.xml | 39 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 5 files changed, 101 insertions(+) create mode 100644 tests/qemuxml2argvdata/bios-nvram-file.x86_64-latest.ar= gs create mode 100644 tests/qemuxml2argvdata/bios-nvram-file.xml create mode 100644 tests/qemuxml2xmloutdata/bios-nvram-file.x86_64-latest.= xml diff --git a/tests/qemuxml2argvdata/bios-nvram-file.x86_64-latest.args b/te= sts/qemuxml2argvdata/bios-nvram-file.x86_64-latest.args new file mode 100644 index 0000000000..4b0aec7539 --- /dev/null +++ b/tests/qemuxml2argvdata/bios-nvram-file.x86_64-latest.args @@ -0,0 +1,37 @@ +LC_ALL=3DC \ +PATH=3D/bin \ +HOME=3D/tmp/lib/domain--1-test-bios \ +USER=3Dtest \ +LOGNAME=3Dtest \ +XDG_DATA_HOME=3D/tmp/lib/domain--1-test-bios/.local/share \ +XDG_CACHE_HOME=3D/tmp/lib/domain--1-test-bios/.cache \ +XDG_CONFIG_HOME=3D/tmp/lib/domain--1-test-bios/.config \ +/usr/bin/qemu-system-x86_64 \ +-name guest=3Dtest-bios,debug-threads=3Don \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/tm= p/lib/domain--1-test-bios/master-key.aes"}' \ +-blockdev '{"driver":"file","filename":"/usr/share/OVMF/OVMF_CODE.fd","nod= e-name":"libvirt-pflash0-storage","auto-read-only":true,"discard":"unmap"}'= \ +-blockdev '{"node-name":"libvirt-pflash0-format","read-only":true,"driver"= :"raw","file":"libvirt-pflash0-storage"}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/nvram/guest_VARS.= fd","node-name":"libvirt-pflash1-storage","auto-read-only":true,"discard":"= unmap"}' \ +-blockdev '{"node-name":"libvirt-pflash1-format","read-only":false,"driver= ":"raw","file":"libvirt-pflash1-storage"}' \ +-machine pc,usb=3Doff,dump-guest-core=3Doff,pflash0=3Dlibvirt-pflash0-form= at,pflash1=3Dlibvirt-pflash1-format,memory-backend=3Dpc.ram \ +-accel tcg \ +-cpu qemu64 \ +-m 1024 \ +-object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":1073741824}= ' \ +-overcommit mem-lock=3Doff \ +-smp 1,sockets=3D1,cores=3D1,threads=3D1 \ +-uuid 362d1fc1-df7d-193e-5c18-49a71bd1da66 \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ +-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ +-rtc base=3Dutc \ +-no-shutdown \ +-boot menu=3Don,strict=3Don \ +-device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.0","addr":"0x1.0= x2"}' \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.0","add= r":"0x2"}' \ +-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ +-msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/bios-nvram-file.xml b/tests/qemuxml2arg= vdata/bios-nvram-file.xml new file mode 100644 index 0000000000..8df9412112 --- /dev/null +++ b/tests/qemuxml2argvdata/bios-nvram-file.xml @@ -0,0 +1,23 @@ + + test-bios + 362d1fc1-df7d-193e-5c18-49a71bd1da66 + 1048576 + 1048576 + 1 + + hvm + /usr/share/OVMF/OVMF_CODE.fd<= /loader> + + + + + + + + + + + + /usr/bin/qemu-system-x86_64 + + diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index c00aa7e049..5fae9a1e42 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1201,6 +1201,7 @@ mymain(void) DO_TEST_CAPS_LATEST("bios-nvram-network-iscsi"); DO_TEST_CAPS_VER_PARSE_ERROR("bios-nvram-network-iscsi", "4.1.0"); DO_TEST_CAPS_LATEST("bios-nvram-network-nbd"); + DO_TEST_CAPS_LATEST("bios-nvram-file"); =20 /* Make sure all combinations of ACPI and UEFI behave as expected */ DO_TEST_NOCAPS("q35-acpi-uefi"); diff --git a/tests/qemuxml2xmloutdata/bios-nvram-file.x86_64-latest.xml b/t= ests/qemuxml2xmloutdata/bios-nvram-file.x86_64-latest.xml new file mode 100644 index 0000000000..97e029f70b --- /dev/null +++ b/tests/qemuxml2xmloutdata/bios-nvram-file.x86_64-latest.xml @@ -0,0 +1,39 @@ + + test-bios + 362d1fc1-df7d-193e-5c18-49a71bd1da66 + 1048576 + 1048576 + 1 + + hvm + /usr/share/OVMF/OVMF_CODE.fd<= /loader> + + + + + + + + + + + qemu64 + + + destroy + restart + destroy + + /usr/bin/qemu-system-x86_64 + +
+ + + + +