From nobody Tue Feb 10 21:19:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1650655458; cv=none; d=zohomail.com; s=zohoarc; b=ZRCEgVBpJbbNPzcxweDKu65YipBvXGPe3qha2UGjneDbgfiJdrBQmQX20zrnl/KynRD2HaI+FwzTbkb+cwDr2o3ojDTeQ2gdJ3LJhm0o8xzT9OU/VSdaJzNHM3TjKthZvHJM4ORv8nqkxbLQwJhFDldPUAZVrT+jZJjQtuFgBZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650655458; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BVrhyCFaKsLkJ6P+L5hsxtRRQI5xt28aZx9HI4UgNbw=; b=GmrnhbIM4phL01/TVP3hXebjYAU3pe9LWwrunTK732ls2O7QoB6mEeX711atGoRSkBWcDxislnXNJ9FCcKjrws6L2UmtiQuDuYlcqLeX5shnzAI7HJ7SIvJoYNYzi1o10ixIaDsWww86ibFdd2HAzZ9xB4UyPaMxELgQmKyZods= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1650655458385192.08274589982102; Fri, 22 Apr 2022 12:24:18 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-551-stn64MeEO3u6PAAuWAdY0g-1; Fri, 22 Apr 2022 15:24:12 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1D12A1014A85; Fri, 22 Apr 2022 19:24:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 08F3BC44AE5; Fri, 22 Apr 2022 19:24:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 640ED1940363; Fri, 22 Apr 2022 19:24:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 559781940358 for ; Fri, 22 Apr 2022 19:24:06 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 227CE2026614; Fri, 22 Apr 2022 19:24:06 +0000 (UTC) Received: from tapioca.home (unknown [10.40.194.99]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8ACAC200C0CF for ; Fri, 22 Apr 2022 19:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650655457; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BVrhyCFaKsLkJ6P+L5hsxtRRQI5xt28aZx9HI4UgNbw=; b=hts8zOXAiZHLxj+ZPUvM6YuqRq9z0ARVLPAfLHO44eq4t7mxU2mxz7JMiMoyiy9oTUqj8P MMSzuvAxSzO5YgsR6mpNWx/kdemhXRUlEkb2UUnTkkXDQ2dg0ogFBEkWalazThLDQIZToF eSte4YIuAHyTckftmc51tReDnYK55MA= X-MC-Unique: stn64MeEO3u6PAAuWAdY0g-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Victor Toso To: libvir-list@redhat.com Subject: [PATCH v4 05/19] docstring: remove comments between enum values Date: Fri, 22 Apr 2022 21:23:30 +0200 Message-Id: <20220422192344.830350-6-victortoso@redhat.com> In-Reply-To: <20220422192344.830350-1-victortoso@redhat.com> References: <20220422192344.830350-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1650655460126100005 Content-Type: text/plain; charset="utf-8" scripts/apibuild.py does not handle well enum's with comments between values. The outcome depends on whether the enum value has its own docstring or not and if there is spaces between the enum values or not. This commit removes some generic comments that I have spotted. Signed-off-by: Victor Toso --- include/libvirt/libvirt-domain.h | 6 ------ include/libvirt/libvirt-storage.h | 1 - 2 files changed, 7 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-dom= ain.h index 138133b719..0fa4509b73 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1758,12 +1758,10 @@ int virDomainGetMemoryParameters(virDomainPtr d= omain, * Since: v0.9.0 */ typedef enum { - /* See virDomainModificationImpact for these flags. */ VIR_DOMAIN_MEM_CURRENT =3D VIR_DOMAIN_AFFECT_CURRENT, VIR_DOMAIN_MEM_LIVE =3D VIR_DOMAIN_AFFECT_LIVE, VIR_DOMAIN_MEM_CONFIG =3D VIR_DOMAIN_AFFECT_CONFIG, =20 - /* Additionally, these flags may be bitwise-OR'd in. */ VIR_DOMAIN_MEM_MAXIMUM =3D (1 << 2), /* affect Max rather than current= */ } virDomainMemoryModFlags; =20 @@ -2267,12 +2265,10 @@ typedef virVcpuInfo *virVcpuInfoPtr; * Since: v0.8.5 */ typedef enum { - /* See virDomainModificationImpact for these flags. */ VIR_DOMAIN_VCPU_CURRENT =3D VIR_DOMAIN_AFFECT_CURRENT, VIR_DOMAIN_VCPU_LIVE =3D VIR_DOMAIN_AFFECT_LIVE, VIR_DOMAIN_VCPU_CONFIG =3D VIR_DOMAIN_AFFECT_CONFIG, =20 - /* Additionally, these flags may be bitwise-OR'd in. */ VIR_DOMAIN_VCPU_MAXIMUM =3D (1 << 2), /* Max rather than current count= */ VIR_DOMAIN_VCPU_GUEST =3D (1 << 3), /* Modify state of the cpu in th= e guest */ VIR_DOMAIN_VCPU_HOTPLUGGABLE =3D (1 << 4), /* Make vcpus added hot(un)= pluggable */ @@ -2514,12 +2510,10 @@ int virDomainGetVcpus (vi= rDomainPtr domain, * Since: v0.7.7 */ typedef enum { - /* See virDomainModificationImpact for these flags. */ VIR_DOMAIN_DEVICE_MODIFY_CURRENT =3D VIR_DOMAIN_AFFECT_CURRENT, VIR_DOMAIN_DEVICE_MODIFY_LIVE =3D VIR_DOMAIN_AFFECT_LIVE, VIR_DOMAIN_DEVICE_MODIFY_CONFIG =3D VIR_DOMAIN_AFFECT_CONFIG, =20 - /* Additionally, these flags may be bitwise-OR'd in. */ VIR_DOMAIN_DEVICE_MODIFY_FORCE =3D (1 << 2), /* Forcibly modify device (ex. force eject a cdrom= ) */ } virDomainDeviceModifyFlags; diff --git a/include/libvirt/libvirt-storage.h b/include/libvirt/libvirt-st= orage.h index 94802bb2c5..46803eba2d 100644 --- a/include/libvirt/libvirt-storage.h +++ b/include/libvirt/libvirt-storage.h @@ -304,7 +304,6 @@ typedef enum { VIR_CONNECT_LIST_STORAGE_POOLS_AUTOSTART =3D 1 << 4, VIR_CONNECT_LIST_STORAGE_POOLS_NO_AUTOSTART =3D 1 << 5, =20 - /* List pools by type */ VIR_CONNECT_LIST_STORAGE_POOLS_DIR =3D 1 << 6, VIR_CONNECT_LIST_STORAGE_POOLS_FS =3D 1 << 7, VIR_CONNECT_LIST_STORAGE_POOLS_NETFS =3D 1 << 8, --=20 2.35.1