From nobody Tue Feb 10 04:14:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1649775492; cv=none; d=zohomail.com; s=zohoarc; b=eXF/lDFW9V7zJfHdzikr0/omXE7NFxY9ZzjQ47THAK/QfGno6pIa0I7/HgWtSR16qzt3QmT9bNpgiLZW5/ZMnaB9Ttd1qkAfo52XaDzriU1ZlWaCKSYsEnfMv8DAOhS2T1ZwcmBjH7rfKUYa7PxNVMzVRmqSYcjstoKHR3KWhsQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1649775492; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gQHsc2bgUSSshCyP9EOIPId0ZO+bhqJRD5H3GXa7DkI=; b=hX9RGqtg8tDSk4gtgUDh0mGbVKi/kcZwV3I23wl5MxN268FXXACqeRYSaCf1KS5uLKw0yKgGV4OosXvgM2l8NaoG6AWI2q5kpJblkyGGY/JDSU6fbATAixa1M9zZn46nwShtyf+6V9eKPQqOX05sBNypeAPSrQIhe7OVHKEVpF8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1649775492642922.5084829167665; Tue, 12 Apr 2022 07:58:12 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-328-3jSF0_mOPx2uBlg64wzFxw-1; Tue, 12 Apr 2022 10:58:08 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5B77F86B8DD; Tue, 12 Apr 2022 14:57:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 42A36C50949; Tue, 12 Apr 2022 14:57:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0ABEA193F6E0; Tue, 12 Apr 2022 14:57:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0348F193F509 for ; Tue, 12 Apr 2022 14:57:35 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E7E1540BAE6; Tue, 12 Apr 2022 14:57:34 +0000 (UTC) Received: from work.redhat.com (unknown [10.39.194.239]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5DD8F43203F; Tue, 12 Apr 2022 14:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649775491; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=gQHsc2bgUSSshCyP9EOIPId0ZO+bhqJRD5H3GXa7DkI=; b=SSO15+UsAG95I0DpaDQa1NZ8WosGhPIdx6yyiXtYEK8BA1jRpFRq09AHSH8X39V26CB3a+ mq7DPj0QdtyMs7W5xg9cNso67CimeLL1UDuqZPY1DjxBwecsdytmmBLKkWP0GvMlqinXMH 4PeOciS4Ye3ou/0HWWK32HDMNNxjhcA= X-MC-Unique: 3jSF0_mOPx2uBlg64wzFxw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 07/10] virnetserver: Use automatic mutex management Date: Tue, 12 Apr 2022 16:57:24 +0200 Message-Id: <20220412145727.69564-8-twiederh@redhat.com> In-Reply-To: <20220412145727.69564-1-twiederh@redhat.com> References: <20220412145727.69564-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Wiederhake Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1649775493463100007 Content-Type: text/plain; charset="utf-8"; x-default="true" Signed-off-by: Tim Wiederhake --- src/rpc/virnetserver.c | 277 +++++++++++++++-------------------------- 1 file changed, 100 insertions(+), 177 deletions(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index 7824d121cd..9b333f1a6c 100644 --- a/src/rpc/virnetserver.c +++ b/src/rpc/virnetserver.c @@ -97,13 +97,9 @@ VIR_ONCE_GLOBAL_INIT(virNetServer); unsigned long long virNetServerNextClientID(virNetServer *srv) { - unsigned long long val; + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 - virObjectLock(srv); - val =3D srv->next_client_id++; - virObjectUnlock(srv); - - return val; + return srv->next_client_id++; } =20 =20 @@ -208,13 +204,13 @@ virNetServerDispatchNewMessage(virNetServerClient *cl= ient, VIR_DEBUG("server=3D%p client=3D%p message=3D%p", srv, client, msg); =20 - virObjectLock(srv); - prog =3D virNetServerGetProgramLocked(srv, msg); - /* we can unlock @srv since @prog can only become invalid in case - * of disposing @srv, but let's grab a ref first to ensure nothing - * disposes of it before we use it. */ - virObjectRef(srv); - virObjectUnlock(srv); + VIR_WITH_OBJECT_LOCK_GUARD(srv) { + prog =3D virNetServerGetProgramLocked(srv, msg); + /* we can unlock @srv since @prog can only become invalid in case + * of disposing @srv, but let's grab a ref first to ensure nothing + * disposes of it before we use it. */ + virObjectRef(srv); + } =20 if (virThreadPoolGetMaxWorkers(srv->workers) > 0) { virNetServerJob *job; @@ -304,35 +300,28 @@ int virNetServerAddClient(virNetServer *srv, virNetServerClient *client) { - virObjectLock(srv); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 if (virNetServerClientInit(client) < 0) - goto error; + return -1; =20 VIR_EXPAND_N(srv->clients, srv->nclients, 1); srv->clients[srv->nclients-1] =3D virObjectRef(client); =20 - virObjectLock(client); - if (virNetServerClientIsAuthPendingLocked(client)) - virNetServerTrackPendingAuthLocked(srv); - virObjectUnlock(client); + VIR_WITH_OBJECT_LOCK_GUARD(client) { + if (virNetServerClientIsAuthPendingLocked(client)) + virNetServerTrackPendingAuthLocked(srv); + } =20 virNetServerCheckLimits(srv); =20 - virNetServerClientSetDispatcher(client, - virNetServerDispatchNewMessage, - srv); + virNetServerClientSetDispatcher(client, virNetServerDispatchNewMessage= , srv); =20 if (virNetServerClientInitKeepAlive(client, srv->keepaliveInterval, srv->keepaliveCount) < 0) - goto error; + return -1; =20 - virObjectUnlock(srv); return 0; - - error: - virObjectUnlock(srv); - return -1; } =20 =20 @@ -565,65 +554,62 @@ virNetServerPreExecRestart(virNetServer *srv) g_autoptr(virJSONValue) clients =3D virJSONValueNewArray(); g_autoptr(virJSONValue) services =3D virJSONValueNewArray(); size_t i; - - virObjectLock(srv); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 if (virJSONValueObjectAppendNumberUint(object, "min_workers", virThreadPoolGetMinWorkers(srv-= >workers)) < 0) - goto error; + return NULL; + if (virJSONValueObjectAppendNumberUint(object, "max_workers", virThreadPoolGetMaxWorkers(srv-= >workers)) < 0) - goto error; + return NULL; + if (virJSONValueObjectAppendNumberUint(object, "priority_workers", virThreadPoolGetPriorityWorkers= (srv->workers)) < 0) - goto error; + return NULL; =20 if (virJSONValueObjectAppendNumberUint(object, "max_clients", srv->ncl= ients_max) < 0) - goto error; + return NULL; + if (virJSONValueObjectAppendNumberUint(object, "max_anonymous_clients", srv->nclients_unauth_max) < 0) - goto error; + return NULL; =20 if (virJSONValueObjectAppendNumberUint(object, "keepaliveInterval", sr= v->keepaliveInterval) < 0) - goto error; + return NULL; + if (virJSONValueObjectAppendNumberUint(object, "keepaliveCount", srv->= keepaliveCount) < 0) - goto error; + return NULL; =20 if (virJSONValueObjectAppendNumberUlong(object, "next_client_id", srv->next_client_id) < 0) - goto error; + return NULL; =20 for (i =3D 0; i < srv->nservices; i++) { g_autoptr(virJSONValue) child =3D NULL; if (!(child =3D virNetServerServicePreExecRestart(srv->services[i]= ))) - goto error; + return NULL; =20 if (virJSONValueArrayAppend(services, &child) < 0) - goto error; + return NULL; } =20 if (virJSONValueObjectAppend(object, "services", &services) < 0) - goto error; + return NULL; =20 for (i =3D 0; i < srv->nclients; i++) { g_autoptr(virJSONValue) child =3D NULL; if (!(child =3D virNetServerClientPreExecRestart(srv->clients[i]))) - goto error; + return NULL; =20 if (virJSONValueArrayAppend(clients, &child) < 0) - goto error; + return NULL; } =20 if (virJSONValueObjectAppend(object, "clients", &clients) < 0) - goto error; - - virObjectUnlock(srv); + return NULL; =20 return g_steal_pointer(&object); - - error: - virObjectUnlock(srv); - return NULL; } =20 =20 @@ -631,16 +617,12 @@ int virNetServerAddService(virNetServer *srv, virNetServerService *svc) { - virObjectLock(srv); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 VIR_EXPAND_N(srv->services, srv->nservices, 1); srv->services[srv->nservices-1] =3D virObjectRef(svc); =20 - virNetServerServiceSetDispatcher(svc, - virNetServerDispatchNewClient, - srv); - - virObjectUnlock(srv); + virNetServerServiceSetDispatcher(svc, virNetServerDispatchNewClient, s= rv); return 0; } =20 @@ -795,12 +777,10 @@ int virNetServerAddProgram(virNetServer *srv, virNetServerProgram *prog) { - virObjectLock(srv); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 VIR_EXPAND_N(srv->programs, srv->nprograms, 1); srv->programs[srv->nprograms-1] =3D virObjectRef(prog); - - virObjectUnlock(srv); return 0; } =20 @@ -846,13 +826,12 @@ void virNetServerSetClientAuthenticated(virNetServer *srv, virNetServerClient *client) { - virObjectLock(srv); - virObjectLock(client); + VIR_LOCK_GUARD server_lock =3D virObjectLockGuard(srv); + VIR_LOCK_GUARD client_lock =3D virObjectLockGuard(srv); + virNetServerClientSetAuthLocked(client, VIR_NET_SERVER_SERVICE_AUTH_NO= NE); virNetServerSetClientAuthCompletedLocked(srv, client); virNetServerCheckLimits(srv); - virObjectUnlock(client); - virObjectUnlock(srv); } =20 =20 @@ -871,9 +850,9 @@ void virNetServerUpdateServices(virNetServer *srv, bool enabled) { - virObjectLock(srv); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); + virNetServerUpdateServicesLocked(srv, enabled); - virObjectUnlock(srv); } =20 =20 @@ -904,22 +883,20 @@ virNetServerDispose(void *obj) void virNetServerClose(virNetServer *srv) { - size_t i; - if (!srv) return; =20 - virObjectLock(srv); + VIR_WITH_OBJECT_LOCK_GUARD(srv) { + size_t i; =20 - for (i =3D 0; i < srv->nservices; i++) - virNetServerServiceClose(srv->services[i]); - - for (i =3D 0; i < srv->nclients; i++) - virNetServerClientClose(srv->clients[i]); + for (i =3D 0; i < srv->nservices; i++) + virNetServerServiceClose(srv->services[i]); =20 - virThreadPoolStop(srv->workers); + for (i =3D 0; i < srv->nclients; i++) + virNetServerClientClose(srv->clients[i]); =20 - virObjectUnlock(srv); + virThreadPoolStop(srv->workers); + } } =20 =20 @@ -947,13 +924,9 @@ virNetServerTrackCompletedAuthLocked(virNetServer *srv) bool virNetServerHasClients(virNetServer *srv) { - bool ret; - - virObjectLock(srv); - ret =3D !!srv->nclients; - virObjectUnlock(srv); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 - return ret; + return !!srv->nclients; } =20 =20 @@ -963,42 +936,37 @@ virNetServerProcessClients(virNetServer *srv) size_t i =3D 0; =20 while (true) { + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); virNetServerClient *client; bool removed =3D false; =20 - virObjectLock(srv); - if (i >=3D srv->nclients) { - virObjectUnlock(srv); return; } =20 client =3D srv->clients[i]; - virObjectLock(client); - if (virNetServerClientWantCloseLocked(client)) - virNetServerClientCloseLocked(client); =20 - if (virNetServerClientIsClosedLocked(client)) { - VIR_DELETE_ELEMENT(srv->clients, i, srv->nclients); - removed =3D true; + VIR_WITH_OBJECT_LOCK_GUARD(client) { + if (virNetServerClientWantCloseLocked(client)) + virNetServerClientCloseLocked(client); =20 - /* Update server authentication tracking */ - virNetServerSetClientAuthCompletedLocked(srv, client); - virNetServerCheckLimits(srv); - } + if (virNetServerClientIsClosedLocked(client)) { + VIR_DELETE_ELEMENT(srv->clients, i, srv->nclients); + removed =3D true; =20 - virObjectUnlock(client); + /* Update server authentication tracking */ + virNetServerSetClientAuthCompletedLocked(srv, client); + virNetServerCheckLimits(srv); + } + } =20 if (removed) { i =3D 0; - virObjectUnlock(srv); virObjectUnref(client); continue; } =20 i++; - - virObjectUnlock(srv); } } =20 @@ -1019,7 +987,7 @@ virNetServerGetThreadPoolParameters(virNetServer *srv, size_t *nPrioWorkers, size_t *jobQueueDepth) { - virObjectLock(srv); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 *minWorkers =3D virThreadPoolGetMinWorkers(srv->workers); *maxWorkers =3D virThreadPoolGetMaxWorkers(srv->workers); @@ -1028,7 +996,6 @@ virNetServerGetThreadPoolParameters(virNetServer *srv, *nPrioWorkers =3D virThreadPoolGetPriorityWorkers(srv->workers); *jobQueueDepth =3D virThreadPoolGetJobQueueDepth(srv->workers); =20 - virObjectUnlock(srv); return 0; } =20 @@ -1039,66 +1006,46 @@ virNetServerSetThreadPoolParameters(virNetServer *s= rv, long long int maxWorkers, long long int prioWorkers) { - int ret; + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 - virObjectLock(srv); - ret =3D virThreadPoolSetParameters(srv->workers, minWorkers, - maxWorkers, prioWorkers); - virObjectUnlock(srv); - - return ret; + return virThreadPoolSetParameters(srv->workers, minWorkers, + maxWorkers, prioWorkers); } =20 =20 size_t virNetServerGetMaxClients(virNetServer *srv) { - size_t ret; - - virObjectLock(srv); - ret =3D srv->nclients_max; - virObjectUnlock(srv); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 - return ret; + return srv->nclients_max; } =20 =20 size_t virNetServerGetCurrentClients(virNetServer *srv) { - size_t ret; - - virObjectLock(srv); - ret =3D srv->nclients; - virObjectUnlock(srv); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 - return ret; + return srv->nclients; } =20 =20 size_t virNetServerGetMaxUnauthClients(virNetServer *srv) { - size_t ret; + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 - virObjectLock(srv); - ret =3D srv->nclients_unauth_max; - virObjectUnlock(srv); - - return ret; + return srv->nclients_unauth_max; } =20 =20 size_t virNetServerGetCurrentUnauthClients(virNetServer *srv) { - size_t ret; - - virObjectLock(srv); - ret =3D srv->nclients_unauth; - virObjectUnlock(srv); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 - return ret; + return srv->nclients_unauth; } =20 =20 @@ -1106,17 +1053,15 @@ bool virNetServerNeedsAuth(virNetServer *srv, int auth) { - bool ret =3D false; + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); size_t i; =20 - virObjectLock(srv); for (i =3D 0; i < srv->nservices; i++) { if (virNetServerServiceGetAuth(srv->services[i]) =3D=3D auth) - ret =3D true; + return true; } - virObjectUnlock(srv); =20 - return ret; + return false; } =20 =20 @@ -1127,8 +1072,7 @@ virNetServerGetClients(virNetServer *srv, size_t i; size_t nclients =3D 0; virNetServerClient **list =3D NULL; - - virObjectLock(srv); + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); =20 for (i =3D 0; i < srv->nclients; i++) { virNetServerClient *client =3D virObjectRef(srv->clients[i]); @@ -1137,8 +1081,6 @@ virNetServerGetClients(virNetServer *srv, =20 *clts =3D g_steal_pointer(&list); =20 - virObjectUnlock(srv); - return nclients; } =20 @@ -1147,23 +1089,17 @@ virNetServerClient * virNetServerGetClient(virNetServer *srv, unsigned long long id) { + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); size_t i; - virNetServerClient *ret =3D NULL; - - virObjectLock(srv); =20 for (i =3D 0; i < srv->nclients; i++) { virNetServerClient *client =3D srv->clients[i]; if (virNetServerClientGetID(client) =3D=3D id) - ret =3D virObjectRef(client); + return virObjectRef(client); } =20 - virObjectUnlock(srv); - - if (!ret) - virReportError(VIR_ERR_NO_CLIENT, - _("No client with matching ID '%llu'"), id); - return ret; + virReportError(VIR_ERR_NO_CLIENT, _("No client with matching ID '%llu'= "), id); + return NULL; } =20 =20 @@ -1172,13 +1108,9 @@ virNetServerSetClientLimits(virNetServer *srv, long long int maxClients, long long int maxClientsUnauth) { - int ret =3D -1; - size_t max, max_unauth; - - virObjectLock(srv); - - max =3D maxClients >=3D 0 ? maxClients : srv->nclients_max; - max_unauth =3D maxClientsUnauth >=3D 0 ? + VIR_LOCK_GUARD lock =3D virObjectLockGuard(srv); + size_t max =3D maxClients >=3D 0 ? maxClients : srv->nclients_max; + size_t max_unauth =3D maxClientsUnauth >=3D 0 ? maxClientsUnauth : srv->nclients_unauth_max; =20 if (max < max_unauth) { @@ -1186,7 +1118,7 @@ virNetServerSetClientLimits(virNetServer *srv, _("The overall maximum number of clients must be " "greater than the maximum number of clients waiti= ng " "for authentication")); - goto cleanup; + return -1; } =20 if (maxClients >=3D 0) @@ -1197,10 +1129,7 @@ virNetServerSetClientLimits(virNetServer *srv, =20 virNetServerCheckLimits(srv); =20 - ret =3D 0; - cleanup: - virObjectUnlock(srv); - return ret; + return 0; } =20 =20 @@ -1226,30 +1155,24 @@ virNetServerGetTLSContext(virNetServer *srv) int virNetServerUpdateTlsFiles(virNetServer *srv) { - int ret =3D -1; - virNetTLSContext *ctxt =3D NULL; bool privileged =3D geteuid() =3D=3D 0; + virNetTLSContext *ctxt =3D virNetServerGetTLSContext(srv); =20 - ctxt =3D virNetServerGetTLSContext(srv); if (!ctxt) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("no tls service found, unable to update tls files= ")); return -1; } =20 - virObjectLock(srv); - virObjectLock(ctxt); - - if (virNetTLSContextReloadForServer(ctxt, !privileged)) { - VIR_DEBUG("failed to reload server's tls context"); - goto cleanup; + VIR_WITH_OBJECT_LOCK_GUARD(srv) { + VIR_WITH_OBJECT_LOCK_GUARD(ctxt) { + if (virNetTLSContextReloadForServer(ctxt, !privileged)) { + VIR_DEBUG("failed to reload server's tls context"); + return -1; + } + } } =20 VIR_DEBUG("update tls files success"); - ret =3D 0; - - cleanup: - virObjectUnlock(ctxt); - virObjectUnlock(srv); - return ret; + return 0; } --=20 2.31.1