From nobody Tue Feb 10 04:29:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=nutanix.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1649440211672149.98539968617513; Fri, 8 Apr 2022 10:50:11 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-633-7c6mYn0yOGiBOzTOaLEKWg-1; Fri, 08 Apr 2022 13:49:35 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B5D1280B070; Fri, 8 Apr 2022 17:49:25 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3EB4240E80E0; Fri, 8 Apr 2022 17:49:24 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 72536194035F; Fri, 8 Apr 2022 17:49:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 94D29194034C for ; Fri, 8 Apr 2022 17:49:22 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 8335C814B; Fri, 8 Apr 2022 17:49:22 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast10.extmail.prod.ext.rdu2.redhat.com [10.11.55.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7CFF49D51 for ; Fri, 8 Apr 2022 17:49:19 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F19031C08DD2 for ; Fri, 8 Apr 2022 17:49:18 +0000 (UTC) Received: from mx0a-002c1b01.pphosted.com (mx0a-002c1b01.pphosted.com [148.163.151.68]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-177-YB4JFUUeNueDIiYuxHBd5w-1; Fri, 08 Apr 2022 13:49:16 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 238EMqEn009873 for ; Fri, 8 Apr 2022 10:49:15 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2170.outbound.protection.outlook.com [104.47.58.170]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 3f6p1yp13w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 08 Apr 2022 10:49:15 -0700 Received: from SJ0PR02MB8564.namprd02.prod.outlook.com (2603:10b6:a03:3f6::16) by BY5PR02MB6533.namprd02.prod.outlook.com (2603:10b6:a03:1d5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.26; Fri, 8 Apr 2022 17:49:13 +0000 Received: from SJ0PR02MB8564.namprd02.prod.outlook.com ([fe80::b167:3939:c2e0:64e8]) by SJ0PR02MB8564.namprd02.prod.outlook.com ([fe80::b167:3939:c2e0:64e8%6]) with mapi id 15.20.5144.023; Fri, 8 Apr 2022 17:49:13 +0000 X-MC-Unique: 7c6mYn0yOGiBOzTOaLEKWg-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: YB4JFUUeNueDIiYuxHBd5w-1 From: Rohit Kumar To: libvir-list@redhat.com Subject: [PATCH v2 3/8] Validate remote store NVRAM Date: Fri, 8 Apr 2022 10:48:46 -0700 Message-Id: <20220408174851.1077477-4-rohit.kumar3@nutanix.com> In-Reply-To: <20220408174851.1077477-1-rohit.kumar3@nutanix.com> References: <20220408174851.1077477-1-rohit.kumar3@nutanix.com> X-ClientProxiedBy: SJ0PR03CA0363.namprd03.prod.outlook.com (2603:10b6:a03:3a1::8) To SJ0PR02MB8564.namprd02.prod.outlook.com (2603:10b6:a03:3f6::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bdffdc21-5f31-4a62-bcbf-08da198817f2 X-MS-TrafficTypeDiagnostic: BY5PR02MB6533:EE_ X-Microsoft-Antispam-PRVS: x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: dCBq+nJ16s7pqpJvMxNuhaLfwczMmJwxfz2CEtzaTHh+Sl884DrK1g2LG/fuqumabBSdv/FiuZltalGF1suQJ0wEOFDAkRWdUtVOYaqubdzJOIZzyMSkljTLuyoHdY5HHZ14CH/G+KLrPgS9+qPn7XvKMPShBeU1ao0Vu+oKoMkgyKeUE2s6YJIt8wrnyZq3hr/sJWvPTgfcYSUKKozaSZeW1xOVH1Gl110HYsO37OSKcWO/bYEHg2+5xB7TF7Xjm+aWQ8BQKuZK7+PN/VLjbDiUPJ590NNVCXwl+rIhFIpZRp7u3dUso85xWl4/+czgkSGfOtg/eNitogrp9zjYtdsoyQFdaYuQ6eCqg7V6z0oCLE9mT6mIz2OtQm4JhWuosA0wVajPO87koXhXoTglcW9lXVZGWzz3PCuBXZ1ZKdMeNxQiW8i4eC9ndn7xRjHudtOiJ955WZx85yqu8v3s5ZcURf5rzhkGqudoabIxsjtc17nSpAhnhOHHSC7Br7SWuxM2dkeEerHzvdiBa+zEB8pJep0MaxOdTuQD5dCZgLvwH2V6QSbWADcXeor1B3RHOxdYZgy/SMrj74F3CLignF8Xylo6J1jwXoZuQAhOBBvV86lpFHnpE6nvZmUw/tNDpuGIWnyqJvOgokrq9+B3LhWyXdaAHCjR+5AlDj2jfK/h1PfsO0CxZPp+KOLfpK9d X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR02MB8564.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6666004)(38350700002)(38100700002)(6486002)(83380400001)(8936002)(508600001)(2906002)(86362001)(5660300002)(66476007)(36756003)(66556008)(2616005)(107886003)(8676002)(4326008)(66946007)(6512007)(6916009)(54906003)(26005)(186003)(52116002)(6506007)(1076003)(316002); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dUIHvT6D2NS49iZ5Vy9VH0q1JDzhCkmMZmCDsKNQv9YGo97Y9LokSPkDcnAT?= =?us-ascii?Q?G8Vh746xMWyMF/lbUtI0I6qWjmlYLwVsQPJzySlwMmOUNunD5DoDrEObWbeo?= =?us-ascii?Q?003qHovQ5nYLBLcsnO2qKyhs9G0exybQKCIlbaHOd1b+elYe6tVGj0YjB9IB?= =?us-ascii?Q?NC9Xn1LCuKUQ1XH/4Xipk75swTxm0J9xjvj7GhXXDXjXCqdauG81owg3r66K?= =?us-ascii?Q?dkngTzY5WJNyX9nyg+5kvIWMrYpZsbX9OM8rYlddPIdXf+Zm4/BI+C7fnEqZ?= =?us-ascii?Q?pdEz8rD4KS6fgsIRtzNFUux2zv+So9pWZHMSTRXx/ANU9VoVWC1D1A+T3eLU?= =?us-ascii?Q?K/jWpC2HRPJTCrKcjDOIEfIO23aURvdawhWN+KTdD5tz0M6iNKn9ELcAKbgW?= =?us-ascii?Q?tLS2j4p7VUi0PC+/g5yPI9AIA8HPPNqGHniWzlvwTM7cbA0XweZKhHWBnKLe?= =?us-ascii?Q?Vzkxmd2uHju7WWqGr3Vs+OAzd5Zbw4vGoEkJ4zVLThZpU8IH+/ejRa99Wyu8?= =?us-ascii?Q?NEkmAdq9SdHUhwGnTybwhD06igef3LchYkukQbWB/YTejf3HjQX04bpgNZfz?= =?us-ascii?Q?uzaT2rPkBqQiVxiUZ7JgCROl1vgbTZsV6fg6GimrM1uQCxQXA0mA6FDxteGb?= =?us-ascii?Q?/oWKGM22sXGnbkvtMkAYz8N6nGipDWjBb3Xt8/TCsR6WKd+3cU+q6BtVRqPL?= =?us-ascii?Q?8Zwdt2CJAd74epLLzlc4mQsWpNhKldFZ7tCzrrsK4ZZfUfgGEIR7I/Tak3B1?= =?us-ascii?Q?n+NDlX9+X/G8RDaCaWgzsIhiFM4C3nBr4VYMcZt6MgaDF2rDnS7qZmSBG8rH?= =?us-ascii?Q?QwLy72k6eP+wQMIo4d3Pg7ufKHcO0j/vzh+JLwG9D3nbbZaN/Nb5+SVcfCeW?= =?us-ascii?Q?J/bcPrz7AsIKb9rOKWvVomQDK27eaHAWbs3aNu8ORWDkPG5whRu+5AtuJm51?= =?us-ascii?Q?uDI8AME0AWeAmf2XKjxPyJZ/Q/SN23bOspoqpiC5FSdg3dalvQMPtxUYdgOY?= =?us-ascii?Q?xX6A3C46WWFR7sRA5AqBHHP7jEC7hTXia19vd4df1xUx1fu+BsJbGTymNZrX?= =?us-ascii?Q?IviaSN/zxKrD7eEEUphDa4+tF5HUMxHDq1JGhQ6DNhaStmH1Igs5eXPQfVXG?= =?us-ascii?Q?3nAzBWDBtq1htf7tPazBQ60LtS8x/LQxAcUX7/lwxU5PWbgj9Jwl05GecIEk?= =?us-ascii?Q?CC206EfvjsqQ62yaPKw6mXt51EJEWgwWwIvWgAI16cs+U6xtzn8LT1lK+KrR?= =?us-ascii?Q?VWhXmGk6JW2R4EdUthGpHeOnHQEAL9RN4B/8UiwhxiDJgyu2P7sF2oBMK0uW?= =?us-ascii?Q?CBFbVjOnj8aRuikechw5sKzpMoKq+4H9iOAiA13JWJtVh5qElfbiXYm2GVvM?= =?us-ascii?Q?ExUmdLZz43usbqsmYTo8cUa+e/I43KAVEBPvbxZ1IyaXGhxwErSqvwXsYOaI?= =?us-ascii?Q?4WkIpKj+A2B0rOhpcEeI0ggfbtnu9XOlcEGc68tnv3/yg10OsXD5XLkPTxx3?= =?us-ascii?Q?fso+8zyfRUNK50FhR6HqR+Lc7hIzglW44bvIp6XjvA+RDtk8T3MDZrX+DItS?= =?us-ascii?Q?Qrm5vbjghEYZSjb+4RJrZveCg2KVDJhKGVMu3GTqW1m/+gwLE6XiUrxyDqNc?= =?us-ascii?Q?250uF7WCFoKmgkm7A8J0WynM3n7+XZcKfgR6wncmxD+GhLGg1brNY7pji/oD?= =?us-ascii?Q?z8B4zLEYioIazOYCikZ5mgntELnJdOXdCiLPr9F6RQeQtYRxH+VeHERqdNAu?= =?us-ascii?Q?dOtPtJykEvwdm+8C/y4NfViX/lZXrGk=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdffdc21-5f31-4a62-bcbf-08da198817f2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR02MB8564.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 17:49:13.5939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SGjNEytCzYdNmRXcpZNy3u/t1MrZQBwScDiLa8me1CQFPd23NjJgvHWNU5IsSEGoDUOj0bBGhWP7qLN5MOox/TkpqbC+wqFFc714cf7p3tA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6533 X-Proofpoint-ORIG-GUID: kPLEia56LDHVOykE8qs0Ztk62QsXd13U X-Proofpoint-GUID: kPLEia56LDHVOykE8qs0Ztk62QsXd13U X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-04-08_05,2022-04-08_01,2022-02-23_01 X-Proofpoint-Spam-Reason: safe X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: prachatos.mitra@nutanix.com, Rohit Kumar , Florian Schmidt , prerna.saxena@nutanix.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1649440212213100001 Content-Type: text/plain; charset="utf-8" Remote store NVRAM feature is being enabled only if it supports 'blockdev' capability. Signed-off-by: Prerna Saxena Signed-off-by: Florian Schmidt Signed-off-by: Rohit Kumar --- src/qemu/qemu_validate.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 96f5427678..2a961b1f50 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -611,6 +611,25 @@ qemuValidateDomainDefBoot(const virDomainDef *def) } =20 =20 +static int +qemuValidateDomainDefNvram(const virDomainDef *def, + virQEMUCaps *qemuCaps) +{ + if (def->os.loader && def->os.loader->nvram) { + if (def->os.loader->nvram->type !=3D VIR_STORAGE_TYPE_FILE && + !virQEMUCapsGet(qemuCaps, QEMU_CAPS_BLOCKDEV)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("This Qemu does not support 'blockdev' capabi= lity " + "for remote store NVRAM. NVRAM type other tha= n " + "'file' is not supported with this QEMU")); + return -1; + } + } + + return 0; +} + + /** * qemuValidateDefGetVcpuHotplugGranularity: * @def: domain definition @@ -1185,6 +1204,9 @@ qemuValidateDomainDef(const virDomainDef *def, if (qemuValidateDomainDefBoot(def) < 0) return -1; =20 + if (qemuValidateDomainDefNvram(def, qemuCaps) < 0) + return -1; + if (qemuValidateDomainVCpuTopology(def, qemuCaps) < 0) return -1; =20 --=20 2.25.1