From nobody Tue Feb 10 20:48:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=openvz.org Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1648725596559582.9949210405921; Thu, 31 Mar 2022 04:19:56 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-573-dQ09dVU1Pba03k1Ph9A7wg-1; Thu, 31 Mar 2022 07:19:53 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8FADD899EC5; Thu, 31 Mar 2022 11:19:50 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7AA525B1588; Thu, 31 Mar 2022 11:19:50 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 493701947BBB; Thu, 31 Mar 2022 11:19:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 46F551940353 for ; Thu, 31 Mar 2022 11:19:46 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 32BE7C08090; Thu, 31 Mar 2022 11:19:46 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2ECCFC08087 for ; Thu, 31 Mar 2022 11:19:46 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 149A028035FF for ; Thu, 31 Mar 2022 11:19:46 +0000 (UTC) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-349-XGDLXTUAMhudjWIcGPferQ-1; Thu, 31 Mar 2022 07:19:44 -0400 Received: by mail-lf1-f42.google.com with SMTP id d5so40876644lfj.9 for ; Thu, 31 Mar 2022 04:19:43 -0700 (PDT) Received: from vzbook.. (broadband-90-154-71-96.ip.moscow.rt.ru. [90.154.71.96]) by smtp.gmail.com with ESMTPSA id b24-20020a196458000000b0044ab702b6acsm695653lfj.238.2022.03.31.04.19.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 04:19:41 -0700 (PDT) X-MC-Unique: dQ09dVU1Pba03k1Ph9A7wg-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: XGDLXTUAMhudjWIcGPferQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mPYENgvRXXlsWI4X8xQyd2q9lq7cajT8xdjZDb2iXTQ=; b=f8ANzWI8g8HbN2hpr92+HANaNTtePGoOaadIgQfPEdBNdxdO6TVV3gAmuDMJs2CSm8 VS7rItvYT4DEIW48aKV7Jh1MyqZhr+PKpXZYbUU9EnnFuo92QY3HB0n5rnnQ1viTsa+A EZS2kw5tOcK2Qpait9cp58jyGeBIUBh+1wxmKAhd9nWWnQWNNHy4/ke5aWzDYkYJVpNT VM5tZvBg9uV6BJ4x1EDvobkYiruQAe2g0CGbt0wAQSIhLTightC2AgOFS8h7XfU5TT/+ QmY0x7C0Ol8UHRuA9osDwlLfWW35phTGv0oub/JiluF//ikvLeBr9fexZcHsIhQ+syDi bfjg== X-Gm-Message-State: AOAM530todTsvsB1ntR1inL+NpTrfmllWfOW2XRxCPHovbGrrgdSsmw5 l6KHVk3gOQrQKyB2FUPFuOjIL2W+UaP75w== X-Google-Smtp-Source: ABdhPJy8aTB/aq3SgR9Hcic8xh0x6/mlFpOr77EMxcGDdTj3go4VK8J2K9JJYu8UnA9dMmqC4fJoMg== X-Received: by 2002:a05:6512:ad5:b0:44a:614e:9d61 with SMTP id n21-20020a0565120ad500b0044a614e9d61mr10531596lfu.677.1648725581884; Thu, 31 Mar 2022 04:19:41 -0700 (PDT) From: Nikolay Shirokovskiy To: libvir-list@redhat.com Subject: [PATCH 04/11] qemu: introduce QEMU_ASYNC_JOB_SNAPSHOT_DELETE Date: Thu, 31 Mar 2022 14:19:14 +0300 Message-Id: <20220331111921.450496-5-nikolay.shirokovskiy@openvz.org> In-Reply-To: <20220331111921.450496-1-nikolay.shirokovskiy@openvz.org> References: <20220331111921.450496-1-nikolay.shirokovskiy@openvz.org> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1648725598626100011 Content-Type: text/plain; charset="utf-8"; x-default="true" We are going to use this job for snapshot delete API. Currently snapshot delete API uses QEMU_JOB_MODIFY. Signed-off-by: Nikolay Shirokovskiy --- src/hypervisor/domain_job.c | 1 + src/hypervisor/domain_job.h | 1 + src/qemu/qemu_domainjob.c | 2 ++ src/qemu/qemu_driver.c | 6 ++++++ src/qemu/qemu_migration.c | 2 ++ src/qemu/qemu_process.c | 3 +++ 6 files changed, 15 insertions(+) diff --git a/src/hypervisor/domain_job.c b/src/hypervisor/domain_job.c index ff4e008cb5..ad71a77150 100644 --- a/src/hypervisor/domain_job.c +++ b/src/hypervisor/domain_job.c @@ -37,6 +37,7 @@ VIR_ENUM_IMPL(virDomainAsyncJob, "save", "dump", "snapshot", + "snapshot delete", "start", "backup", ); diff --git a/src/hypervisor/domain_job.h b/src/hypervisor/domain_job.h index db8b8b1390..cb24e3f743 100644 --- a/src/hypervisor/domain_job.h +++ b/src/hypervisor/domain_job.h @@ -63,6 +63,7 @@ typedef enum { VIR_ASYNC_JOB_SAVE, VIR_ASYNC_JOB_DUMP, VIR_ASYNC_JOB_SNAPSHOT, + VIR_ASYNC_JOB_SNAPSHOT_DELETE, VIR_ASYNC_JOB_START, VIR_ASYNC_JOB_BACKUP, =20 diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c index 56a3f6cb19..89f721abc9 100644 --- a/src/qemu/qemu_domainjob.c +++ b/src/qemu/qemu_domainjob.c @@ -85,6 +85,7 @@ virDomainAsyncJobPhaseToString(virDomainAsyncJob job, case VIR_ASYNC_JOB_SAVE: case VIR_ASYNC_JOB_DUMP: case VIR_ASYNC_JOB_SNAPSHOT: + case VIR_ASYNC_JOB_SNAPSHOT_DELETE: case VIR_ASYNC_JOB_START: case VIR_ASYNC_JOB_NONE: case VIR_ASYNC_JOB_BACKUP: @@ -111,6 +112,7 @@ virDomainAsyncJobPhaseFromString(virDomainAsyncJob job, case VIR_ASYNC_JOB_SAVE: case VIR_ASYNC_JOB_DUMP: case VIR_ASYNC_JOB_SNAPSHOT: + case VIR_ASYNC_JOB_SNAPSHOT_DELETE: case VIR_ASYNC_JOB_START: case VIR_ASYNC_JOB_NONE: case VIR_ASYNC_JOB_BACKUP: diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 74bc2c7bf4..547cffa1bc 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12741,6 +12741,12 @@ static int qemuDomainAbortJob(virDomainPtr dom) ret =3D 0; break; =20 + case VIR_ASYNC_JOB_SNAPSHOT_DELETE: + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("snapshot deletion expected to be exclusive job")= ); + goto endjob; + break; + case VIR_ASYNC_JOB_LAST: default: virReportEnumRangeError(virDomainAsyncJob, priv->job.asyncJob); diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 3e653543c6..cb4c0e544a 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1717,6 +1717,8 @@ qemuMigrationJobName(virDomainObj *vm) return _("snapshot job"); case VIR_ASYNC_JOB_START: return _("start job"); + case VIR_ASYNC_JOB_SNAPSHOT_DELETE: + return _("snapshot delete job"); case VIR_ASYNC_JOB_BACKUP: return _("backup job"); case VIR_ASYNC_JOB_LAST: diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index f110e4f3dd..9918423701 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -3648,6 +3648,9 @@ qemuProcessRecoverJob(virQEMUDriver *driver, /* Already handled in VIR_DOMAIN_PAUSED_STARTING_UP check. */ break; =20 + case VIR_ASYNC_JOB_SNAPSHOT_DELETE: + break; + case VIR_ASYNC_JOB_BACKUP: ignore_value(virTimeMillisNow(&now)); =20 --=20 2.35.1