From nobody Fri Nov 1 04:30:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=openvz.org Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1648710783486202.68742084817154; Thu, 31 Mar 2022 00:13:03 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-77-iCiLmdiRMamCstmU9sGQiA-1; Thu, 31 Mar 2022 03:12:32 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C64BF899EC2; Thu, 31 Mar 2022 07:12:28 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF21340D2822; Thu, 31 Mar 2022 07:12:28 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 63AF91947BBB; Thu, 31 Mar 2022 07:12:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8F3DF19451F3 for ; Thu, 31 Mar 2022 07:12:27 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 815C6400E420; Thu, 31 Mar 2022 07:12:27 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast08.extmail.prod.ext.rdu2.redhat.com [10.11.55.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7C812400E407 for ; Thu, 31 Mar 2022 07:12:27 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6568D3804501 for ; Thu, 31 Mar 2022 07:12:27 +0000 (UTC) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-212-2dBKhpanPdKxl402LOudzg-1; Thu, 31 Mar 2022 03:12:17 -0400 Received: by mail-lf1-f53.google.com with SMTP id k21so39830825lfe.4 for ; Thu, 31 Mar 2022 00:12:16 -0700 (PDT) Received: from vzbook.. (broadband-90-154-71-96.ip.moscow.rt.ru. [90.154.71.96]) by smtp.gmail.com with ESMTPSA id s6-20020ac25fa6000000b0044313e88020sm2585169lfe.202.2022.03.31.00.12.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 00:12:14 -0700 (PDT) X-MC-Unique: iCiLmdiRMamCstmU9sGQiA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: 2dBKhpanPdKxl402LOudzg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qRZ+aucpy8sOA5oJU9vVrupZY/5NU50o7pnht5WYdhU=; b=6KOf8VznFSqbQpVGbekjsrwzUSs3dmZchNsZux18EabvUOzMNTCAoCedFKEmuNaeen cuqz8LKFoVG/LZ/hbSv4PcNOW3R3v/4MPOBiT4V+VJy0OtuvbMg4sItHHRHrrkiEf3E4 s6BeR2YgGWXM1gvye2OGbvKH/BOeYo3O+07PCikUIUkxNGRu5tN/bnEVxRGIEkq2BOCU aLw40FhuZuQtTSxuKPBXBGqipI6gWeD+eN9osR9gN2Bc8YXB4uXbnxbu9UVdoRiaNMlO T1TZpPhB2LcSQFdeB/DoCF49wgKni1zBgRTbAgLbZ8itVTDuRtMbT/ZkSES41A82BeMa anLQ== X-Gm-Message-State: AOAM533TUvEeth8ZyGHajH7hJ/rFSphRyXyyO4fi6LLngoyzwydHuZMK bUJ+jfCL9qH9brKlC/TbLE4bkPlxhCpytw== X-Google-Smtp-Source: ABdhPJxvaSdHDChNgm39KLag7z9ad99eoHKqXoY7wmJJfuA6L5hEu9ZmU4scw5vxolz1ndXWS5U0bw== X-Received: by 2002:a05:6512:15a5:b0:44a:24f2:2cc with SMTP id bp37-20020a05651215a500b0044a24f202ccmr9756820lfb.31.1648710735132; Thu, 31 Mar 2022 00:12:15 -0700 (PDT) From: Nikolay Shirokovskiy To: libvir-list@redhat.com Subject: [PATCH v2 REBASE 2/3] qemu: remove excessive check in qemuSnapshotCreateActiveInternal Date: Thu, 31 Mar 2022 10:11:10 +0300 Message-Id: <20220331071111.332231-3-nikolay.shirokovskiy@openvz.org> In-Reply-To: <20220331071111.332231-1-nikolay.shirokovskiy@openvz.org> References: <20220331071111.332231-1-nikolay.shirokovskiy@openvz.org> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1648710785449100001 After [1] it is not possible to get inactive state for domain while communicating with QEMU (see also [2]). Also even if it were possible the qemuProcessStopCPUs would return error and the check would not be reached. [1] commit 81f50cb92d16643bcd749e3ab5b404b8b7cec643 Author: Jiri Denemark Date: Thu Feb 11 11:20:28 2016 +0100 qemu: Avoid calling qemuProcessStop without a job [2] commit f1ea5bd506b6e00aa8bf55940b147d3c0fe7f124 Author: J=C3=A1n Tomko Date: Wed Nov 24 13:41:09 2021 +0100 qemu: turn qemuDomainObjExitMonitor into void Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_snapshot.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index fc5b6dc7ce..df9da4613f 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -305,11 +305,6 @@ qemuSnapshotCreateActiveInternal(virQEMUDriver *driver, goto cleanup; =20 resume =3D true; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("guest unexpectedly quit")); - goto cleanup; - } } =20 if (qemuDomainObjEnterMonitorAsync(driver, vm, --=20 2.35.1