From nobody Wed Feb 11 06:32:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1648225631; cv=none; d=zohomail.com; s=zohoarc; b=eBlR9qpvM3XFGi6jBOh3+6MCy8i62OkP/+LmvPcBFL6l6XxGVMJgAxberyH0JO9wou+AgZo06ymAZE323AKYCIHcQzUcAd09FQ9254916XWY2tu9pDLL+gsJf+95q7v+qMcJK6yjMuG7dUZFsbswCuuuE0qlTKfbgSl/zif/DKo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1648225631; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XNvhjlsgAlE9NpU2R0GVQJuaTwlGfw926+KX4uExpi8=; b=bKrMXjCMFVkfpWmRVPxRSZF516nsSnEqgo1jzU7whG7zY0Z+YsQFuG1IXRDG7bVt/ryu8enqoo/okQRdB+VnsXGq06Y7g07LD5jyNdDfUgH21XVoLBWmlnkcscry0h32TcCKTWzyCKEcETZWA30gUdg4d9S81q2nG+wWqxhSeW0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1648225631226785.4988061745664; Fri, 25 Mar 2022 09:27:11 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-231-77abPF6lMvS2r8CuiIkerg-1; Fri, 25 Mar 2022 12:27:08 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 24279858286; Fri, 25 Mar 2022 16:27:04 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1126B14582E2; Fri, 25 Mar 2022 16:27:04 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4D5601940367; Fri, 25 Mar 2022 16:27:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1D071193F506 for ; Fri, 25 Mar 2022 16:26:59 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 10BB55E8A4C; Fri, 25 Mar 2022 16:26:59 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.40.192.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 938515E8A42 for ; Fri, 25 Mar 2022 16:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648225630; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XNvhjlsgAlE9NpU2R0GVQJuaTwlGfw926+KX4uExpi8=; b=M6dprT7ccUH/Yy0uvB1EqcO0MKGaxLk8jvLutZMWrIIrIYFaYmy1BNlA/7q0NAK6sHjzOK s4keSLlQvvyEX7yBdPTxxMk0qvANM08UMhUeeOxYNnqBPoBB+aAfMVhB/WulG55t4JIyVb XaCP0DR2QywXN57vHSyYUQ0k03NF08g= X-MC-Unique: 77abPF6lMvS2r8CuiIkerg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [PATCH 6/9] qemu: Don't ignore XMLParseAllowReboot() errors Date: Fri, 25 Mar 2022 17:26:49 +0100 Message-Id: <20220325162652.328686-7-abologna@redhat.com> In-Reply-To: <20220325162652.328686-1-abologna@redhat.com> References: <20220325162652.328686-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1648225631652100002 Content-Type: text/plain; charset="utf-8"; x-default="true" The function may fail and report an error, in which case we should not just continue as if nothing happened. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 88d9499bd0..d2bca4dd06 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3106,7 +3106,8 @@ qemuDomainObjPrivateXMLParse(xmlXPathContextPtr ctxt, priv->chardevStdioLogd =3D virXPathBoolean("boolean(./chardevStdioLogd= )", ctxt) =3D=3D 1; =20 - qemuDomainObjPrivateXMLParseAllowReboot(ctxt, &priv->allowReboot); + if (qemuDomainObjPrivateXMLParseAllowReboot(ctxt, &priv->allowReboot) = < 0) + goto error; =20 qemuDomainObjPrivateXMLParsePR(ctxt, &priv->prDaemonRunning); =20 --=20 2.35.1