From nobody Mon Feb 9 22:19:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1647532259; cv=none; d=zohomail.com; s=zohoarc; b=Df/KopVXU00C17IUgylTgt9EqjQ6TPXPVACssH4yqnD6HjRKJQ7KLeMw5/VjJTHRAq8tIdnzIeV2K2Mguq+oV95YoskGlJxMPERUR/pl+w71ri0LjDevFukWzybX5pdmsFlBzv6Xp70EmeEd+lehTq5ytCUcwnf1/bPA4UgSb7o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647532259; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=izN+HZxzJTkRJcgE1NS4YPN6UeNJf+XYPU3ew+adIoc=; b=Dfp7jD5BbCAlnmNaInH5uQ1SYMrgk6//SsOhU6SgatATIaXuMrNJSWMkXIEv7x7P7e2GeM0DDG/QSQo8ZxdWK37FmRKsKaWYBIZSN/sU4prWVtOKQWov+dHKWeMUiDkWqX64pxf5Q/P/fQSbxDSc3h3IE9yiRIEanUCEchZHqok= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1647532259018553.9708470309431; Thu, 17 Mar 2022 08:50:59 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-452-bblqdwiLMc6yxKeHPpGorg-1; Thu, 17 Mar 2022 11:50:56 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CC24B1C00B9D; Thu, 17 Mar 2022 15:50:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id B1AA041136E2; Thu, 17 Mar 2022 15:50:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6C90D193058E; Thu, 17 Mar 2022 15:50:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D2D19194E012 for ; Thu, 17 Mar 2022 15:50:50 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id B5F7141136F6; Thu, 17 Mar 2022 15:50:50 +0000 (UTC) Received: from work.fritz.box (unknown [10.39.195.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44C8A41136F5; Thu, 17 Mar 2022 15:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647532259; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=izN+HZxzJTkRJcgE1NS4YPN6UeNJf+XYPU3ew+adIoc=; b=PMfkySjFpKosl2N4lPohqbYQ3hehKI5MSH1dPkqrdZza4syBSMnZfAGs/QhR0McjA2mOhJ mz2WaVfOvoXSfmg6IqRYUEuI7A5PW+EeGP5gayk0eQOVPqRjsQl0LMle3va54iLpk4S53A 3E/WS1nYMLxz8Ygk23pBfp/YCyvcJAg= X-MC-Unique: bblqdwiLMc6yxKeHPpGorg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v3 2/2] qemu_conf: Use automatic memory management Date: Thu, 17 Mar 2022 16:50:48 +0100 Message-Id: <20220317155048.51800-3-twiederh@redhat.com> In-Reply-To: <20220317155048.51800-1-twiederh@redhat.com> References: <20220317155048.51800-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Wiederhake Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1647532268979100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/qemu/qemu_conf.c | 63 +++++++++++++++----------------------------- 1 file changed, 21 insertions(+), 42 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 81449b8b77..c22cf79cbe 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -85,17 +85,6 @@ static int virQEMUConfigOnceInit(void) VIR_ONCE_GLOBAL_INIT(virQEMUConfig); =20 =20 -static void -qemuDriverLock(virQEMUDriver *driver) -{ - virMutexLock(&driver->lock); -} -static void -qemuDriverUnlock(virQEMUDriver *driver) -{ - virMutexUnlock(&driver->lock); -} - #ifndef DEFAULT_LOADER_NVRAM # define DEFAULT_LOADER_NVRAM \ "/usr/share/OVMF/OVMF_CODE.fd:/usr/share/OVMF/OVMF_VARS.fd:" \ @@ -1279,11 +1268,9 @@ virQEMUDriverConfigSetDefaults(virQEMUDriverConfig *= cfg) =20 virQEMUDriverConfig *virQEMUDriverGetConfig(virQEMUDriver *driver) { - virQEMUDriverConfig *conf; - qemuDriverLock(driver); - conf =3D virObjectRef(driver->config); - qemuDriverUnlock(driver); - return conf; + VIR_LOCK_GUARD lock =3D virLockGuardLock(&driver->lock); + + return virObjectRef(driver->config); } =20 virDomainXMLOption * @@ -1303,16 +1290,13 @@ virQEMUDriverCreateXMLConf(virQEMUDriver *driver, virCPUDef * virQEMUDriverGetHostCPU(virQEMUDriver *driver) { - virCPUDef *hostcpu; - - qemuDriverLock(driver); + virCPUDef *hostcpu =3D NULL; =20 - if (!driver->hostcpu) - driver->hostcpu =3D virCPUProbeHost(virArchFromHost()); - - hostcpu =3D driver->hostcpu; - - qemuDriverUnlock(driver); + VIR_WITH_MUTEX_LOCK_GUARD(&driver->lock) { + if (!driver->hostcpu) + driver->hostcpu =3D virCPUProbeHost(virArchFromHost()); + hostcpu =3D driver->hostcpu; + } =20 if (hostcpu) virCPUDefRef(hostcpu); @@ -1389,32 +1373,27 @@ virCaps *virQEMUDriverCreateCapabilities(virQEMUDri= ver *driver) * Returns: a reference to a virCaps *instance or NULL */ virCaps *virQEMUDriverGetCapabilities(virQEMUDriver *driver, - bool refresh) + bool refresh) { - virCaps *ret =3D NULL; if (refresh) { virCaps *caps =3D NULL; if ((caps =3D virQEMUDriverCreateCapabilities(driver)) =3D=3D NULL) return NULL; =20 - qemuDriverLock(driver); - virObjectUnref(driver->caps); - driver->caps =3D caps; - } else { - qemuDriverLock(driver); - - if (driver->caps =3D=3D NULL || - driver->caps->nguests =3D=3D 0) { - VIR_DEBUG("Capabilities didn't detect any guests. Forcing a " - "refresh."); - qemuDriverUnlock(driver); - return virQEMUDriverGetCapabilities(driver, true); + VIR_WITH_MUTEX_LOCK_GUARD(&driver->lock) { + virObjectUnref(driver->caps); + driver->caps =3D caps; + return virObjectRef(driver->caps); } } =20 - ret =3D virObjectRef(driver->caps); - qemuDriverUnlock(driver); - return ret; + VIR_WITH_MUTEX_LOCK_GUARD(&driver->lock) { + if (driver->caps && driver->caps->nguests > 0) + return virObjectRef(driver->caps); + } + + VIR_DEBUG("Capabilities didn't detect any guests. Forcing a refresh."); + return virQEMUDriverGetCapabilities(driver, true); } =20 =20 --=20 2.31.1