From nobody Sat Feb 7 06:13:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1646825965; cv=none; d=zohomail.com; s=zohoarc; b=jZ4wFsieKqzXA+gLaNiJTFTrZ5wKt1ztBK1xwjSNITK+v+4yfyGCQL9s1xMcxyAk0ZMFopNfAOW5A4qQVQ42wb0RSAIEDEc9YYK2/ibuy4y/E47XLjfYB6L8H6ubrhYECDeoLspmAJWShWBcA/Y3btfPF2aWW0BVHe+hpkJT6bY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646825965; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=8OSDXOxWlmcMLEXfdJm+RtOv6Kx5J6P7/Yvdr6lq2Oc=; b=h4/ANtaG61JyL0nnqh/RBm+Qb9ZbiHpe7u9CQZvJ6CHsFVxejKZnDq6QGQbHdJCSqqeeo6mz6qDWsVegdPjdJfe4luFPzGcJbszfQKpDwdNQIcjDkLlY6WO0jWWLoaGmIMdMHnQ5vZFaUSOxZ6AMXl6c9EktfWv7I+Iu5MQdkg4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1646825965434963.775764916712; Wed, 9 Mar 2022 03:39:25 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-101-Q3jFCgKROkKKnjwp7SlPyw-1; Wed, 09 Mar 2022 06:39:20 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D347318812CD; Wed, 9 Mar 2022 11:39:18 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 665807C1859; Wed, 9 Mar 2022 11:39:17 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id ED0CF195FD40; Wed, 9 Mar 2022 11:39:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 797FE195F403 for ; Wed, 9 Mar 2022 11:39:14 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2A460100EB3B; Wed, 9 Mar 2022 11:39:14 +0000 (UTC) Received: from domokun.gsslab.fab.redhat.com (gx270-2.gsslab.fab.redhat.com [10.33.8.41]) by smtp.corp.redhat.com (Postfix) with ESMTP id 99B5A105958B; Wed, 9 Mar 2022 11:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646825964; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8OSDXOxWlmcMLEXfdJm+RtOv6Kx5J6P7/Yvdr6lq2Oc=; b=EwEekfhM3x9ihgPorIPh9yQXdywuaXxF/m9KvThatulfAPGTS3RFnTaWkOHiQ2JGFQLg39 R9nYLzC3Xzz/7YOTzVvk/vas5VjrgRGVvlobOyC3Zh0nO9ahrQ5m8Z0ZaOpLpRNkytbmFz ctUIU4TvbbTzeZYnzuaIxb0Z907Ao8w= X-MC-Unique: Q3jFCgKROkKKnjwp7SlPyw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [PATCH] conf: remove misleading comments about access being 'lockless' Date: Wed, 9 Mar 2022 11:39:11 +0000 Message-Id: <20220309113911.939371-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1646825966450100001 For the various structs storing lists of objects, the access to the hash tables is not lockless. The mutex on the object owning the hash table must be held. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=C3=A1n Tomko --- src/conf/virdomainobjlist.c | 4 ++-- src/conf/virinterfaceobj.c | 2 +- src/conf/virnodedeviceobj.c | 2 +- src/conf/virnwfilterbindingobjlist.c | 2 +- src/conf/virsecretobj.c | 2 +- src/conf/virstorageobj.c | 10 +++++----- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/conf/virdomainobjlist.c b/src/conf/virdomainobjlist.c index 70b73e87ec..66bd4bcba7 100644 --- a/src/conf/virdomainobjlist.c +++ b/src/conf/virdomainobjlist.c @@ -46,11 +46,11 @@ struct _virDomainObjList { virObjectRWLockable parent; =20 /* uuid string -> virDomainObj mapping - * for O(1), lockless lookup-by-uuid */ + * for O(1), lookup-by-uuid */ GHashTable *objs; =20 /* name -> virDomainObj mapping for O(1), - * lockless lookup-by-name */ + * lookup-by-name */ GHashTable *objsName; }; =20 diff --git a/src/conf/virinterfaceobj.c b/src/conf/virinterfaceobj.c index 62b21b5e5f..95279d5b1c 100644 --- a/src/conf/virinterfaceobj.c +++ b/src/conf/virinterfaceobj.c @@ -44,7 +44,7 @@ struct _virInterfaceObjList { virObjectRWLockable parent; =20 /* name string -> virInterfaceObj mapping - * for O(1), lockless lookup-by-name */ + * for O(1), lookup-by-name */ GHashTable *objsName; }; =20 diff --git a/src/conf/virnodedeviceobj.c b/src/conf/virnodedeviceobj.c index ba84dce82b..fd23ea5fc7 100644 --- a/src/conf/virnodedeviceobj.c +++ b/src/conf/virnodedeviceobj.c @@ -48,7 +48,7 @@ struct _virNodeDeviceObjList { virObjectRWLockable parent; =20 /* name string -> virNodeDeviceObj mapping - * for O(1), lockless lookup-by-name */ + * for O(1), lookup-by-name */ GHashTable *objs; =20 }; diff --git a/src/conf/virnwfilterbindingobjlist.c b/src/conf/virnwfilterbin= dingobjlist.c index 03441c9c1b..53713d815a 100644 --- a/src/conf/virnwfilterbindingobjlist.c +++ b/src/conf/virnwfilterbindingobjlist.c @@ -39,7 +39,7 @@ struct _virNWFilterBindingObjList { virObjectRWLockable parent; =20 /* port dev name -> virNWFilterBindingObj mapping - * for O(1), lockless lookup-by-port dev */ + * for O(1), lookup-by-port dev */ GHashTable *objs; }; =20 diff --git a/src/conf/virsecretobj.c b/src/conf/virsecretobj.c index ed62856d61..92985c4b63 100644 --- a/src/conf/virsecretobj.c +++ b/src/conf/virsecretobj.c @@ -54,7 +54,7 @@ struct _virSecretObjList { virObjectRWLockable parent; =20 /* uuid string -> virSecretObj mapping - * for O(1), lockless lookup-by-uuid */ + * for O(1), lookup-by-uuid */ GHashTable *objs; }; =20 diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index d527132184..b57c1cb8b2 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -66,15 +66,15 @@ struct _virStorageVolObjList { virObjectRWLockable parent; =20 /* key string -> virStorageVolObj mapping - * for (1), lockless lookup-by-key */ + * for (1), lookup-by-key */ GHashTable *objsKey; =20 /* name string -> virStorageVolObj mapping - * for (1), lockless lookup-by-name */ + * for (1), lookup-by-name */ GHashTable *objsName; =20 /* path string -> virStorageVolObj mapping - * for (1), lockless lookup-by-path */ + * for (1), lookup-by-path */ GHashTable *objsPath; }; =20 @@ -98,11 +98,11 @@ struct _virStoragePoolObjList { virObjectRWLockable parent; =20 /* uuid string -> virStoragePoolObj mapping - * for (1), lockless lookup-by-uuid */ + * for (1), lookup-by-uuid */ GHashTable *objs; =20 /* name string -> virStoragePoolObj mapping - * for (1), lockless lookup-by-name */ + * for (1), lookup-by-name */ GHashTable *objsName; }; =20 --=20 2.35.1