From nobody Mon Feb 9 11:46:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1646415001; cv=none; d=zohomail.com; s=zohoarc; b=hckNU+0Yc70Qeb47rj8CCV2Cq1sAg2xRd8GeXxKd8yQTf0/Igdqh2QuzKt6E55Bn6WD+gyuS/+o+/2eFMBD7+pSiD2vkdG+e+vmnDAHk+9Kl/K/zd2S8+y6UvUU/F5bJ1MYaHBHu6tuPYcTz24Db265az6xFfbPDz4lqN5LuApM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646415001; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qEycrvGaeZYEaO+++7Np9vs92KoimTd1h12Q4adIlfA=; b=Svp9n1sqHCTNOkyXSzj1zPlUEQgn496PUfWcGVomH/skGE6qp3OvLgeBfQ1CWl2d867Olp4bfcI1dZhkLOCEtBC+UPBgR+HAW2+VYfboH/15H0H4TKQ51ZDqB2DBd5CV819AGh2YRir8F0392pDkLrntKxUCkT9DjdupxiZ9DjU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1646415001671710.8059653789832; Fri, 4 Mar 2022 09:30:01 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-241-sIEYKHQdOraGo0GKLEsrAQ-1; Fri, 04 Mar 2022 12:29:57 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9F2A85218; Fri, 4 Mar 2022 17:29:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80A1B8659C; Fri, 4 Mar 2022 17:29:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5411644A5F; Fri, 4 Mar 2022 17:29:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 224HTW27024656 for ; Fri, 4 Mar 2022 12:29:32 -0500 Received: by smtp.corp.redhat.com (Postfix) id D671386B48; Fri, 4 Mar 2022 17:29:32 +0000 (UTC) Received: from work.speedport.ip (unknown [10.39.195.86]) by smtp.corp.redhat.com (Postfix) with ESMTP id 165D97DE4C; Fri, 4 Mar 2022 17:29:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646415000; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qEycrvGaeZYEaO+++7Np9vs92KoimTd1h12Q4adIlfA=; b=G+4aUkoWvTj2AuJWtgwNjsXlB5t//lWfIGSxRi8t25WxfXUR+A5sD2L1WydZBV664X2EtY xWF41IiMxe4M/Eiuo3YyrL0Mnk7zX6Zky9McZaRWNScPnu9jVkhbLYzfzoKu2RC0FJK3p5 F/hQHyj2+F+NCYRVA9OK4xIi2OyQwak= X-MC-Unique: sIEYKHQdOraGo0GKLEsrAQ-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 10/10] storage: Use automatic mutex management Date: Fri, 4 Mar 2022 18:28:40 +0100 Message-Id: <20220304172840.66057-11-twiederh@redhat.com> In-Reply-To: <20220304172840.66057-1-twiederh@redhat.com> References: <20220304172840.66057-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1646415002181100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/storage/storage_driver.c | 25 +++++++------------------ 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index ee710f6b76..e3e1604311 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -65,16 +65,6 @@ struct _virStorageVolStreamInfo { char *vol_path; }; =20 -static void storageDriverLock(void) -{ - virMutexLock(&driver->lock); -} -static void storageDriverUnlock(void) -{ - virMutexUnlock(&driver->lock); -} - - static void storagePoolRefreshFailCleanup(virStorageBackend *backend, virStoragePoolObj *obj, @@ -348,14 +338,13 @@ storageStateReload(void) if (!driver) return -1; =20 - storageDriverLock(); - virStoragePoolObjLoadAllState(driver->pools, - driver->stateDir); - virStoragePoolObjLoadAllConfigs(driver->pools, - driver->configDir, - driver->autostartDir); - storageDriverAutostart(); - storageDriverUnlock(); + VIR_WITH_MUTEX_LOCK_GUARD(&driver->lock) { + virStoragePoolObjLoadAllState(driver->pools, driver->stateDir); + virStoragePoolObjLoadAllConfigs(driver->pools, + driver->configDir, + driver->autostartDir); + storageDriverAutostart(); + } =20 return 0; } --=20 2.31.1