From nobody Sun Feb 8 10:33:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1645622584572857.6911280141682; Wed, 23 Feb 2022 05:23:04 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-524-LqS93xEoM76romDxEH2JtA-1; Wed, 23 Feb 2022 08:23:01 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BC3511091DB8; Wed, 23 Feb 2022 13:22:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C9161062255; Wed, 23 Feb 2022 13:22:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6F2BA55344; Wed, 23 Feb 2022 13:22:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21NDKFYP029717 for ; Wed, 23 Feb 2022 08:20:15 -0500 Received: by smtp.corp.redhat.com (Postfix) id 39BBE53CF; Wed, 23 Feb 2022 13:20:15 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 354B1776C for ; Wed, 23 Feb 2022 13:20:09 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A68C6185A7BA for ; Wed, 23 Feb 2022 13:20:09 +0000 (UTC) Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-193-MXfQtR-7N2mebRh-5KTDWQ-2; Wed, 23 Feb 2022 08:20:07 -0500 Received: by mail-ot1-f47.google.com with SMTP id j8-20020a056830014800b005ad00ef6d5dso11951669otp.0 for ; Wed, 23 Feb 2022 05:20:07 -0800 (PST) Received: from rekt.ibmuc.com ([191.193.99.92]) by smtp.gmail.com with ESMTPSA id a4sm27646154oaa.42.2022.02.23.05.20.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 05:20:07 -0800 (PST) X-MC-Unique: LqS93xEoM76romDxEH2JtA-1 X-MC-Unique: MXfQtR-7N2mebRh-5KTDWQ-2 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9fYXkarVINkGOPsL09GYXEkThVbcMs9ON2us7lwHUaQ=; b=mh32WgHc5HzL+n1eOmCbcyetzwscovILUnN3+h1q8XLHD68XGpSoz/oIGp+caw5egm J6YjSKpN1cKJaTyeq0/W1dkbo2jkxzAebE7g11G3qdAcYD4HsmwOHEqOcBJBOqbEKs+J Kbc5/j4eHqM6Vs6AglPt0Mx6dx3gUjYrFCORWkTsbSXKOBqo9muixjT95Hh1qpfm0P50 roq+beLo+njFEQTiq7ALWQ4ng8boJX3HUfHuheYgxH+EeiIs5Gl8bcv5hWbwPocl4FUd aOQCSlCmz2UFgt016as1CmrirtltXXgPCV0GNBFVe2Vqoripql6QTXd7mUIx0lI6xBru a2lw== X-Gm-Message-State: AOAM53034xn4i5IHs+efD59HN+yTn+BTrvxH+geIqP+XS8XWXorj5MWp N0Drb6Dg/dPMyd31oxPvGvHa8uCsGrs= X-Google-Smtp-Source: ABdhPJy1pWDcYx6gL3X+Bcpx3z2l16F2DTRFIMsyiOGa7tw2H2Um4PjItNtAnkvBuuStg3w0/+rvoQ== X-Received: by 2002:a05:6830:1f5b:b0:5a2:2ec7:4ea4 with SMTP id u27-20020a0568301f5b00b005a22ec74ea4mr10055320oth.206.1645622407253; Wed, 23 Feb 2022 05:20:07 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v3 04/29] qemu_validate.c: use qemuDomainIsPowerPC() in qemuValidateDomainChrDef() Date: Wed, 23 Feb 2022 10:19:27 -0300 Message-Id: <20220223131952.922228-5-danielhb413@gmail.com> In-Reply-To: <20220223131952.922228-1-danielhb413@gmail.com> References: <20220223131952.922228-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: danielhb413@gmail.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1645622585584100011 Both PowerNV and pSeries machines don't support parallel ports. Reviewed-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index f27e480696..f90348c324 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2012,7 +2012,7 @@ qemuValidateDomainChrDef(const virDomainChrDef *dev, return -1; =20 if (dev->deviceType =3D=3D VIR_DOMAIN_CHR_DEVICE_TYPE_PARALLEL && - (ARCH_IS_S390(def->os.arch) || qemuDomainIsPSeries(def))) { + (ARCH_IS_S390(def->os.arch) || qemuDomainIsPowerPC(def))) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("parallel ports are not supported")); return -1; --=20 2.35.1