From nobody Sun Feb 8 14:52:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1645622562380724.0381504831473; Wed, 23 Feb 2022 05:22:42 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-134-FgtevIXsMb2MDkxT_ZqWbw-1; Wed, 23 Feb 2022 08:22:39 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AE45F1883521; Wed, 23 Feb 2022 13:22:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9004B832B9; Wed, 23 Feb 2022 13:22:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4B6EC44A59; Wed, 23 Feb 2022 13:22:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21NDK7XF029663 for ; Wed, 23 Feb 2022 08:20:07 -0500 Received: by smtp.corp.redhat.com (Postfix) id 65AB940D2962; Wed, 23 Feb 2022 13:20:07 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 619A040D1B9F for ; Wed, 23 Feb 2022 13:20:07 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 49ECD802E5B for ; Wed, 23 Feb 2022 13:20:07 +0000 (UTC) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-345-rw2ghOQhNZCZsYMSv1yQ3w-1; Wed, 23 Feb 2022 08:20:05 -0500 Received: by mail-ot1-f43.google.com with SMTP id k22-20020a9d4b96000000b005ad5211bd5aso10054788otf.8 for ; Wed, 23 Feb 2022 05:20:05 -0800 (PST) Received: from rekt.ibmuc.com ([191.193.99.92]) by smtp.gmail.com with ESMTPSA id a4sm27646154oaa.42.2022.02.23.05.20.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 05:20:04 -0800 (PST) X-MC-Unique: FgtevIXsMb2MDkxT_ZqWbw-1 X-MC-Unique: rw2ghOQhNZCZsYMSv1yQ3w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xtu/FQfOjdl9obhxdpSlzWAWrLb+Wql6gU+gDgUKuO4=; b=sgDT9vLrlhRWefkToSxlWF/uXhnXNvTRaVukb53iFPjEB5KkYqLAhQjktFbvgE+DfW s6JURNWGL/Heeu3S0t5m4ZJv4Syp1t4xACC5OaT9Ep4XqBhS2ZqGzVyQZXHBdCnobbZY OaqcEpbkg4bvNGFO6yw0qwSk8qEF0P0gCDraxbwvCFuAbZINO2INYkcZxKE7YGB5hB+b oK0FH4S5gO/sl/0Sfm73pE2j423DFcZ+Mii80r0lm+80xRLKuMdLk+WZRlYKqjf9fc4u 1IynuGTuIiCYRngc54aPMdia92jYKYhW6TWxTukgFvOk8N8fCYUS2v0ospM4K3r2sHzi NRAw== X-Gm-Message-State: AOAM532eWP0q3/w9pAwahuT9+qJd1R9Jvh+/P/IZHUrPjtDvQdGl0aYK poYdzLkzD511noDJ01LxUgWuzAHSfcs= X-Google-Smtp-Source: ABdhPJzagIvbX25IcRmAze4rn3t6Rh7eEQLq8qZVhpPXcVsoKnqPO80uM221r71+Al0ldp0VPYCOJA== X-Received: by 2002:a05:6830:3490:b0:5af:894e:c5b9 with SMTP id c16-20020a056830349000b005af894ec5b9mr2011526otu.328.1645622404605; Wed, 23 Feb 2022 05:20:04 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v3 02/29] qemu_capabilities.c: use 'MachineIsPowerPC' in DeviceDiskCaps Date: Wed, 23 Feb 2022 10:19:25 -0300 Message-Id: <20220223131952.922228-3-danielhb413@gmail.com> In-Reply-To: <20220223131952.922228-1-danielhb413@gmail.com> References: <20220223131952.922228-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-loop: libvir-list@redhat.com Cc: danielhb413@gmail.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1645622564124100001 Both pSeries and PowerNV machines don't have floppy device support. Reviewed-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_capabilities.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 529e9ceaf5..28e7820d0e 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -6190,8 +6190,8 @@ virQEMUCapsFillDomainDeviceDiskCaps(virQEMUCaps *qemu= Caps, VIR_DOMAIN_DISK_DEVICE_CDROM, VIR_DOMAIN_DISK_DEVICE_LUN); =20 - /* PowerPC pseries based VMs do not support floppy device */ - if (!qemuDomainMachineIsPSeries(machine, qemuCaps->arch)) { + /* PowerPC domains do not support floppy device */ + if (!qemuDomainMachineIsPowerPC(machine, qemuCaps->arch)) { VIR_DOMAIN_CAPS_ENUM_SET(disk->diskDevice, VIR_DOMAIN_DISK_DEVICE_= FLOPPY); VIR_DOMAIN_CAPS_ENUM_SET(disk->bus, VIR_DOMAIN_DISK_BUS_FDC); } --=20 2.35.1