From nobody Mon Feb 9 10:47:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1643721824; cv=none; d=zohomail.com; s=zohoarc; b=Snb0/R7/tloOJusjETXgcj/e3H0Va1Cnm0FR68kIi8M3weCUTx5vg/smA62uosfNGnmthTkAlHjloG7yLyqbERNl+wHwX/zYvEX9JimGIiahvcVROaxWknNLpzZSe1kAWMp5qtbyZPfjtTYPT7oiQFjF+Pje/hrxkr8jpV7IKYw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643721824; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6q2BwkSpg9KjkBdtWexaSoUiQYWpCU28HhqIEshNqXs=; b=YrJH3nB2gpqVtf6qKU6AOGuMae4uqs5GMuF/o+THAuqgGnOECrdM6fbee8ZVVATWGhG8Lt1hUWMLn1XLPyUOYPCBQ0kXZmCu7KGKQNwfDUjhLORDk5vW6cuzEQ5sMU6vfLFqsdkfr0svL0onFZAB0YOarBuQmIhskpb/Oams/+Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1643721824272340.14893815537596; Tue, 1 Feb 2022 05:23:44 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-440-VMYAgAf_PP2Vag6WnUkC8Q-1; Tue, 01 Feb 2022 08:23:39 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A041C84E20F; Tue, 1 Feb 2022 13:23:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7FB67752AE; Tue, 1 Feb 2022 13:23:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4A9B71809CBF; Tue, 1 Feb 2022 13:23:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 211DKQ35007475 for ; Tue, 1 Feb 2022 08:20:26 -0500 Received: by smtp.corp.redhat.com (Postfix) id C708E10A48B8; Tue, 1 Feb 2022 13:20:26 +0000 (UTC) Received: from work.redhat.com (unknown [10.39.195.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E29B10A48B6; Tue, 1 Feb 2022 13:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643721823; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=6q2BwkSpg9KjkBdtWexaSoUiQYWpCU28HhqIEshNqXs=; b=Fvozch0TwwVXV2iwbOSjURUxx+TkqyYHZFMOSsn+1m150VQJvVm1VFipB+eRzWM9rbcFyb Eo0IvcIfY5QL2SNiZINruPfnHHdHxK14QVWSDUATsNbkUdzxLv4f2AIpzcM/NfiWWgD/JC xprdADd8dLYrmuUjMmQynm0Z9Q3+eIo= X-MC-Unique: VMYAgAf_PP2Vag6WnUkC8Q-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v5 7/9] virChrdevFree: Use VIR_WITH_MUTEX_LOCK Date: Tue, 1 Feb 2022 14:20:15 +0100 Message-Id: <20220201132017.53963-8-twiederh@redhat.com> In-Reply-To: <20220201132017.53963-1-twiederh@redhat.com> References: <20220201132017.53963-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1643721826178100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/virchrdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c index c9b2134e3b..8610f0ac5c 100644 --- a/src/conf/virchrdev.c +++ b/src/conf/virchrdev.c @@ -291,10 +291,10 @@ void virChrdevFree(virChrdevs *devs) if (!devs) return; =20 - virMutexLock(&devs->lock); - virHashForEachSafe(devs->hash, virChrdevFreeClearCallbacks, NULL); - g_clear_pointer(&devs->hash, g_hash_table_unref); - virMutexUnlock(&devs->lock); + VIR_WITH_MUTEX_LOCK_GUARD(&devs->lock) { + virHashForEachSafe(devs->hash, virChrdevFreeClearCallbacks, NULL); + g_clear_pointer(&devs->hash, g_hash_table_unref); + } virMutexDestroy(&devs->lock); =20 g_free(devs); --=20 2.31.1