From nobody Tue Feb 10 05:10:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1643364033; cv=none; d=zohomail.com; s=zohoarc; b=jnbRy5mlYX4Kz5VVq3e6HkZIU79N/ocFVUIIi3nydLUEAs4T8nMpVKs2HRSdt/mKiU73iGrnqrDt0LC3YjMS9NydDXl0B7TnZQxU+dHkrKIgSYoIa/ePQTap5NXDPt/USkm2Eb7gB/4uL+GMqWhPdy/q00+8NX/7fySQ2Z3Yuao= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643364033; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4/mEGk8bGDTECjETsrAbW4myVRIs6dakfiOfgv4xVrU=; b=Yrt36QWdbW8tNV6bqdK5O9rDnWuRosTVO5hy/05hSTWAKsuE1J0zCRBbpaDcuH6IE3hgqb12J/JsVpZrFv9/V4zocQOMaYjU7t+8/VE21uxMthQmL1gEK7XzMTwPOD3yi1diwIlFiX1qhNgBcZMoqqpedN+EeYP/WDFRGa0HFOg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1643364033382469.5321181059552; Fri, 28 Jan 2022 02:00:33 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-296-s33eJO9YPpS8k4o5EE5ubw-1; Fri, 28 Jan 2022 05:00:29 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33E96102C60E; Fri, 28 Jan 2022 09:59:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 141456D032; Fri, 28 Jan 2022 09:59:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DA6494BB7C; Fri, 28 Jan 2022 09:59:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20S9xqXl031789 for ; Fri, 28 Jan 2022 04:59:52 -0500 Received: by smtp.corp.redhat.com (Postfix) id CA11F6D033; Fri, 28 Jan 2022 09:59:52 +0000 (UTC) Received: from work.speedport.ip (unknown [10.39.194.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA4126D032; Fri, 28 Jan 2022 09:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643364032; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4/mEGk8bGDTECjETsrAbW4myVRIs6dakfiOfgv4xVrU=; b=CTLf5OUODCcKF9tLy7eggQ9m5aw/MWG4OMUoKhW+4LTFjsWMgBeBDATCbQc/PkxoYv+1JC J0LmYgNWsvAd1tJ0hxQSA7SYTy8afIMWdfrF5/CUkE96AQHOya9UPNN67d6QjsCjbiCRuu 4Yk5Y/HHVHzhrme2ecdPLvCPgwazZGI= X-MC-Unique: s33eJO9YPpS8k4o5EE5ubw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v4 9/9] lxcDomainDetachDeviceHostdevUSBLive: Use VIR_WITH_OBJECT_LOCK_GUARD Date: Fri, 28 Jan 2022 10:59:22 +0100 Message-Id: <20220128095922.17782-10-twiederh@redhat.com> In-Reply-To: <20220128095922.17782-1-twiederh@redhat.com> References: <20220128095922.17782-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1643364036016100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/lxc/lxc_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 7bc39120ee..42053de9c3 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -4045,9 +4045,9 @@ lxcDomainDetachDeviceHostdevUSBLive(virLXCDriver *dri= ver, VIR_WARN("cannot deny device %s for domain %s: %s", dst, vm->def->name, virGetLastErrorMessage()); =20 - virObjectLock(hostdev_mgr->activeUSBHostdevs); - virUSBDeviceListDel(hostdev_mgr->activeUSBHostdevs, usb); - virObjectUnlock(hostdev_mgr->activeUSBHostdevs); + VIR_WITH_OBJECT_LOCK_GUARD(hostdev_mgr->activeUSBHostdevs) { + virUSBDeviceListDel(hostdev_mgr->activeUSBHostdevs, usb); + } =20 virDomainHostdevRemove(vm->def, idx); virDomainHostdevDefFree(def); --=20 2.31.1