From nobody Tue Feb 10 05:17:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1643210044; cv=none; d=zohomail.com; s=zohoarc; b=f3dWDW83lQX5P4gBgQemOFHhGBVmMQPbQ94en0TfGcDjZt9upJANhdMwIaTE0vSR8U5EKTF9Gw9DPbCOvAtDBu1qZbvO/BJXwnY5h45rK0P0rxy3o1W2chlvVw0JDO7S4D3yerI1JCLAZ8a1Jed/cspcWtM7DD/MMG/Glil7340= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643210044; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=a/WK76h/aDweM5TR7e28wdWfTfeHTPQ0+qiqACiSZ4s=; b=Gddmcjg7Dmoqc4qPZ03iXOwlEIPIYRt826JoY+1NGmcdWexPTEb7lSQuvu3RUpwvYUmn7rCpeCpdfPn3yKogA1y+jAuAHh+3KiXje4WkSZocPPCuQClYOTVw3rBAp7FIiql/29IayaPt4MqOfg1yhi6ThQYU3LbHAw8pxja6aL0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1643210044566651.7609694704436; Wed, 26 Jan 2022 07:14:04 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-190-H2Is3rbvO1WtH3m_fNibaw-1; Wed, 26 Jan 2022 10:14:00 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A7EA1083F9B; Wed, 26 Jan 2022 15:13:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 507D223765; Wed, 26 Jan 2022 15:13:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 128CF1809CBF; Wed, 26 Jan 2022 15:13:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20QFDOwA016861 for ; Wed, 26 Jan 2022 10:13:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0A44B23764; Wed, 26 Jan 2022 15:13:24 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.193.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62E3A23763 for ; Wed, 26 Jan 2022 15:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643210043; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=a/WK76h/aDweM5TR7e28wdWfTfeHTPQ0+qiqACiSZ4s=; b=V4saWKdTay4nM7Q1imdUsWqsZV8tLnu/k9oxov3yXTK8dFh1XlpIt82wXjJ2vwXst8/wpr CvdZeuL8NnE0eOChEGytNKxde27lxwBwfj3cJzrJA3x0tzchFcdoJvPnc1bB7KiXRb3HwT h8JC94YCRLazQwEYc3YtpbgNnoEFE7c= X-MC-Unique: H2Is3rbvO1WtH3m_fNibaw-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 4/5] meson: Require that both qemu_user and qemu_group are provided Date: Wed, 26 Jan 2022 16:13:15 +0100 Message-Id: <20220126151316.26825-5-abologna@redhat.com> In-Reply-To: <20220126151316.26825-1-abologna@redhat.com> References: <20220126151316.26825-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1643210045433100003 Content-Type: text/plain; charset="utf-8" Or that neither is. The current implementation, where if only one of the two is provided the other one will be based on OS-specific defaults is more likely to cause confusion than it is to be helpful. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index f08a25f53c..36ebe9aa2a 100644 --- a/meson.build +++ b/meson.build @@ -1680,10 +1680,13 @@ if not get_option('driver_qemu').disabled() endif endif qemu_user =3D get_option('qemu_user') + qemu_group =3D get_option('qemu_group') + if (qemu_user =3D=3D '' and qemu_group !=3D '') or (qemu_user !=3D '' = and qemu_group =3D=3D '') + error('Please specify both qemu_user and qemu_group or neither of th= em') + endif if qemu_user =3D=3D '' qemu_user =3D default_qemu_user endif - qemu_group =3D get_option('qemu_group') if qemu_group =3D=3D '' qemu_group =3D default_qemu_group endif --=20 2.34.1