From nobody Sat Feb 7 15:30:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1643143798714261.49549381132226; Tue, 25 Jan 2022 12:49:58 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-544-hDsuRR1gNCWQ7AoEUxf6sw-1; Tue, 25 Jan 2022 15:49:56 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E43348144E6; Tue, 25 Jan 2022 20:49:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C07D945D93; Tue, 25 Jan 2022 20:49:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 90E7C180BAAE; Tue, 25 Jan 2022 20:49:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20PKnhRW024209 for ; Tue, 25 Jan 2022 15:49:44 -0500 Received: by smtp.corp.redhat.com (Postfix) id C225F401E80; Tue, 25 Jan 2022 20:49:41 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE38C401E2C for ; Tue, 25 Jan 2022 20:49:41 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AC2388117B4 for ; Tue, 25 Jan 2022 20:49:38 +0000 (UTC) Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-568-aSD1Ss6tOgOrbSnCXwHfCA-1; Tue, 25 Jan 2022 15:49:26 -0500 Received: by mail-oi1-f179.google.com with SMTP id s127so33544375oig.2 for ; Tue, 25 Jan 2022 12:49:26 -0800 (PST) Received: from rekt.COMFAST ([191.8.61.226]) by smtp.gmail.com with ESMTPSA id ay32sm1368569oob.16.2022.01.25.12.49.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 12:49:25 -0800 (PST) X-MC-Unique: hDsuRR1gNCWQ7AoEUxf6sw-1 X-MC-Unique: aSD1Ss6tOgOrbSnCXwHfCA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FDKE7u8serF24STTRFdzOch9cnIPLZReIWC/vrSTQoA=; b=vpZIvHPxgsul2BDF/tMzJTFZ5wSChjQtHjyG6se/TqlvllVAfc4e4sjHqZyYGlQAit if/MCRkXdwDkln38x0ZXCtthOonGiSk5Q4wDNcblqjEgT1OLiQlOSEL5fc8xZKmwmkNM 7ziRedf/SyBTUY3fXBkCagi2JzMenpdK/Bju05F6worYDuXpkIsp2htbC8LKv0gGy5Cv M1cmPRIRUXYjG/PymcuPPht2erEhWjxYg7g0VpKE4XcGPQ+vIJjNNxhKZWPmlngEcVU/ wIPA9Rs1s6NlnZ5EXoH+87XZVfEOOv4Sswkkn17vPI/pCoRS+kKtWr/RoG7oZDwkQ7t6 39sQ== X-Gm-Message-State: AOAM533IzVremKSdo7aPK4RG1zmOWl6XFwGu4ik7M9QxN6yftc3eN5l8 4WOnjn57IyKEV/gLA0gr15WkZbQ0aSo= X-Google-Smtp-Source: ABdhPJwnwp1KArK3WEma7li6nQ2KA3AGLuLe4IRvJvFl+da358IYp8Ti77c7NnSKdxIlg26B/p7ksQ== X-Received: by 2002:a05:6808:230f:: with SMTP id bn15mr1745980oib.95.1643143765736; Tue, 25 Jan 2022 12:49:25 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v2 06/29] qemu_validate.c: enhance 'machine type not supported' message Date: Tue, 25 Jan 2022 17:48:39 -0300 Message-Id: <20220125204902.772350-7-danielhb413@gmail.com> In-Reply-To: <20220125204902.772350-1-danielhb413@gmail.com> References: <20220125204902.772350-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-loop: libvir-list@redhat.com Cc: danielhb413@gmail.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1643143800956100003 Content-Type: text/plain; charset="utf-8" Add 'virt type' to allow for an easier time debugging. Reviewed-by: Peter Krempa Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_validate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 8453413b3c..aa686246f5 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1101,8 +1101,9 @@ qemuValidateDomainDef(const virDomainDef *def, =20 if (!virQEMUCapsIsMachineSupported(qemuCaps, def->virtType, def->os.ma= chine)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Emulator '%s' does not support machine type '%s'= "), - def->emulator, def->os.machine); + _("Emulator '%s' does not support machine type '%s'= for virt type '%s'"), + def->emulator, def->os.machine, + virDomainVirtTypeToString(def->virtType)); return -1; } =20 --=20 2.34.1