From nobody Sat Feb 7 15:30:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 164314380037843.046815102623896; Tue, 25 Jan 2022 12:50:00 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-615-juBWoQzHMCuJyCf4tojtCQ-1; Tue, 25 Jan 2022 15:49:56 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 51ED48144E3; Tue, 25 Jan 2022 20:49:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F36DB18BB; Tue, 25 Jan 2022 20:49:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F15C518077BC; Tue, 25 Jan 2022 20:49:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20PKnehx024181 for ; Tue, 25 Jan 2022 15:49:40 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9754C401E83; Tue, 25 Jan 2022 20:49:38 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast08.extmail.prod.ext.rdu2.redhat.com [10.11.55.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 93E4C401E2D for ; Tue, 25 Jan 2022 20:49:37 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3DE6438183C0 for ; Tue, 25 Jan 2022 20:49:25 +0000 (UTC) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-608-30eEhexyNIyIqwHrxYB7CA-2; Tue, 25 Jan 2022 15:49:23 -0500 Received: by mail-ot1-f54.google.com with SMTP id z25-20020a0568301db900b005946f536d85so27594212oti.9 for ; Tue, 25 Jan 2022 12:49:22 -0800 (PST) Received: from rekt.COMFAST ([191.8.61.226]) by smtp.gmail.com with ESMTPSA id ay32sm1368569oob.16.2022.01.25.12.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 12:49:22 -0800 (PST) X-MC-Unique: juBWoQzHMCuJyCf4tojtCQ-1 X-MC-Unique: 30eEhexyNIyIqwHrxYB7CA-2 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8BCHlGipdX2+LYMV8RrJgDk/MjJjYoUp8shXNiVGE4c=; b=L6EILoUs2Bs7AJsfJk6FSWFKrD4Y0bVA3yAe1T9vflDgsQiDPXv3e411UczGt+vJox LIet8kTDIEWW4KQbdbhvIs1o5G6/7719i2Eqox0pfFgRRGNGLEKVR0SIY8Yl16pgBsVb b4cmy8jN5ycixY4uipv87ydLcgLjMyma20H+6mFZgm3V2JUt+yz5AOWIwJViYMVv7luR 4FDnaGhJN+Bn0vxi7QxaK3NgNG7WWCPGeAnhd4RBUqgEP42AnJCA0NKutBSXRQ/uXcri 1peOYTOezk6GqGavSkr2AgIIEp/Ov6faL71TCHJUzn5L7+EYtgJEFVk25meNJRlvSb6i fRcQ== X-Gm-Message-State: AOAM532piYHv3KJ5xb/5fvbpn4R7PpRlTCTxILXClssVKoMQhnzcbFlp yi/cSoYpVWy4fUOB+WlUOZHRbRvhfjA= X-Google-Smtp-Source: ABdhPJxethw2yT3xd+1jtwNPghVxlR6xBbZJyqXPuxO8SMhCdOwqSvsrZLHampGnYvsg5D4wVRqhPg== X-Received: by 2002:a05:6830:1389:: with SMTP id d9mr6671191otq.287.1643143762655; Tue, 25 Jan 2022 12:49:22 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v2 04/29] qemu_validate.c: use qemuDomainIsPowerPC() in qemuValidateDomainChrDef() Date: Tue, 25 Jan 2022 17:48:37 -0300 Message-Id: <20220125204902.772350-5-danielhb413@gmail.com> In-Reply-To: <20220125204902.772350-1-danielhb413@gmail.com> References: <20220125204902.772350-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-loop: libvir-list@redhat.com Cc: danielhb413@gmail.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1643143803266100001 Content-Type: text/plain; charset="utf-8" Both PowerNV and pSeries machines don't support parallel ports. Reviewed-by: Peter Krempa Signed-off-by: Daniel Henrique Barboza Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 0a879f0115..8453413b3c 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2007,7 +2007,7 @@ qemuValidateDomainChrDef(const virDomainChrDef *dev, return -1; =20 if (dev->deviceType =3D=3D VIR_DOMAIN_CHR_DEVICE_TYPE_PARALLEL && - (ARCH_IS_S390(def->os.arch) || qemuDomainIsPSeries(def))) { + (ARCH_IS_S390(def->os.arch) || qemuDomainIsPowerPC(def))) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("parallel ports are not supported")); return -1; --=20 2.34.1