From nobody Sun Feb 8 01:30:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1642686805177371.79529618030904; Thu, 20 Jan 2022 05:53:25 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-449-wD02ZUxANtyViRlPXkcotg-1; Thu, 20 Jan 2022 08:53:22 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 505E483DD22; Thu, 20 Jan 2022 13:53:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F69A708DB; Thu, 20 Jan 2022 13:53:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F17E94A700; Thu, 20 Jan 2022 13:53:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20KDr4F6008841 for ; Thu, 20 Jan 2022 08:53:04 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0279A141DC2D; Thu, 20 Jan 2022 13:53:04 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast10.extmail.prod.ext.rdu2.redhat.com [10.11.55.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F2CD91402408 for ; Thu, 20 Jan 2022 13:53:03 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DBC751C00F68 for ; Thu, 20 Jan 2022 13:53:03 +0000 (UTC) Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-198-iNxmHmDTPy-TPAJo7J5oSA-1; Thu, 20 Jan 2022 08:53:02 -0500 Received: by mail-oi1-f174.google.com with SMTP id bb37so8991194oib.1 for ; Thu, 20 Jan 2022 05:53:02 -0800 (PST) Received: from rekt.COMFAST ([191.8.61.226]) by smtp.gmail.com with ESMTPSA id a26sm1574102oiy.26.2022.01.20.05.53.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 05:53:01 -0800 (PST) X-MC-Unique: wD02ZUxANtyViRlPXkcotg-1 X-MC-Unique: iNxmHmDTPy-TPAJo7J5oSA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yYsWskqxVjEEZQ5rK4BMvy2Apf+6bXFZH/QD7q8z7Us=; b=p/dGZTjpKUc3wGc7MBgr29ubuDlXdVIy1E6w0TP27/nSeRXsdQLXfpCemYD+JuzRh5 A+sI+e9ElPVVXJJ6gSVI8S1fErtwCqpXw2M2bvTDFGMTmGemjNI/S9FL6xocA7UNvWel DEI8buMgr6836DLNbcjA2atd/S7Q2ueMYLkAVT6P4MD8cLnBDRMhxROiaSDKEJZkP0pg jfbYIXncYJpB0Wz54Q29FDxSjnyhM7rCERfI74qzvxnG8lhKtw6Iyw5bFuILd2MO7YLN bBOP4fSLRwZTS4ut+yH+PfP5ghynKc74Qq/7ov7IKeJrRnRRFMAnT57WCl7nrWC4+UfQ X/EQ== X-Gm-Message-State: AOAM533bjQTmNvQ/R+CqBFUEUFGUGpyEthUgfFhvXJ+q7C/MPpr6UDMT 9f7teFkzVP0YRIPqGwfySghhAeNjOXM= X-Google-Smtp-Source: ABdhPJyOlbG7vhuMTeKU1mhB86PKy5tc8/eJgPW08HdoJywWj8qAPPr1tO4Z/bnoDiwCmvtzu+drZA== X-Received: by 2002:a05:6808:1490:: with SMTP id e16mr7578491oiw.84.1642686781567; Thu, 20 Jan 2022 05:53:01 -0800 (PST) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH 06/33] qemu_validate.c: enhance 'machine type not supported' message Date: Thu, 20 Jan 2022 10:52:09 -0300 Message-Id: <20220120135236.719924-7-danielhb413@gmail.com> In-Reply-To: <20220120135236.719924-1-danielhb413@gmail.com> References: <20220120135236.719924-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-loop: libvir-list@redhat.com Cc: fbarrat@linux.ibm.com, danielhb413@gmail.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1642686805679100003 Content-Type: text/plain; charset="utf-8" Add 'virt type' to allow for an easier time debugging. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_validate.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index da41848761..95af0ecf3b 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1101,8 +1101,10 @@ qemuValidateDomainDef(const virDomainDef *def, =20 if (!virQEMUCapsIsMachineSupported(qemuCaps, def->virtType, def->os.ma= chine)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Emulator '%s' does not support machine type '%s'= "), - def->emulator, def->os.machine); + _("Emulator '%s' does not support machine type '%s'= " + "for virt type '%s'"), + def->emulator, def->os.machine, + virDomainVirtTypeToString(def->virtType)); return -1; } =20 --=20 2.34.1