[libvirt PATCH] manpages: libvirt-guests: Fix typos

Tim Wiederhake posted 1 patch 2 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220119100849.15591-1-twiederh@redhat.com
docs/manpages/libvirt-guests.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[libvirt PATCH] manpages: libvirt-guests: Fix typos
Posted by Tim Wiederhake 2 years, 2 months ago
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
---
 docs/manpages/libvirt-guests.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/manpages/libvirt-guests.rst b/docs/manpages/libvirt-guests.rst
index 76045ed11a..bea08e3bff 100644
--- a/docs/manpages/libvirt-guests.rst
+++ b/docs/manpages/libvirt-guests.rst
@@ -21,7 +21,7 @@ DESCRIPTION
 ===========
 
 ``libvirt-guests`` is a service that can be used to coordinate guest and host
-lifecyle actions. By default, ``libvirt-guests`` will suspend running guests
+lifecycle actions. By default, ``libvirt-guests`` will suspend running guests
 when the host shuts down, and restore them to their pre-shutdown state when
 the host reboots.
 
@@ -40,7 +40,7 @@ FILES
 =====
 
 ``libvirt-guests`` defines several variables to control service behavior.
-The default vaule of these variables can be overridden in:
+The default value of these variables can be overridden in:
 
 * ``@SYSCONFDIR@/sysconfig/libvirt-guests``
 
-- 
2.31.1

Re: [libvirt PATCH] manpages: libvirt-guests: Fix typos
Posted by Erik Skultety 2 years, 2 months ago
On Wed, Jan 19, 2022 at 11:08:49AM +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>

Re: [libvirt PATCH] manpages: libvirt-guests: Fix typos
Posted by Andrea Bolognani 2 years, 2 months ago
On Wed, Jan 19, 2022 at 11:08:49AM +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
> ---
>  docs/manpages/libvirt-guests.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

FYI, in the future you should feel free to push this kind of patch
as trivial instead of waiting for reviews :)

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH] manpages: libvirt-guests: Fix typos
Posted by Tim Wiederhake 2 years, 2 months ago
On Wed, 2022-01-19 at 05:18 -0800, Andrea Bolognani wrote:
> On Wed, Jan 19, 2022 at 11:08:49AM +0100, Tim Wiederhake wrote:
> > Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
> > ---
> >  docs/manpages/libvirt-guests.rst | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Andrea Bolognani <abologna@redhat.com>
> 
> FYI, in the future you should feel free to push this kind of patch
> as trivial instead of waiting for reviews :)
> 
I am a non-native speaker applying fixes suggested by a piece of
software and I had people object to some of those fixes before.

Hopefully I'll get the spell checker integration done soon, and there
will be less of those patches.

Tim

Re: [libvirt PATCH] manpages: libvirt-guests: Fix typos
Posted by Andrea Bolognani 2 years, 2 months ago
On Wed, Jan 19, 2022 at 02:51:57PM +0100, Tim Wiederhake wrote:
> On Wed, 2022-01-19 at 05:18 -0800, Andrea Bolognani wrote:
> > FYI, in the future you should feel free to push this kind of patch
> > as trivial instead of waiting for reviews :)
>
> I am a non-native speaker applying fixes suggested by a piece of
> software and I had people object to some of those fixes before.

This case look absolutely clear-cut to me. Either way, mine was just
a suggestion: if you're more comfortable having your changes reviewed
by another developer before pushing them, then by all means keep
doing that :)

-- 
Andrea Bolognani / Red Hat / Virtualization