From nobody Wed May 8 15:20:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1642187056; cv=none; d=zohomail.com; s=zohoarc; b=M5llfDPCYMikNzSJJdcYX3nYsoBj0R3qxcy7sscfKe3R+rsvlay09nLbeuFpaQ8hqTJyC+ShLYrs6aSd3se7IpTyMekf/wVf8TfPSxjrsDnRpST1/iRS1KqF/M/dPE4hT5avLc2xS3UI1jAmiiRhw8wahWnCi/OMj2lrfemOqFY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642187056; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OI9ibcUOjkY9sLhrHJFQFSgHGgaRxIDX7WGx/w5yj4w=; b=Hjutwcrnm1INSfe+awZuX42JUUDA/LzySkLTANuFikz+2D0J8huGZX+eFGpsmXvc6cLrEVSl+B83tGNTvazn+ynRk4Aq7DJsqsQd1mQR9fxq3ACBnU5fFhYFX9sasKxWGaN4e46u6C1QJdBBIBDU9J4RqIHCfCcz7K5BgK7a9jg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1642187056603356.64394774852747; Fri, 14 Jan 2022 11:04:16 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-321-J770S5BxNF2NRgG9JKHouA-1; Fri, 14 Jan 2022 14:04:11 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D8D15184608F; Fri, 14 Jan 2022 19:04:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD9D75DD68; Fri, 14 Jan 2022 19:03:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7F9E34CA93; Fri, 14 Jan 2022 19:03:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20EIxKQR022498 for ; Fri, 14 Jan 2022 13:59:20 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8A83977FE2; Fri, 14 Jan 2022 18:59:20 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6AF877EBD; Fri, 14 Jan 2022 18:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642187055; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=OI9ibcUOjkY9sLhrHJFQFSgHGgaRxIDX7WGx/w5yj4w=; b=CWCfNiWhPgBoaoOP04xdHClPzyl2RJE/zIvqvbtFyWGQZTnHW5et8X3DxsrIvxKEbOqv1w +d1XG8thAwmEmmoxeGT5F4vnRqOa/JcUTdqWFIklbWLpB8wurYdAuwuP1KwuXCDv597l3J jx+2mI9frAvq4tiGf7M6nVZocnkeOx0= X-MC-Unique: J770S5BxNF2NRgG9JKHouA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/3] configure: bump min required GCC to 7.4.0 Date: Fri, 14 Jan 2022 18:59:09 +0000 Message-Id: <20220114185911.120503-2-berrange@redhat.com> In-Reply-To: <20220114185911.120503-1-berrange@redhat.com> References: <20220114185911.120503-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1642187059611100001 Several distros have been dropped since the last time we bumped the minimum required GCC version. Per repology, currently shipping versions are: RHEL-8: 8.3.1 Debian Buster: 8.3.0 openSUSE Leap 15.2: 7.5.0 Ubuntu LTS 18.04: 7.5.0 Ubuntu LTS 20.04: 9.3.0 FreeBSD: 10.3.0 Fedora 33: 9.2.0 Fedora 34: 11.0.1 OpenBSD: 8.4.0 macOS HomeBrew: 11.1.0 With this list Ubuntu LTS 18.04 / openSUSE Leap 15.2 are the constraint at 7.5.0. When QEMU bumped GCC to 7.5.0, however, it was reported that this is a problem for NetBSD which still ships 7.4.0. NetBSD is not an officially targetted platform for libvirt. Given that QEMU saw complaints about this and the feature difference between GCC 7.4.0 and 7.5.0 is minor, I'm being friendly and sticking 7.4.0. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=C3=A1n Tomko --- config.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/config.h b/config.h index 0eacfd139d..2ef32c8627 100644 --- a/config.h +++ b/config.h @@ -45,9 +45,9 @@ # endif # endif #elif defined(__GNUC__) && defined(__GNUC_MINOR__) -# if __GNUC__ < 4 || (__GNUC__ =3D=3D 4 && __GNUC_MINOR__ < 8) -# error You need at least GCC v4.8 to compile libvirt +# if __GNUC__ < 7 || (__GNUC__ =3D=3D 7 && __GNUC_MINOR__ < 4) +# error You need at least GCC v7.4.0 to compile libvirt # endif #else -# error You either need at least GCC 4.8 or Clang 3.4 or XCode Clang 5.1 t= o compile libvirt +# error You either need at least GCC 7.4.0 or Clang 3.4 or XCode Clang 5.1= to compile libvirt #endif --=20 2.33.1 From nobody Wed May 8 15:20:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1642187250; cv=none; d=zohomail.com; s=zohoarc; b=UEHGlNbJBng4Ob2PNb6sCUHOxMbM7H6chA6IS4CDmEnG8WdhAeUxfEjd6lR0ho5hnV13nRi8l8ytnXmGNcI8BCYGX5MI2BrxbcIfdBTpMUh131XqQNrxoSmX3Xj1zE2+8HiBqRb4iUAYNFISx+ddbPWlYBEK6cUiKbjwOPMM9zc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642187250; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NtGMg1lp1JiKcO1bla33+Au6dA1ayAQdP/ocfbWslaI=; b=jQh3GiXc0eRz6vDvErKz1cvXTHxDYaiNKa25+8O/XD+GNpW8h57kz8IwzzASc7MS4bwIO1I/9iFqg926t4kzaSOV8PYVKumL8JwgFbOA8C2MlrT5N8G0uBlTa21PAX7Xro73PaHRolTX0mxQhFx7hPCuZncW/OdlSJqiJfg9VgA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1642187250768788.8781693094871; Fri, 14 Jan 2022 11:07:30 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-172-LndmUXF5PJaQ58bbsJ4R7Q-1; Fri, 14 Jan 2022 14:07:23 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F9F8839A45; Fri, 14 Jan 2022 19:07:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C1B9560936; Fri, 14 Jan 2022 19:07:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 43A731806D1D; Fri, 14 Jan 2022 19:07:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20EIxLXJ022508 for ; Fri, 14 Jan 2022 13:59:21 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8E62877FE2; Fri, 14 Jan 2022 18:59:21 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id DCB4977EBD; Fri, 14 Jan 2022 18:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642187249; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NtGMg1lp1JiKcO1bla33+Au6dA1ayAQdP/ocfbWslaI=; b=iLCqCQ+qNyuBCVh1o3ZqA+01f9TuYIKySwGTCgkjHAqgUsoYo8k9XYnRi+vM3eH9FPDytc n446c7E5EAwh7meoJFmcm50U5E3TEk9hcV/ZD63vtMfP6JZlwSl+tRjjnvFBqnLTQIe3Ep ox5qCYS1fIUZFDbSH2RZb4Xng8IOP08= X-MC-Unique: LndmUXF5PJaQ58bbsJ4R7Q-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 2/3] configure: bump min required CLang to 6.0 / XCode 10.0 Date: Fri, 14 Jan 2022 18:59:10 +0000 Message-Id: <20220114185911.120503-3-berrange@redhat.com> In-Reply-To: <20220114185911.120503-1-berrange@redhat.com> References: <20220114185911.120503-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1642187251911100001 Several distros have been dropped since the last time we bumped the minimum required CLang version. Per repology, currently shipping versions are: RHEL-8: 10.0.1 Debian Buster: 7.0.1 openSUSE Leap 15.2: 9.0.1 Ubuntu LTS 18.04: 6.0.0 Ubuntu LTS 20.04: 10.0.0 FreeBSD 12: 8.0.1 Fedora 33: 11.0.0 Fedora 34: 11.1.0 With this list Ubuntu LTS 18.04 is the constraint at 6.0.0 An LLVM version of 6.0.0 corresponds to macOS XCode version of 10.0 which dates from Sept 2018. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=C3=A1n Tomko --- config.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/config.h b/config.h index 2ef32c8627..cc887db222 100644 --- a/config.h +++ b/config.h @@ -36,12 +36,12 @@ =20 #if defined(__clang_major__) && defined(__clang_minor__) # ifdef __apple_build_version__ -# if __clang_major__ < 5 || (__clang_major__ =3D=3D 5 && __clang_minor__ = < 1) -# error You need at least XCode Clang v5.1 to compile libvirt +# if __clang_major__ < 10 || (__clang_major__ =3D=3D 10 && __clang_minor_= _ < 0) +# error You need at least XCode Clang v10.0 to compile libvirt # endif # else -# if __clang_major__ < 3 || (__clang_major__ =3D=3D 3 && __clang_minor__ = < 4) -# error You need at least Clang v3.4 to compile libvirt +# if __clang_major__ < 6 || (__clang_major__ =3D=3D 6 && __clang_minor__ = < 4) +# error You need at least Clang v6.0 to compile libvirt # endif # endif #elif defined(__GNUC__) && defined(__GNUC_MINOR__) @@ -49,5 +49,5 @@ # error You need at least GCC v7.4.0 to compile libvirt # endif #else -# error You either need at least GCC 7.4.0 or Clang 3.4 or XCode Clang 5.1= to compile libvirt +# error You either need at least GCC 7.4.0 or Clang 6.0 or XCode Clang 10.= 0 to compile libvirt #endif --=20 2.33.1 From nobody Wed May 8 15:20:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1642187085; cv=none; d=zohomail.com; s=zohoarc; b=M7LASkG0oUsTQK/bqtjBtjbOasRKGdVcTgD/5jj64RdZ5B0C8rqIIq2kEu+8+Ywr7plBoQggnINaR01vPomyzJAB/hEbEzkLXX6L51T/doMUi+kLwE2TbAWoEFOsndTnOWSYFSEC+hOc0o40eRfG9j2BXdCVf6OTVKGzEWDks08= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642187085; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fuUvLIhGfvzTLJdX1HhCmjlp5r9qO6XnZYcjshwFq+c=; b=hFWZjr4c80L0ZoPYoCyr0sME6hyxsnx7QMY/L4WcpIycUHWThMwhzm081mio2ZR3oNzcID+hX2ct395F5SqVGIyFW1OqlSEBZqusNibjk9iaYiX+mVs8ZsupArpRYoGxeRXxg6tJJClPrDUwc5R6d5ufDPFxEyMN8BcLi1gUa3g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1642187085457357.64068373000566; Fri, 14 Jan 2022 11:04:45 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-288-X1AZ9z56MbmepoTfES2fwQ-1; Fri, 14 Jan 2022 14:04:35 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 586D318460AA; Fri, 14 Jan 2022 19:04:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 39AD610013C1; Fri, 14 Jan 2022 19:04:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0A8B44BB7C; Fri, 14 Jan 2022 19:04:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20EIxMs0022520 for ; Fri, 14 Jan 2022 13:59:22 -0500 Received: by smtp.corp.redhat.com (Postfix) id 9501D77FE2; Fri, 14 Jan 2022 18:59:22 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id E313277EBD; Fri, 14 Jan 2022 18:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642187084; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fuUvLIhGfvzTLJdX1HhCmjlp5r9qO6XnZYcjshwFq+c=; b=aBuM5w5tQucduvMgV1YgGN65hRgGlHfYrCR9MDnimM0RfEOTOJHgQcv6FbvideWO5ylSHL SpTyvseLTju0GRcMFV25MUbhrhAAUPMtPruiceBjYlM4v0FML7LdZ8dwBKdj85zWFF4AMs yg9zCzSJmZsLe6k+zpdpkTNPrQsAbT0= X-MC-Unique: X1AZ9z56MbmepoTfES2fwQ-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 3/3] examples: drop some conditionals checks from macros Date: Fri, 14 Jan 2022 18:59:11 +0000 Message-Id: <20220114185911.120503-4-berrange@redhat.com> In-Reply-To: <20220114185911.120503-1-berrange@redhat.com> References: <20220114185911.120503-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1642187086821100001 We no longer need to worry about GCC version older than 7.4.0. The other remaining conditionals checks were also overkill for the example code. In the unlikely event that someone tries to re-use the code in a scenario where further conditions apply they can figure out. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=C3=A1n Tomko --- examples/c/misc/event-test.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/examples/c/misc/event-test.c b/examples/c/misc/event-test.c index 1eec76c79d..1165469a65 100644 --- a/examples/c/misc/event-test.c +++ b/examples/c/misc/event-test.c @@ -12,18 +12,8 @@ #define G_N_ELEMENTS(Array) (sizeof(Array) / sizeof(*(Array))) #define STREQ(a, b) (strcmp(a, b) =3D=3D 0) #define NULLSTR(s) ((s) ? (s) : "") - -#if (4 < __GNUC__ + (6 <=3D __GNUC_MINOR__) \ - && (201112L <=3D __STDC_VERSION__ || !defined __STRICT_ANSI__) \ - && !defined __cplusplus) -# define G_STATIC_ASSERT(cond) _Static_assert(cond, "verify (" #cond ")") -#else -# define G_STATIC_ASSERT(cond) -#endif - -#ifndef G_GNUC_UNUSED -# define G_GNUC_UNUSED __attribute__((__unused__)) -#endif +#define G_STATIC_ASSERT(cond) _Static_assert(cond, "verify (" #cond ")") +#define G_GNUC_UNUSED __attribute__((__unused__)) =20 int run =3D 1; =20 --=20 2.33.1