From nobody Mon Feb 9 23:16:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1642171902; cv=none; d=zohomail.com; s=zohoarc; b=nggtZl1vpuT+5VckJHXDDvlme+QQuBcAOd+HoseaOonDMlndcLUkwpZWpwJT76vl+4NAyuMC0qB34c5dB+quEyIsai44bJ+3oqNFPCt21O49OLq5nR5yjudFvD2clAWxavNzZKyjXWwW9nGHIvSzPwgFm5rLlH8R1320bh3G2fg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642171902; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/c5HCNRgkbW1cW69wqE5x8u6hnsr3JHgzhiStyooI2I=; b=TunAFoLg2MpdMisW8mvcRyvjeiktq40BTv9G9nwCsgRDOnSJ8qSqR6wB17nyaYxHcD/ZoDavassdHthOydpyoXOnp9nwxvmBXtlfFJpUJCcMM55niuNoKqSHrB9JOfBmpXp9QoTJzu8p2r6y67vL4DXNoQ1xpvvn5re1R3tIq4Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 164217190214722.982670667952902; Fri, 14 Jan 2022 06:51:42 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-554-NdLqrUqfMbCBRnbuMdwH1g-1; Fri, 14 Jan 2022 09:51:37 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CB5931083F65; Fri, 14 Jan 2022 14:51:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A51B97B6F4; Fri, 14 Jan 2022 14:51:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 436364A7C9; Fri, 14 Jan 2022 14:51:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20EEpMN4032268 for ; Fri, 14 Jan 2022 09:51:22 -0500 Received: by smtp.corp.redhat.com (Postfix) id AFDD22BCC1; Fri, 14 Jan 2022 14:51:22 +0000 (UTC) Received: from work.redhat.com (unknown [10.39.194.120]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE4912B6CA; Fri, 14 Jan 2022 14:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642171901; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/c5HCNRgkbW1cW69wqE5x8u6hnsr3JHgzhiStyooI2I=; b=bCWFCpv2ynjVADMgcZDT+hlMzNRT2rNnwC6YiqzLGRbS+EQfRrQaDvIEwKxFzYFxS9Jqb3 cnKtMW7yL/7OINqT099kOQ7tnbyjK4uPr5eCeGPu8hI12H+MYq0tl9zXWQFhAQo/YbWR/a TwbMsh6LnmiD1HHJPcbYWlne5FPGcKY= X-MC-Unique: NdLqrUqfMbCBRnbuMdwH1g-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 4/4] docs: coding-style: One variable declaration per line Date: Fri, 14 Jan 2022 15:51:16 +0100 Message-Id: <20220114145116.34866-5-twiederh@redhat.com> In-Reply-To: <20220114145116.34866-1-twiederh@redhat.com> References: <20220114145116.34866-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1642171902736100001 Content-Type: text/plain; charset="utf-8" This was not mentioned before. Signed-off-by: Tim Wiederhake Reviewed-by: J=C3=A1n Tomko --- docs/coding-style.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/docs/coding-style.rst b/docs/coding-style.rst index 14c5136398..e1ed34f764 100644 --- a/docs/coding-style.rst +++ b/docs/coding-style.rst @@ -600,6 +600,19 @@ calling another function. ... } =20 +Define variables on separate lines. This allows for smaller, easier to +understand diffs when changing them. Define variables in the smallest +possible scope. + +:: + + GOOD: + int x; + int y; + + BAD: + int x, y; + Attribute annotations --------------------- =20 --=20 2.31.1